From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04FFDC433DB for ; Fri, 12 Mar 2021 03:27:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C387764EBB for ; Fri, 12 Mar 2021 03:27:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231744AbhCLD0s (ORCPT ); Thu, 11 Mar 2021 22:26:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231643AbhCLD0o (ORCPT ); Thu, 11 Mar 2021 22:26:44 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 500EFC061574 for ; Thu, 11 Mar 2021 19:26:44 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id 18so43363605lff.6 for ; Thu, 11 Mar 2021 19:26:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ERXTmDvOuzBoCJ5riCOMOTJGtMFLgVqrDbOyFkQIKZU=; b=uhDaAHWNhpGodMLTIvN6LLx6pBhfH5Zb9oWCNThrJfA0oF1j/GfZJUJpbCXkeR2am2 1G/QJF7dC1izF5DhNn4vSvNM03Tl1DNt3EXw2JihNbCKmk2uQ6JrFy2AvFpbYHBH57kd 35DVw0c5ZmdUZjgpckrDA4sxUiAm5/IjTNcJyT6Luw/YII5Mxf6fUO4T2W2sNEo28UY6 OJ4Hvtt3gvX6tZQCYDvVTVq4a8juiXXSxbn/3AtBZW406WiV+AFe5rWFJUTeDTtTfLuT +Un5pyNWE34YALBPoSWXuOp3E+KyFsjNFG1ZfPyswpi94NGtF7C0Xi+1r7F94PsMr+Jt 1ERA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ERXTmDvOuzBoCJ5riCOMOTJGtMFLgVqrDbOyFkQIKZU=; b=gHdvCoOTKwjQMzDdSarYiJm8+cp+DYzjz1MIcRp8dBvtxsJJI5FCVtKz8Vn4+qT4OO DHI0DtOneTCjxrc1A7a0qIxamVqxh88ZPBHPOQNtVivpiMhiTRaSTff1tX610KJmdTdV 0AAYeJqarhAOafTGd72Brx5nFoCs7UdVnAuA7FgXZmnvHWC/mCpripzmKnZbZpksLEoJ o3kP/pmOKEmCK+lvrvVDckLVlgmTV3SHzh+k+X5rLMUWKPQ02wV2PcUfEGPHi1lV/srz WIG82/6DjhbfbFJCQUtQUCGvSeXRYOtmk7wFP2Gw74eS/xIWZX5zRMRXg1GzB0HCPCop d8oA== X-Gm-Message-State: AOAM533sdH5up9ZthZneqQZRe7qokNYVE0lGVS7Hk3w91Qtm31ImyFxr EGmj1+dxFA/+TBQEfJqth9eZRivOE8xpCQ6Digt4sA== X-Google-Smtp-Source: ABdhPJxpTifUkJNXNU9AokKWA5VD1wIJvHOn2mEnoq/3b/62z2REb1NnWu2zsZgq+M9fXbTURLREY7ZnF/pug/izHpc= X-Received: by 2002:a05:6512:39c9:: with SMTP id k9mr3942270lfu.432.1615519602400; Thu, 11 Mar 2021 19:26:42 -0800 (PST) MIME-Version: 1.0 References: <20210309100717.253-1-songmuchun@bytedance.com> <20210309100717.253-5-songmuchun@bytedance.com> In-Reply-To: <20210309100717.253-5-songmuchun@bytedance.com> From: Shakeel Butt Date: Thu, 11 Mar 2021 19:26:30 -0800 Message-ID: Subject: Re: [PATCH v3 4/4] mm: memcontrol: move PageMemcgKmem to the scope of CONFIG_MEMCG_KMEM To: Muchun Song Cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Andrew Morton , Vladimir Davydov , LKML , Linux MM , Xiongchun duan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 9, 2021 at 2:09 AM Muchun Song wrote: > > The page only can be marked as kmem when CONFIG_MEMCG_KMEM is enabled. > So move PageMemcgKmem() to the scope of the CONFIG_MEMCG_KMEM. > > As a bonus, on !CONFIG_MEMCG_KMEM build some code can be compiled out. > > Signed-off-by: Muchun Song Reviewed-by: Shakeel Butt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F815C433DB for ; Fri, 12 Mar 2021 03:26:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9EE4064F8E for ; Fri, 12 Mar 2021 03:26:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EE4064F8E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2E20C8D0324; Thu, 11 Mar 2021 22:26:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2ADB88D0317; Thu, 11 Mar 2021 22:26:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1781C8D0324; Thu, 11 Mar 2021 22:26:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0037.hostedemail.com [216.40.44.37]) by kanga.kvack.org (Postfix) with ESMTP id E6C688D0317 for ; Thu, 11 Mar 2021 22:26:44 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 85DAA181AF5C7 for ; Fri, 12 Mar 2021 03:26:44 +0000 (UTC) X-FDA: 77909785128.22.D8941D3 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf05.hostedemail.com (Postfix) with ESMTP id 8826DE0011C0 for ; Fri, 12 Mar 2021 03:26:43 +0000 (UTC) Received: by mail-lf1-f47.google.com with SMTP id f1so43418054lfu.3 for ; Thu, 11 Mar 2021 19:26:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ERXTmDvOuzBoCJ5riCOMOTJGtMFLgVqrDbOyFkQIKZU=; b=uhDaAHWNhpGodMLTIvN6LLx6pBhfH5Zb9oWCNThrJfA0oF1j/GfZJUJpbCXkeR2am2 1G/QJF7dC1izF5DhNn4vSvNM03Tl1DNt3EXw2JihNbCKmk2uQ6JrFy2AvFpbYHBH57kd 35DVw0c5ZmdUZjgpckrDA4sxUiAm5/IjTNcJyT6Luw/YII5Mxf6fUO4T2W2sNEo28UY6 OJ4Hvtt3gvX6tZQCYDvVTVq4a8juiXXSxbn/3AtBZW406WiV+AFe5rWFJUTeDTtTfLuT +Un5pyNWE34YALBPoSWXuOp3E+KyFsjNFG1ZfPyswpi94NGtF7C0Xi+1r7F94PsMr+Jt 1ERA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ERXTmDvOuzBoCJ5riCOMOTJGtMFLgVqrDbOyFkQIKZU=; b=HYdToEuEeGfTaoqXMfO3UfhdRjI2AW2zHmHUBdtFXMxmCupheUz358/SZb/R2q0nyt xVvq3vzUd5o66/UliQmOP8bZQLgFTBXCls4ya5l33Lj/YkuLuWL2UTBKzXqVnOqvCBep dH976kL582p/fiW5KyT6GoLWhdl8HR82wc/a89dIPs/weHq3zdA3LKNz4fk5MKmWIhLl HuxYDTso1s5xqFKXLFlaE+JaXCrbNv4BpolmHjti6pGXKmwa9grOjv7YuXpj7jL5rMUV 12X/C6S6Lx5gCXH4b+6WMddZ8sdSdtIK38uUBW6UiazjDhChJ9mFyS6R0WnLyWUEtQLM gtEw== X-Gm-Message-State: AOAM533yYw0WQdREFZ84PTDvdpMguKt8BN4YUoG5vZKbDN8HJtze3pjP Uxn1ZLfxZq9uUiWLAyRBw2pzAtKLe2MJwdWb73s//w== X-Google-Smtp-Source: ABdhPJxpTifUkJNXNU9AokKWA5VD1wIJvHOn2mEnoq/3b/62z2REb1NnWu2zsZgq+M9fXbTURLREY7ZnF/pug/izHpc= X-Received: by 2002:a05:6512:39c9:: with SMTP id k9mr3942270lfu.432.1615519602400; Thu, 11 Mar 2021 19:26:42 -0800 (PST) MIME-Version: 1.0 References: <20210309100717.253-1-songmuchun@bytedance.com> <20210309100717.253-5-songmuchun@bytedance.com> In-Reply-To: <20210309100717.253-5-songmuchun@bytedance.com> From: Shakeel Butt Date: Thu, 11 Mar 2021 19:26:30 -0800 Message-ID: Subject: Re: [PATCH v3 4/4] mm: memcontrol: move PageMemcgKmem to the scope of CONFIG_MEMCG_KMEM To: Muchun Song Cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Andrew Morton , Vladimir Davydov , LKML , Linux MM , Xiongchun duan Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8826DE0011C0 X-Stat-Signature: tggwc7yc8m6cum5wbss3o9rysafe4j9h Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf05; identity=mailfrom; envelope-from=""; helo=mail-lf1-f47.google.com; client-ip=209.85.167.47 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615519603-820774 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 9, 2021 at 2:09 AM Muchun Song wrote: > > The page only can be marked as kmem when CONFIG_MEMCG_KMEM is enabled. > So move PageMemcgKmem() to the scope of the CONFIG_MEMCG_KMEM. > > As a bonus, on !CONFIG_MEMCG_KMEM build some code can be compiled out. > > Signed-off-by: Muchun Song Reviewed-by: Shakeel Butt