From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9E8CC433FE for ; Thu, 3 Mar 2022 02:32:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 257298D0002; Wed, 2 Mar 2022 21:32:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DD7A8D0001; Wed, 2 Mar 2022 21:32:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07DB28D0002; Wed, 2 Mar 2022 21:32:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id E7F688D0001 for ; Wed, 2 Mar 2022 21:32:30 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BB7DA2487A for ; Thu, 3 Mar 2022 02:32:30 +0000 (UTC) X-FDA: 79201501260.02.89FA986 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf10.hostedemail.com (Postfix) with ESMTP id 5AF7FC0005 for ; Thu, 3 Mar 2022 02:32:30 +0000 (UTC) Received: by mail-pg1-f171.google.com with SMTP id o23so3260227pgk.13 for ; Wed, 02 Mar 2022 18:32:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T9ttcsidXAxnrhr+YVYJqhqdrFG5MPltBdpeuM6MQtE=; b=k9Vb8Z4zMiB4FkLS1Ple+q5EUDXsnpOSK3fdl3KMUUTG4tmRHrK245pNNosquYRnk3 kDSjcSjiUoifh5xBKUcZFMvY0g8wqQiGtaUoplrllCZHUntStyayuBeBUVysykjwf7iL WaMUwktaDcslGS4qGHhyTESEbDmgLHms7MtPDshX6T5ajBB1H1/0+Xu/fpi0+52yt6DN YG9Kxz3coydaw4MV3o6fYfVnT7ZNwobwThLzaZVg3mrekTwAKdl3uBUQ5Z1YSOjSuc9z sgXoqCEIq5d+jpWnnJCruLX+83ndije9qBDVWlC0fYK0xQ5OS9vXQmTg0Zeec7pxzNZc dehg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T9ttcsidXAxnrhr+YVYJqhqdrFG5MPltBdpeuM6MQtE=; b=HN0WnPvKcTephvHX8uFu21V3BhE928g5OPzE13kXy/qAm7vpPR0pZ4QdnxopHcvuQm s+V5I+LNDgt1l3zte1lDcJDzwPE31+W88gAu0HqJMRASgHZnmO4vWaD70HKeu2R1MWHr xO5//ZhQRLJXcLsolSFVbnGPWnc08HqthP0v91LGQhXFG2rQPTRc5xMhay1OP4uvLpx8 pBY4iaYv3mz3DRxRu+6q8fw6DOJMVotlohrpbayGI+J0B2Amtem8sDLWyDCQ3V3xlfN0 U5DyXjwx98ucVUVuM1M59M5ctzQo3yqrEvbYc1BwV6LqDpSs32sDrlG15lEImFKmLZHy fzfA== X-Gm-Message-State: AOAM530bSj9oCa0htVMMtIgxK5q0aP0G9mZUcirbpC8/aWk9DECk8xkD qBDZD+cpPtSxM0MU6N4JTHECULPJazhnokY2SQWOQg== X-Google-Smtp-Source: ABdhPJzdto4jktONqpMaOQFgLEDZwn2Hu7gTL4sRz31/Iek3WBX7Li54RzsCw/RAKcXt9gJBhd3/SVFPYGFHUwVfL5g= X-Received: by 2002:a63:f14b:0:b0:374:7b9e:dc8f with SMTP id o11-20020a63f14b000000b003747b9edc8fmr28508445pgk.357.1646274749083; Wed, 02 Mar 2022 18:32:29 -0800 (PST) MIME-Version: 1.0 References: <20220224185236.qgzm3jpoz2orjfcw@google.com> <20220225180345.GD12037@blackbody.suse.cz> <20220228230949.xrmy6j2glxsoffko@google.com> <20220302025022.nnmpwxmkqed2icck@google.com> In-Reply-To: From: Shakeel Butt Date: Wed, 2 Mar 2022 18:32:17 -0800 Message-ID: Subject: Re: Regression in workingset_refault latency on 5.15 To: Ivan Babrou Cc: =?UTF-8?Q?Michal_Koutn=C3=BD?= , Daniel Dao , kernel-team , Linux MM , Johannes Weiner , Roman Gushchin , Feng Tang , Michal Hocko , Hillf Danton , Andrew Morton , Linus Torvalds Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5AF7FC0005 X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=k9Vb8Z4z; spf=pass (imf10.hostedemail.com: domain of shakeelb@google.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: tuya46uyfqq89yjsfuyb9zpmr75rta9b X-HE-Tag: 1646274750-817286 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 2, 2022 at 2:33 PM Ivan Babrou wrote: > > On Tue, Mar 1, 2022 at 7:40 PM Ivan Babrou wrote: > > > > On Tue, Mar 1, 2022 at 6:50 PM Shakeel Butt wrote: > > > > > > On Tue, Mar 01, 2022 at 04:48:00PM -0800, Ivan Babrou wrote: > > > > > > [...] > > > > > > > Looks like you were right that targeted flush is not going to be as good. > > > > > > > > > Thanks a lot. Can you please try the following patch (independent of other > > > patches) as well? > > > > Sure thing, I'll come back with the numbers tomorrow. > > Measurements from different configurations: [...] > avg = 403261 nsecs, total: 30037729036 nsecs, count: 74487 > > Looks like there are plenty of longer pauses still. Thanks for running this. > > I can also get the numbers from 5.10 for you if you want. Yes please, that would be good to compare with. Also I am going to send a new patch in a couple of minutes for you to try and you don't need to run the "Targeted flush" and the last one which reduces the memcg_vmstats size.