From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80995C433DF for ; Wed, 27 May 2020 21:36:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CFAF20835 for ; Wed, 27 May 2020 21:36:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NSD+l04J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728527AbgE0VgB (ORCPT ); Wed, 27 May 2020 17:36:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726114AbgE0VgA (ORCPT ); Wed, 27 May 2020 17:36:00 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92492C05BD1E for ; Wed, 27 May 2020 14:36:00 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id x22so15353998lfd.4 for ; Wed, 27 May 2020 14:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=as3BYd5V48LzAfXq5MM61GLeWE7HSlJgIWf5MOeOsaA=; b=NSD+l04JBs90l+P0ssMbRlXN6rfx+6DVrxcpxm685MajuD2Z+Gsuuo9i06CdFnke0Z z0BFVRZyLRGq0DR8XQQd++L5Kkd+pwsrvpxdXsDkmGS6ZBIGyAW9Cz9y/GyzTnIqQ/mC Zik5Wcc/OWD5tKk45qnesqvKSmeSFgEFriSm843WY8EyL2WwbKu6GGMOxetZE2Uiu0hX Bp4UQLxCVuiEPENoAx9RHs4/rU4i07qDimCbhFmvC2KvTko542dum7IZsHoiYN2tdbr/ jNKt5y2Gxi7PaNuWa0uxGTE4ewpChgG3uU6kFC5wLc/AMTFkMaWk/AWS7cZsEB8lRWYx CI9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=as3BYd5V48LzAfXq5MM61GLeWE7HSlJgIWf5MOeOsaA=; b=mxJg3TdgfMK4Ob5QI6CIj08HpiL8v9HsOCio6WH8XPmIyZLYDfXue6DW8eLhBWGpib e+mPsRHQ7T6sP1cZ7LSpKAuGh3Es7ko6XrpxdWZTA8pcQNlQC/p04CbEgRe+G3y8gcia /FoCkdpyFQ6Mz0qj6h+UIkmXTIoGb4vN8NgPa38Q21zmF7T295hL/WoQivmDXKy3mg+P WKVyu5azGLVKsBOhIjXmHsVWpyzwyn8aHPaoKkY7M+ajLBwrjkv3Qn+qmrwgTn61uU1/ fTaY92iFEH/hwvbg8O/VZZsBs8tbBMhQr9d+GJN1nXHRO+xWd65nK5PLz4uh7wtM2Z6b 9VvA== X-Gm-Message-State: AOAM532A7zI5HnEUdYSuAnwdJ+i24SX0+S4KzGa0a9TBZLjZ/Z/bW4vv xcfFU3tumVnmyvUhP6wLQDRIiwsT+HyvNxTu03iQ6g== X-Google-Smtp-Source: ABdhPJysoKK5Xdn8qL8s61C5Rb9q6OqJQys+vgn0AbALfz2jYuE8WERfuDUMop/1lJ26i6Qub3Awsm6YywCOYSiB0Kk= X-Received: by 2002:a19:4854:: with SMTP id v81mr11754lfa.189.1590615358686; Wed, 27 May 2020 14:35:58 -0700 (PDT) MIME-Version: 1.0 References: <20200527182958.252402-1-shakeelb@google.com> <20200527194148.GA47905@cmpxchg.org> <20200527134650.18b3fb3f0be85bb73037da20@linux-foundation.org> In-Reply-To: <20200527134650.18b3fb3f0be85bb73037da20@linux-foundation.org> From: Shakeel Butt Date: Wed, 27 May 2020 14:35:47 -0700 Message-ID: Subject: Re: [PATCH resend 3/3] mm: fix LRU balancing effect of new transparent huge pages To: Andrew Morton Cc: Johannes Weiner , Mel Gorman , Roman Gushchin , Michal Hocko , Minchan Kim , Rik van Riel , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2020 at 1:46 PM Andrew Morton wrote: > > On Wed, 27 May 2020 15:41:48 -0400 Johannes Weiner wrote: > > > On Wed, May 27, 2020 at 11:29:58AM -0700, Shakeel Butt wrote: > > > From: Johannes Weiner > > > > > > Currently, THP are counted as single pages until they are split right > > > before being swapped out. However, at that point the VM is already in > > > the middle of reclaim, and adjusting the LRU balance then is useless. > > > > > > Always account THP by the number of basepages, and remove the fixup > > > from the splitting path. > > > > > > Signed-off-by: Johannes Weiner > > > Signed-off-by: Shakeel Butt > > > > This is now already in mm as part of the "mm: balance LRU lists based > > on relative thrashing" series that I sent out last week and where it > > was originally from. > > Yup. I hope [1/3] and [2/3] weren't urgent? No urgency. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FAEEC433E0 for ; Wed, 27 May 2020 21:36:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C4FBF2075A for ; Wed, 27 May 2020 21:36:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NSD+l04J" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4FBF2075A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5946D800B6; Wed, 27 May 2020 17:36:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 542F680010; Wed, 27 May 2020 17:36:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 434AE800B6; Wed, 27 May 2020 17:36:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id 2872580010 for ; Wed, 27 May 2020 17:36:01 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E16FE181AEF00 for ; Wed, 27 May 2020 21:36:00 +0000 (UTC) X-FDA: 76863806880.05.mask37_34747ff87d33d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id CB9281802151B for ; Wed, 27 May 2020 21:36:00 +0000 (UTC) X-HE-Tag: mask37_34747ff87d33d X-Filterd-Recvd-Size: 3923 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 May 2020 21:36:00 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id c12so15347134lfc.10 for ; Wed, 27 May 2020 14:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=as3BYd5V48LzAfXq5MM61GLeWE7HSlJgIWf5MOeOsaA=; b=NSD+l04JBs90l+P0ssMbRlXN6rfx+6DVrxcpxm685MajuD2Z+Gsuuo9i06CdFnke0Z z0BFVRZyLRGq0DR8XQQd++L5Kkd+pwsrvpxdXsDkmGS6ZBIGyAW9Cz9y/GyzTnIqQ/mC Zik5Wcc/OWD5tKk45qnesqvKSmeSFgEFriSm843WY8EyL2WwbKu6GGMOxetZE2Uiu0hX Bp4UQLxCVuiEPENoAx9RHs4/rU4i07qDimCbhFmvC2KvTko542dum7IZsHoiYN2tdbr/ jNKt5y2Gxi7PaNuWa0uxGTE4ewpChgG3uU6kFC5wLc/AMTFkMaWk/AWS7cZsEB8lRWYx CI9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=as3BYd5V48LzAfXq5MM61GLeWE7HSlJgIWf5MOeOsaA=; b=ifmbf8I/3Cz76tAA2rjs8TqoHKVMAX74ih9txKECDEQ+x8ChKv1Bv5BDM6XtSlOhP+ tWV9D5fHTNDBZOouuX6sMKg2eIV9/C32ifKRJxmDIKKtN0ptpMIrjr1oFYgrkV6v7BNp JeMAIxIgnG2gLeEwAzP9s8MWI9HRB4NZlsWuQp1Nd6pHnnCuGftN4ojFv7iobnvHbyaS Rm31OnwQNKjGbaEKvq/m+0jElQNrLRwYnRmE33Ln2zAR7WnH6jbUeBztCl6Xbmd+nYEL wcdZ6mpgI/fWmHPqnxoFPXjiC8iH8ILBvCYQetsyaZP1X9LHlbR4wHbT6Hufg6YxjmM/ D2gg== X-Gm-Message-State: AOAM530vrsfcWxo9qFH/Rh7Kr7pLxWiommDIWgcEJZP4KdcJbKPxhBKy 7vUZmlzKZr/iPcNaKoL94du4AWb1w95z290Eov3kXA== X-Google-Smtp-Source: ABdhPJysoKK5Xdn8qL8s61C5Rb9q6OqJQys+vgn0AbALfz2jYuE8WERfuDUMop/1lJ26i6Qub3Awsm6YywCOYSiB0Kk= X-Received: by 2002:a19:4854:: with SMTP id v81mr11754lfa.189.1590615358686; Wed, 27 May 2020 14:35:58 -0700 (PDT) MIME-Version: 1.0 References: <20200527182958.252402-1-shakeelb@google.com> <20200527194148.GA47905@cmpxchg.org> <20200527134650.18b3fb3f0be85bb73037da20@linux-foundation.org> In-Reply-To: <20200527134650.18b3fb3f0be85bb73037da20@linux-foundation.org> From: Shakeel Butt Date: Wed, 27 May 2020 14:35:47 -0700 Message-ID: Subject: Re: [PATCH resend 3/3] mm: fix LRU balancing effect of new transparent huge pages To: Andrew Morton Cc: Johannes Weiner , Mel Gorman , Roman Gushchin , Michal Hocko , Minchan Kim , Rik van Riel , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: CB9281802151B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 27, 2020 at 1:46 PM Andrew Morton wrote: > > On Wed, 27 May 2020 15:41:48 -0400 Johannes Weiner wrote: > > > On Wed, May 27, 2020 at 11:29:58AM -0700, Shakeel Butt wrote: > > > From: Johannes Weiner > > > > > > Currently, THP are counted as single pages until they are split right > > > before being swapped out. However, at that point the VM is already in > > > the middle of reclaim, and adjusting the LRU balance then is useless. > > > > > > Always account THP by the number of basepages, and remove the fixup > > > from the splitting path. > > > > > > Signed-off-by: Johannes Weiner > > > Signed-off-by: Shakeel Butt > > > > This is now already in mm as part of the "mm: balance LRU lists based > > on relative thrashing" series that I sent out last week and where it > > was originally from. > > Yup. I hope [1/3] and [2/3] weren't urgent? No urgency.