From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A5A4C433E0 for ; Wed, 23 Dec 2020 21:02:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D2C6224B1 for ; Wed, 23 Dec 2020 21:02:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729234AbgLWVCC (ORCPT ); Wed, 23 Dec 2020 16:02:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728976AbgLWVCB (ORCPT ); Wed, 23 Dec 2020 16:02:01 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB709C06179C for ; Wed, 23 Dec 2020 13:01:20 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id l11so495236lfg.0 for ; Wed, 23 Dec 2020 13:01:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g36tAmTEjSaA0vpBKIUlCpStJerd4pisa8lbF6yxKNQ=; b=kn3BVILCed5+28QuNVyEq3hRiqw3fts33Is0SKnBnm17qBAVZ6oxU+DgC7uMmunsTH 2a8wsM30fyoKI6v9GWohnvTMO5TYWEKkVvE4s/DF3tT8r5sdLksMQxtNkyWi0AcTFDW4 hzsZELBW0HTOt7N1u6bEzGc/JOnkLsHiAVA5rj/vh/uyWPVcX86QX6MXrj/vEh+tO/wr 0sSNB2ZbmhP1LDMvMU6ZvEQDpTyGMYClmNF1sruJq5YfeMV7C8cqn0Px8HjHsQIdLbk8 5GRLH2bKy5K4w+EZF35tH6U5vIO0TqDfdYVDaxNJu/ntR7m/JgE56e2Kf41SGSmLlpc3 h6Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g36tAmTEjSaA0vpBKIUlCpStJerd4pisa8lbF6yxKNQ=; b=iB6Nz7yV66C7Q4LVrK6GD3hrOhhnsRB4GZmTmDmQDAk4gFh/uf/V8SAOK3ICRmN6ZR h91zg4rvTXaaIRjdZj51/3i9RprO65xeSmaCrbk+pL4QL19XpIZ+XNTwtDKiw4UboSvo 9MwZYMAGm0/gwQrsEbcPxpS+4rSjkXzDv6HkMQTyr14DQpJaISDXLhgkAQ9Z+GOoyIIO k0Sm0/NzAEI/ObBYf6dKlhLHRv4YD+ALICODrOuB2QW1m9fENQToGJQ18sOzg1ztf0Nl ftIx97ujZ6bimbpo8ccBPcDhXjtajymcXc9jG4oANWNc4R4z2sC56xtITCmHl/b+ywp1 erFg== X-Gm-Message-State: AOAM530lhOnnYliYJu7ynZp4k4C8euGSMM+ND2KmWHS3Z4rKCBm3es7u be5l8d53mJyg52R0/Uw1GFOj/bNkXsSBaCg3OftryA== X-Google-Smtp-Source: ABdhPJzUj3Wj8zvd/BiNPBjip+KqSkpO464X2X8czRYKgivNp/qw7V05sLyQmik/Lb/Q79cNJkjuGGYHdZ2ec0Abdnk= X-Received: by 2002:a05:6512:687:: with SMTP id t7mr10984209lfe.432.1608757278987; Wed, 23 Dec 2020 13:01:18 -0800 (PST) MIME-Version: 1.0 References: <20201217034356.4708-1-songmuchun@bytedance.com> <20201217034356.4708-2-songmuchun@bytedance.com> In-Reply-To: <20201217034356.4708-2-songmuchun@bytedance.com> From: Shakeel Butt Date: Wed, 23 Dec 2020 13:01:07 -0800 Message-ID: Subject: Re: [PATCH v5 1/7] mm: memcontrol: fix NR_ANON_THPS accounting in charge moving To: Muchun Song Cc: Greg Kroah-Hartman , rafael@kernel.org, Alexey Dobriyan , Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Hugh Dickins , Roman Gushchin , Sami Tolvanen , Feng Tang , Neil Brown , Joonsoo Kim , Randy Dunlap , LKML , linux-fsdevel , Linux MM , Cgroups , Michal Hocko , Pankaj Gupta Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 16, 2020 at 7:45 PM Muchun Song wrote: > > The unit of NR_ANON_THPS is HPAGE_PMD_NR already. So it should inc/dec > by one rather than nr_pages. > > Fixes: 468c398233da ("mm: memcontrol: switch to native NR_ANON_THPS counter") > Signed-off-by: Muchun Song > Acked-by: Michal Hocko > Acked-by: Johannes Weiner > Acked-by: Pankaj Gupta > Reviewed-by: Roman Gushchin Reviewed-by: Shakeel Butt From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shakeel Butt Subject: Re: [PATCH v5 1/7] mm: memcontrol: fix NR_ANON_THPS accounting in charge moving Date: Wed, 23 Dec 2020 13:01:07 -0800 Message-ID: References: <20201217034356.4708-1-songmuchun@bytedance.com> <20201217034356.4708-2-songmuchun@bytedance.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g36tAmTEjSaA0vpBKIUlCpStJerd4pisa8lbF6yxKNQ=; b=kn3BVILCed5+28QuNVyEq3hRiqw3fts33Is0SKnBnm17qBAVZ6oxU+DgC7uMmunsTH 2a8wsM30fyoKI6v9GWohnvTMO5TYWEKkVvE4s/DF3tT8r5sdLksMQxtNkyWi0AcTFDW4 hzsZELBW0HTOt7N1u6bEzGc/JOnkLsHiAVA5rj/vh/uyWPVcX86QX6MXrj/vEh+tO/wr 0sSNB2ZbmhP1LDMvMU6ZvEQDpTyGMYClmNF1sruJq5YfeMV7C8cqn0Px8HjHsQIdLbk8 5GRLH2bKy5K4w+EZF35tH6U5vIO0TqDfdYVDaxNJu/ntR7m/JgE56e2Kf41SGSmLlpc3 h6Aw== In-Reply-To: <20201217034356.4708-2-songmuchun@bytedance.com> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Muchun Song Cc: Greg Kroah-Hartman , rafael@kernel.org, Alexey Dobriyan , Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Hugh Dickins , Roman Gushchin , Sami Tolvanen , Feng Tang , Neil Brown , Joonsoo Kim , Randy Dunlap , LKML , linux-fsdevel , Linux MM , Cgroups , Michal Hocko , Pankaj Gupta On Wed, Dec 16, 2020 at 7:45 PM Muchun Song wrote: > > The unit of NR_ANON_THPS is HPAGE_PMD_NR already. So it should inc/dec > by one rather than nr_pages. > > Fixes: 468c398233da ("mm: memcontrol: switch to native NR_ANON_THPS counter") > Signed-off-by: Muchun Song > Acked-by: Michal Hocko > Acked-by: Johannes Weiner > Acked-by: Pankaj Gupta > Reviewed-by: Roman Gushchin Reviewed-by: Shakeel Butt