From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C677EC432BE for ; Fri, 23 Jul 2021 02:04:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FCAD60EB5 for ; Fri, 23 Jul 2021 02:04:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233149AbhGWBXi (ORCPT ); Thu, 22 Jul 2021 21:23:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233050AbhGWBXe (ORCPT ); Thu, 22 Jul 2021 21:23:34 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FE18C061575 for ; Thu, 22 Jul 2021 19:04:09 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id v6so11487407lfp.6 for ; Thu, 22 Jul 2021 19:04:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uWU9VPUi87pNrXCcR4PCrzd/Kzrus891hORmT5PC+zM=; b=eGNdTCrx6valxUE5ycbThNR4R02XvSCraZrOHIJQ3+uqYxLGjXSsd22UWXr8N8UOPD pTfRBCs/s/EKxTP63S4eW3pg+ooV0Y0g5l6l2r6t0UIosBihxBzwuMctSG+1emfQCfSE px9lck/vGt9WgFrHHUB99tl86i/uxoPbCAIgVSVpr/+N6v6cSOq37fum8aRsrqO7ACZJ nTK2PdPZtydq9eYLRimByBEr+6baMS+91ckZZ/T+wduT5gQD9zre78+/Eu79TJsACHbw ct2HMQmLl83gfQCVoDTYqZOIgZfE8fsaRlcVKLmHNhSi+3LRiz9+fY4hm+TfpU8IS/Kw 5qpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uWU9VPUi87pNrXCcR4PCrzd/Kzrus891hORmT5PC+zM=; b=tFEIGM6xOvbuwVyC5P7Ww2sa4Zp/Ao1QhH7feMEGHVJpb9YrENHtbmEmiugacoacV2 H9kS0wxOxn/tEHrnApnZXhllaQHEGd1f2KQ3+ie0prsz31epD6fpEzM6jweX77JXCa57 jmGLx4d4r4XxRCLwiFYqaDLrCbLcF9z8L3KhA8HZpqYfuQ0jTAGHrT25WCKWux3YMihP xGNLp/QsqXMT6frBZnQd3gFfnG6pENlRPuQWWjKi0KT3sCJbilEtZUcUOJtfF/KFP5Wc g+gSqkEb7zAMNSzA1ryddNm++9YIO7aAHGUa6XmcBS+Bd3pi/SdabNVj44ZdZG8SeyUH OsXA== X-Gm-Message-State: AOAM531INfEif2vybXQJgFQRIZBDVfHXuPRQ9T7ixwRAUbCc4m7ECMXT 23sQARkvhUOKah6tjG0PLKINN7FXeb8UTU3IG22FuA== X-Google-Smtp-Source: ABdhPJyBmT6ZL/CfKLSg3rGD/pmyxU4+PR/Rv/FDU5r/DAMR4iBuE7Qg4ScYmuWcXBXaW8hLAfCfxGHev47wUrR2oFI= X-Received: by 2002:a19:e053:: with SMTP id g19mr1426820lfj.83.1627005847018; Thu, 22 Jul 2021 19:04:07 -0700 (PDT) MIME-Version: 1.0 References: <20210723011436.60960-1-surenb@google.com> In-Reply-To: <20210723011436.60960-1-surenb@google.com> From: Shakeel Butt Date: Thu, 22 Jul 2021 19:03:56 -0700 Message-ID: Subject: Re: [PATCH v3 1/2] mm: introduce process_mrelease system call To: Suren Baghdasaryan Cc: Andrew Morton , Michal Hocko , Michal Hocko , David Rientjes , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Rik van Riel , Minchan Kim , Christian Brauner , Christoph Hellwig , Oleg Nesterov , David Hildenbrand , Jann Horn , Andy Lutomirski , Christian Brauner , Florian Weimer , jengelh@inai.de, Tim Murray , Linux API , Linux MM , LKML , kernel-team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 22, 2021 at 6:14 PM Suren Baghdasaryan wrote: > [...] > + > + mmap_read_lock(mm); How about mmap_read_trylock(mm) and return -EAGAIN on failure? > + if (!__oom_reap_task_mm(mm)) > + ret = -EAGAIN; > + mmap_read_unlock(mm); > + From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E933EC4320A for ; Fri, 23 Jul 2021 02:04:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7954260E9C for ; Fri, 23 Jul 2021 02:04:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7954260E9C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B310A6B005D; Thu, 22 Jul 2021 22:04:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB9A46B006C; Thu, 22 Jul 2021 22:04:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95AD96B0070; Thu, 22 Jul 2021 22:04:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0105.hostedemail.com [216.40.44.105]) by kanga.kvack.org (Postfix) with ESMTP id 777C66B005D for ; Thu, 22 Jul 2021 22:04:11 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9AABD181AF5C4 for ; Fri, 23 Jul 2021 02:04:09 +0000 (UTC) X-FDA: 78392207418.37.B59938B Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf28.hostedemail.com (Postfix) with ESMTP id 4CD959009F14 for ; Fri, 23 Jul 2021 02:04:09 +0000 (UTC) Received: by mail-lf1-f45.google.com with SMTP id s13so11437930lfi.12 for ; Thu, 22 Jul 2021 19:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uWU9VPUi87pNrXCcR4PCrzd/Kzrus891hORmT5PC+zM=; b=eGNdTCrx6valxUE5ycbThNR4R02XvSCraZrOHIJQ3+uqYxLGjXSsd22UWXr8N8UOPD pTfRBCs/s/EKxTP63S4eW3pg+ooV0Y0g5l6l2r6t0UIosBihxBzwuMctSG+1emfQCfSE px9lck/vGt9WgFrHHUB99tl86i/uxoPbCAIgVSVpr/+N6v6cSOq37fum8aRsrqO7ACZJ nTK2PdPZtydq9eYLRimByBEr+6baMS+91ckZZ/T+wduT5gQD9zre78+/Eu79TJsACHbw ct2HMQmLl83gfQCVoDTYqZOIgZfE8fsaRlcVKLmHNhSi+3LRiz9+fY4hm+TfpU8IS/Kw 5qpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uWU9VPUi87pNrXCcR4PCrzd/Kzrus891hORmT5PC+zM=; b=Z6gTLv6366gwL0T/ILuZhwDgDkjAK8RP1guxExBl8NiSpQNi/hwWf5tYtstbYOSdAQ 3EvCj4j6X9NH4rxQCv6O4uTq3y8HIdvHsiIH4aPEoxhlQ/HwwIqaGX7RFixG6uly+apY jT7WgQzlWYHI9+oLvwhpo20HbTdvG6g2e9x5WZIg+Qa51NRESX6da+Zv9HoTpkmyZn9O 3cr0jR+NlDBSCRZ8U28m8zlOkm0s4LUrMFq+Xj5bgR2tYSmRJNCZONDTqy9zUhftRLxH lucZgXoLUWLO1wYuEQfkj76Z6d28j63txgI1sxnhHGhljt+BFwM1kqdEhBAsdsarYRoh 22mw== X-Gm-Message-State: AOAM533JrKLnkLRkvkiSK+upRdklpjr4RHScamcv9SEeZ3pd3TOaCtnM nCE079yyTsq085vLey5FmdSIf0aZDflrfjwoLJTjZw== X-Google-Smtp-Source: ABdhPJyBmT6ZL/CfKLSg3rGD/pmyxU4+PR/Rv/FDU5r/DAMR4iBuE7Qg4ScYmuWcXBXaW8hLAfCfxGHev47wUrR2oFI= X-Received: by 2002:a19:e053:: with SMTP id g19mr1426820lfj.83.1627005847018; Thu, 22 Jul 2021 19:04:07 -0700 (PDT) MIME-Version: 1.0 References: <20210723011436.60960-1-surenb@google.com> In-Reply-To: <20210723011436.60960-1-surenb@google.com> From: Shakeel Butt Date: Thu, 22 Jul 2021 19:03:56 -0700 Message-ID: Subject: Re: [PATCH v3 1/2] mm: introduce process_mrelease system call To: Suren Baghdasaryan Cc: Andrew Morton , Michal Hocko , Michal Hocko , David Rientjes , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Rik van Riel , Minchan Kim , Christian Brauner , Christoph Hellwig , Oleg Nesterov , David Hildenbrand , Jann Horn , Andy Lutomirski , Christian Brauner , Florian Weimer , jengelh@inai.de, Tim Murray , Linux API , Linux MM , LKML , kernel-team Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4CD959009F14 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=eGNdTCrx; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=shakeelb@google.com X-Stat-Signature: 5n16bojedjjgyfsmiiy1muqya5341qt5 X-HE-Tag: 1627005849-293971 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 22, 2021 at 6:14 PM Suren Baghdasaryan wrote: > [...] > + > + mmap_read_lock(mm); How about mmap_read_trylock(mm) and return -EAGAIN on failure? > + if (!__oom_reap_task_mm(mm)) > + ret = -EAGAIN; > + mmap_read_unlock(mm); > +