From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92CA6C433DB for ; Mon, 25 Jan 2021 17:18:22 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3359821E92 for ; Mon, 25 Jan 2021 17:18:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3359821E92 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id CCB04100EBBBA; Mon, 25 Jan 2021 09:18:21 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::134; helo=mail-lf1-x134.google.com; envelope-from=shakeelb@google.com; receiver= Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5ED16100EBBB4 for ; Mon, 25 Jan 2021 09:18:18 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id a8so18896656lfi.8 for ; Mon, 25 Jan 2021 09:18:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NF3PAS9R3ZcPxx4Z5KTeI/YMZHaaDZloSJa4zd+LcN4=; b=dcojzpvBme3j+zUhY3ahCgy1OWbsKkFNmO1SmDOVx9o3VOdmi1r2YX6L0pn3CYTKxE UuzL4cx554sA9UWfceH335k9zgKeNdNZbQkg0ruEwHt2oD7i5VhQHFj8dho+iNbxnOIi kbP6D0HNZYkv/fCic1j5WVLYkd7Cr9blj/atVb/ioXbDyORifrO8kcGBh7MCL0flLrDK D2ZQOL0FlMXMeBJEJSv+/JfLGOP1UGbY+1X/Y5zaitRWa/9P2DldYEEdQW4OPBEOCyLf c+RRNgmCaHeK6qP/DS1Pp+OIpiTReTg8yF4kHgiTCvjQR1HWcMVRmJAgmErZ8wIE4wHP EOAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NF3PAS9R3ZcPxx4Z5KTeI/YMZHaaDZloSJa4zd+LcN4=; b=tczGKQoJghaHRDqFh1SqYZLxDV5JcT130cXwUDKEzsYVvlTazV9xO4JCYcOl28uS6I +E0p/H8ZfXFzxrvFAdBJLepHcm7ph7LxQCmW9/ZfEDme+8k/3AFVCk4TTaNA7UOYUpog opZLRR9eUlEUDZxJ16CAmCSaoAlWTR6JNriKCWfGcvcAO+8hkUMKUCEXa4DCzEnC8ZW+ 7IGGm4poHeH52fhaxmCJTbEHQJEYAhth7XDkH9emTe0Pp1Sd2ku10G5YIwmTIVwp1dSK w9xS40JAoBhbff20Fad/aPYTC1s26ww4XI6syfnj3mIO6pO3pn4DwYM98GenvPxesTZL vqBw== X-Gm-Message-State: AOAM532qrnhDmd/ynBPBXWl9XWZ5UWf/5WY4AXk4nP0fbPwSUfJN6b7S fgMBwKvyQkqJFATwD6OoyYZeJU7T1g6y3507qtxNag== X-Google-Smtp-Source: ABdhPJwZgyZD9DAvRTvevIrwihPTON7uK5jWWLxrkR+Wnn2HSb0H7RhPgRrIgLYR899I6nP8mpJ+rzybzF2sMZbacI0= X-Received: by 2002:a05:6512:79:: with SMTP id i25mr660173lfo.549.1611595095275; Mon, 25 Jan 2021 09:18:15 -0800 (PST) MIME-Version: 1.0 References: <20210121122723.3446-1-rppt@kernel.org> <20210121122723.3446-9-rppt@kernel.org> <20210125161706.GE308988@casper.infradead.org> In-Reply-To: <20210125161706.GE308988@casper.infradead.org> From: Shakeel Butt Date: Mon, 25 Jan 2021 09:18:04 -0800 Message-ID: Subject: Re: [PATCH v16 08/11] secretmem: add memcg accounting To: Matthew Wilcox Message-ID-Hash: AVYL7CAUIOEQPLMGXTQSYPILH2RB2DBG X-Message-ID-Hash: AVYL7CAUIOEQPLMGXTQSYPILH2RB2DBG X-MailFrom: shakeelb@google.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: Mike Rapoport , Andrew Morton , Alexander Viro , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christopher Lameter , Dave Hansen , David Hildenbrand , Elena Reshetova , "H. Peter Anvin" , Ingo Molnar , James Bottomley , "Kirill A. Shutemov" , Mark Rutland , Mike Rapoport , Michael Kerrisk , Palmer Dabbelt , Paul Walmsley , Peter Zijlstra , Rick Edgecombe , Roman Gushchin , Shuah Khan , Thomas Gleixner , Tycho Andersen , Will Deacon , linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel , Linux MM , LKML , linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-riscv@lists.infradead.org, x86@kernel.org, Hagen Paul Pfeifer , Palmer Dabbelt X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Jan 25, 2021 at 8:20 AM Matthew Wilcox wrote: > > On Thu, Jan 21, 2021 at 02:27:20PM +0200, Mike Rapoport wrote: > > From: Mike Rapoport > > > > Account memory consumed by secretmem to memcg. The accounting is updated > > when the memory is actually allocated and freed. > > I think this is wrong. It fails to account subsequent allocators from > the same PMD. If you want to track like this, you need separate pools > per memcg. > Are these secretmem pools shared between different jobs/memcgs? _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEBECC433DB for ; Mon, 25 Jan 2021 17:21:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B79E422B3B for ; Mon, 25 Jan 2021 17:21:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730717AbhAYRUq (ORCPT ); Mon, 25 Jan 2021 12:20:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730651AbhAYRTh (ORCPT ); Mon, 25 Jan 2021 12:19:37 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 131D2C061797 for ; Mon, 25 Jan 2021 09:18:17 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id m22so18903763lfg.5 for ; Mon, 25 Jan 2021 09:18:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NF3PAS9R3ZcPxx4Z5KTeI/YMZHaaDZloSJa4zd+LcN4=; b=dcojzpvBme3j+zUhY3ahCgy1OWbsKkFNmO1SmDOVx9o3VOdmi1r2YX6L0pn3CYTKxE UuzL4cx554sA9UWfceH335k9zgKeNdNZbQkg0ruEwHt2oD7i5VhQHFj8dho+iNbxnOIi kbP6D0HNZYkv/fCic1j5WVLYkd7Cr9blj/atVb/ioXbDyORifrO8kcGBh7MCL0flLrDK D2ZQOL0FlMXMeBJEJSv+/JfLGOP1UGbY+1X/Y5zaitRWa/9P2DldYEEdQW4OPBEOCyLf c+RRNgmCaHeK6qP/DS1Pp+OIpiTReTg8yF4kHgiTCvjQR1HWcMVRmJAgmErZ8wIE4wHP EOAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NF3PAS9R3ZcPxx4Z5KTeI/YMZHaaDZloSJa4zd+LcN4=; b=bIAa9EaSd+jiAx5pTxP0+QBNMRTBZZVdCsZF6m+TKgZONy/NSnJ5HKNgxfzFni7/1b Swe0TaAji1sEPKvVeXL8yY0K8xVzo2zrpo9sH2vdxnIj0Stz86/2T3DZGUaaq27LCx/S cnpXgKJWGXxSwa6r8mji3K3Zgmnjr9wt1hOWaqyOHRmPrc5RU9ZEFCItrAWECpEbPy9L jaYLA+xeE0c2if1S2ZIJoqyD5HgjQuWSuBlW+vhZh73PHIR5wkrXJQ5V7skiRAYfivag Uf44qY1clmYHIyc4uRDbVF3QpTGa9JainRPhhlCEecuMrjnSLRPe+Yp8tMEenMSCxfGX LI6A== X-Gm-Message-State: AOAM531NhXmEpLNlSiJsObbDhFuJ3Y6C360hWTm8s0KpzfUgVUlUDtgJ um06zGhYkwIplVDm/GQoIr9IcPvtoNgFlkS3O8OFWg== X-Google-Smtp-Source: ABdhPJwZgyZD9DAvRTvevIrwihPTON7uK5jWWLxrkR+Wnn2HSb0H7RhPgRrIgLYR899I6nP8mpJ+rzybzF2sMZbacI0= X-Received: by 2002:a05:6512:79:: with SMTP id i25mr660173lfo.549.1611595095275; Mon, 25 Jan 2021 09:18:15 -0800 (PST) MIME-Version: 1.0 References: <20210121122723.3446-1-rppt@kernel.org> <20210121122723.3446-9-rppt@kernel.org> <20210125161706.GE308988@casper.infradead.org> In-Reply-To: <20210125161706.GE308988@casper.infradead.org> From: Shakeel Butt Date: Mon, 25 Jan 2021 09:18:04 -0800 Message-ID: Subject: Re: [PATCH v16 08/11] secretmem: add memcg accounting To: Matthew Wilcox Cc: Mike Rapoport , Andrew Morton , Alexander Viro , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christopher Lameter , Dan Williams , Dave Hansen , David Hildenbrand , Elena Reshetova , "H. Peter Anvin" , Ingo Molnar , James Bottomley , "Kirill A. Shutemov" , Mark Rutland , Mike Rapoport , Michael Kerrisk , Palmer Dabbelt , Paul Walmsley , Peter Zijlstra , Rick Edgecombe , Roman Gushchin , Shuah Khan , Thomas Gleixner , Tycho Andersen , Will Deacon , linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel , Linux MM , LKML , linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-riscv@lists.infradead.org, x86@kernel.org, Hagen Paul Pfeifer , Palmer Dabbelt Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 25, 2021 at 8:20 AM Matthew Wilcox wrote: > > On Thu, Jan 21, 2021 at 02:27:20PM +0200, Mike Rapoport wrote: > > From: Mike Rapoport > > > > Account memory consumed by secretmem to memcg. The accounting is updated > > when the memory is actually allocated and freed. > > I think this is wrong. It fails to account subsequent allocators from > the same PMD. If you want to track like this, you need separate pools > per memcg. > Are these secretmem pools shared between different jobs/memcgs? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 782ABC433E0 for ; Mon, 25 Jan 2021 17:18:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2179B22AAC for ; Mon, 25 Jan 2021 17:18:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2179B22AAC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uTVSIJ8w2qKZ/vO20BFjvVpBnOs2Sxdtpsq0bAWNSjg=; b=qEHMmRuJrYSaHRHJ+D4FEadUT CSsZ4v2otwYZ8gg0Puj9Nn78SvQq84r7s52mzTaIiKzTXtTBJrFGzRN20EU35CkL5CQnxRCHPsz78 hAxFNnqsvxnN9lZ7sk73X5HrjOpNzgcEPtbEpUC4/cu9YPLBE2FOFkQlojvqVCwetz39w11Lja6X1 ru21LAGmH99vJOdLoFpoCQ+KWemR7elXFkNmHThxXw9FimlrhPd+e/wJsIG50JJfW2mTHm2ttSPZx rr6g6K5TB5RxXm6kqXfjjDg6JsvNBMisNlrDF8lzmBY4bkocBZbfc6+UTT3HTNA4hj4HoOZZ8rIBu XoFIQ/PgQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l45VR-0007GV-27; Mon, 25 Jan 2021 17:18:25 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l45VM-0007Dn-5F for linux-riscv@lists.infradead.org; Mon, 25 Jan 2021 17:18:21 +0000 Received: by mail-lf1-x12f.google.com with SMTP id a12so10767208lfb.1 for ; Mon, 25 Jan 2021 09:18:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NF3PAS9R3ZcPxx4Z5KTeI/YMZHaaDZloSJa4zd+LcN4=; b=dcojzpvBme3j+zUhY3ahCgy1OWbsKkFNmO1SmDOVx9o3VOdmi1r2YX6L0pn3CYTKxE UuzL4cx554sA9UWfceH335k9zgKeNdNZbQkg0ruEwHt2oD7i5VhQHFj8dho+iNbxnOIi kbP6D0HNZYkv/fCic1j5WVLYkd7Cr9blj/atVb/ioXbDyORifrO8kcGBh7MCL0flLrDK D2ZQOL0FlMXMeBJEJSv+/JfLGOP1UGbY+1X/Y5zaitRWa/9P2DldYEEdQW4OPBEOCyLf c+RRNgmCaHeK6qP/DS1Pp+OIpiTReTg8yF4kHgiTCvjQR1HWcMVRmJAgmErZ8wIE4wHP EOAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NF3PAS9R3ZcPxx4Z5KTeI/YMZHaaDZloSJa4zd+LcN4=; b=CACNdOzc6LqNMFq6kPnIircggYeObOxxNPuHINANcM77at0McbSGOecAqdVeRIIuJ3 vUyQTojLfycpDksk6ZE3/RHH7TcI8Ub6uKw/eBiuT6oTv/SLR4u3TNQ/vVRkJcBeMzRD vz1OWI65sHcPXAa+jUcsFBVW8AkACtyxBqyhNuWDhopkmjSKh+ZBNRKg3oPNzK60EnSF ja9nxOSB3jUmvjcpsm++JL3OHd0k7Z3xinKithi3rd4hL/9uPZf/AyOcjukBxZ9PMz/K taEsl4CTzJFxfklWHh6FknC3MkjPdy2rgDwLZCvjrKsYZJg9Zrsprwlly3nHRV5tg8a1 SBVQ== X-Gm-Message-State: AOAM5301PRmBsrfz2r5rpVDc5HnjCiGNFgArcCIDExUsRPUZOTIV+efH QgJm61z30EFprdk9k1C1hSdqROycmd61efGH/hFuMg== X-Google-Smtp-Source: ABdhPJwZgyZD9DAvRTvevIrwihPTON7uK5jWWLxrkR+Wnn2HSb0H7RhPgRrIgLYR899I6nP8mpJ+rzybzF2sMZbacI0= X-Received: by 2002:a05:6512:79:: with SMTP id i25mr660173lfo.549.1611595095275; Mon, 25 Jan 2021 09:18:15 -0800 (PST) MIME-Version: 1.0 References: <20210121122723.3446-1-rppt@kernel.org> <20210121122723.3446-9-rppt@kernel.org> <20210125161706.GE308988@casper.infradead.org> In-Reply-To: <20210125161706.GE308988@casper.infradead.org> From: Shakeel Butt Date: Mon, 25 Jan 2021 09:18:04 -0800 Message-ID: Subject: Re: [PATCH v16 08/11] secretmem: add memcg accounting To: Matthew Wilcox X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210125_121820_222149_E2BD299F X-CRM114-Status: GOOD ( 14.92 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Hildenbrand , Peter Zijlstra , Catalin Marinas , Dave Hansen , Linux MM , linux-kselftest@vger.kernel.org, "H. Peter Anvin" , Christopher Lameter , Shuah Khan , Thomas Gleixner , Elena Reshetova , linux-arch@vger.kernel.org, Tycho Andersen , linux-nvdimm@lists.01.org, Will Deacon , x86@kernel.org, linux-riscv@lists.infradead.org, Mike Rapoport , Ingo Molnar , Michael Kerrisk , Palmer Dabbelt , Arnd Bergmann , James Bottomley , Hagen Paul Pfeifer , Borislav Petkov , Alexander Viro , Andy Lutomirski , Paul Walmsley , "Kirill A. Shutemov" , Dan Williams , linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org, LKML , Palmer Dabbelt , linux-fsdevel , Andrew Morton , Rick Edgecombe , Roman Gushchin , Mike Rapoport Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Jan 25, 2021 at 8:20 AM Matthew Wilcox wrote: > > On Thu, Jan 21, 2021 at 02:27:20PM +0200, Mike Rapoport wrote: > > From: Mike Rapoport > > > > Account memory consumed by secretmem to memcg. The accounting is updated > > when the memory is actually allocated and freed. > > I think this is wrong. It fails to account subsequent allocators from > the same PMD. If you want to track like this, you need separate pools > per memcg. > Are these secretmem pools shared between different jobs/memcgs? _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B783C433DB for ; Mon, 25 Jan 2021 17:18:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E81CD2251E for ; Mon, 25 Jan 2021 17:18:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E81CD2251E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EA66F8D001A; Mon, 25 Jan 2021 12:18:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E55648D0001; Mon, 25 Jan 2021 12:18:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D43DB8D001A; Mon, 25 Jan 2021 12:18:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id BBEFD8D0001 for ; Mon, 25 Jan 2021 12:18:18 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 866B51EF1 for ; Mon, 25 Jan 2021 17:18:18 +0000 (UTC) X-FDA: 77744955876.12.foot21_4b0541227587 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 62257180559E9 for ; Mon, 25 Jan 2021 17:18:18 +0000 (UTC) X-HE-Tag: foot21_4b0541227587 X-Filterd-Recvd-Size: 4638 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 Jan 2021 17:18:17 +0000 (UTC) Received: by mail-lf1-f43.google.com with SMTP id h7so18901934lfc.6 for ; Mon, 25 Jan 2021 09:18:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NF3PAS9R3ZcPxx4Z5KTeI/YMZHaaDZloSJa4zd+LcN4=; b=dcojzpvBme3j+zUhY3ahCgy1OWbsKkFNmO1SmDOVx9o3VOdmi1r2YX6L0pn3CYTKxE UuzL4cx554sA9UWfceH335k9zgKeNdNZbQkg0ruEwHt2oD7i5VhQHFj8dho+iNbxnOIi kbP6D0HNZYkv/fCic1j5WVLYkd7Cr9blj/atVb/ioXbDyORifrO8kcGBh7MCL0flLrDK D2ZQOL0FlMXMeBJEJSv+/JfLGOP1UGbY+1X/Y5zaitRWa/9P2DldYEEdQW4OPBEOCyLf c+RRNgmCaHeK6qP/DS1Pp+OIpiTReTg8yF4kHgiTCvjQR1HWcMVRmJAgmErZ8wIE4wHP EOAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NF3PAS9R3ZcPxx4Z5KTeI/YMZHaaDZloSJa4zd+LcN4=; b=iJiK/lJSmw/xTan0ZZFnkVMw/9Irfrpi/BMjHGL87zyLBwww8fFFByW337oCJV5vVH i0mYN2Llp1cuUBqVTwa3y10fXbckOPoA8qEA/D3qX86J7tJdoEOvAdLuc7OXyuHlBpiw pdbE0tMoPMDzandE/cKPfOc2dtT8JgC/jCiKE2ZkUmGzKelciRpDKLqfmmGV0qoZ7W3f jsXUS/p3G23byevwlc1p6WEGBPIhlVrEZW/Ino83zIVZgUXRJWwrG0OopSEiJNfasdSB MvqQdGEm9IroN8u6BvepYfWYI5777ALvJrUSI/8hoOH/9Fi2GdiJqmi9ex93eGhseXxA IVIw== X-Gm-Message-State: AOAM531s/8VzCB9fWtrK/7khArUMnM2q2IRDrl8jm0p+gE2lkHaX7fDK IF4cgejNhlfQRlvXw5CD8JGx6QcgzF0OMDVYdwIS0w== X-Google-Smtp-Source: ABdhPJwZgyZD9DAvRTvevIrwihPTON7uK5jWWLxrkR+Wnn2HSb0H7RhPgRrIgLYR899I6nP8mpJ+rzybzF2sMZbacI0= X-Received: by 2002:a05:6512:79:: with SMTP id i25mr660173lfo.549.1611595095275; Mon, 25 Jan 2021 09:18:15 -0800 (PST) MIME-Version: 1.0 References: <20210121122723.3446-1-rppt@kernel.org> <20210121122723.3446-9-rppt@kernel.org> <20210125161706.GE308988@casper.infradead.org> In-Reply-To: <20210125161706.GE308988@casper.infradead.org> From: Shakeel Butt Date: Mon, 25 Jan 2021 09:18:04 -0800 Message-ID: Subject: Re: [PATCH v16 08/11] secretmem: add memcg accounting To: Matthew Wilcox Cc: Mike Rapoport , Andrew Morton , Alexander Viro , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christopher Lameter , Dan Williams , Dave Hansen , David Hildenbrand , Elena Reshetova , "H. Peter Anvin" , Ingo Molnar , James Bottomley , "Kirill A. Shutemov" , Mark Rutland , Mike Rapoport , Michael Kerrisk , Palmer Dabbelt , Paul Walmsley , Peter Zijlstra , Rick Edgecombe , Roman Gushchin , Shuah Khan , Thomas Gleixner , Tycho Andersen , Will Deacon , linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel , Linux MM , LKML , linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-riscv@lists.infradead.org, x86@kernel.org, Hagen Paul Pfeifer , Palmer Dabbelt Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 25, 2021 at 8:20 AM Matthew Wilcox wrote: > > On Thu, Jan 21, 2021 at 02:27:20PM +0200, Mike Rapoport wrote: > > From: Mike Rapoport > > > > Account memory consumed by secretmem to memcg. The accounting is updated > > when the memory is actually allocated and freed. > > I think this is wrong. It fails to account subsequent allocators from > the same PMD. If you want to track like this, you need separate pools > per memcg. > Are these secretmem pools shared between different jobs/memcgs? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 640A0C433DB for ; Mon, 25 Jan 2021 17:19:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 045BA22B3B for ; Mon, 25 Jan 2021 17:19:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 045BA22B3B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Nqod4w5WEC7XQ2PcsFvpfcpauu8Ap+tZZFr1RFvG2iY=; b=MlCWEQAi1WkCxRJe9hgOQ6OUp OfPxxBlksL6qPDGcdDSb1GE+JlpwHHdsf9I5isJCeDeJ1jLqXNN9y9rDi/VkyHt6SN6CKT6n0P07q CifUSoWKetJ740x+7EaC6f58z/PgDbw4XFNsYRonlCymLmAL7WcDfQjP6xE06Y1Bvy7xVAGL1pVBk OQEcY1liQDbWvU0rbczu0K3lwtVbwD7h7OmM7L2z2ynqkLXxxzu2e+x3yZERsLz6uWo/pjULgwjjB WEF3NfLPABQaeDT6vM76jUZQZOum+gO9mwhYY+oXXU1twZCWrQsXK+NWKNz8u2Dwb430hIKEdF5gp +rKPSoXCg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l45VP-0007GB-IN; Mon, 25 Jan 2021 17:18:23 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l45VM-0007Do-4H for linux-arm-kernel@lists.infradead.org; Mon, 25 Jan 2021 17:18:21 +0000 Received: by mail-lf1-x132.google.com with SMTP id q12so18870617lfo.12 for ; Mon, 25 Jan 2021 09:18:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NF3PAS9R3ZcPxx4Z5KTeI/YMZHaaDZloSJa4zd+LcN4=; b=dcojzpvBme3j+zUhY3ahCgy1OWbsKkFNmO1SmDOVx9o3VOdmi1r2YX6L0pn3CYTKxE UuzL4cx554sA9UWfceH335k9zgKeNdNZbQkg0ruEwHt2oD7i5VhQHFj8dho+iNbxnOIi kbP6D0HNZYkv/fCic1j5WVLYkd7Cr9blj/atVb/ioXbDyORifrO8kcGBh7MCL0flLrDK D2ZQOL0FlMXMeBJEJSv+/JfLGOP1UGbY+1X/Y5zaitRWa/9P2DldYEEdQW4OPBEOCyLf c+RRNgmCaHeK6qP/DS1Pp+OIpiTReTg8yF4kHgiTCvjQR1HWcMVRmJAgmErZ8wIE4wHP EOAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NF3PAS9R3ZcPxx4Z5KTeI/YMZHaaDZloSJa4zd+LcN4=; b=t000Tg1vssw+fYDG1IMrrL7HU6fUt8dAW2vbsUbsnUpCZbDNDZOqZNKCbLX/TisziT 2Utdyz1u2WmYsBkGZG1AN8y1pJQHDLKv/DRX8Ul8DBTl5w+EbNdgM78aUaxfGbsHYv7P Fw7cVA85fwJ1zbACalPdU2bqcfxGPVG5aAXlIH80PDrAUV6f7OAv9746DneTzVOUOWN+ SJgf9bALM5Jf3yzqZpocK/6yQRC28PDwhP61sy3t2Bap3Uvg+ceDlaQI1nn912Je3xvX Hsy9msk9EMHXeXTSu0h8AGUVUT3Sj1YzEO9G/YPgQVeIWbS09TcVuMXEguRU9YaRpX9c YJNA== X-Gm-Message-State: AOAM532/sFZbeD9oLjvs2roQqSLWjyDlfUyfXpoAY4E9Zdgqaoi4TPr9 uZKknIALmNJ08wAqTUVOkLTpXJRtnytremrHzgTJmA== X-Google-Smtp-Source: ABdhPJwZgyZD9DAvRTvevIrwihPTON7uK5jWWLxrkR+Wnn2HSb0H7RhPgRrIgLYR899I6nP8mpJ+rzybzF2sMZbacI0= X-Received: by 2002:a05:6512:79:: with SMTP id i25mr660173lfo.549.1611595095275; Mon, 25 Jan 2021 09:18:15 -0800 (PST) MIME-Version: 1.0 References: <20210121122723.3446-1-rppt@kernel.org> <20210121122723.3446-9-rppt@kernel.org> <20210125161706.GE308988@casper.infradead.org> In-Reply-To: <20210125161706.GE308988@casper.infradead.org> From: Shakeel Butt Date: Mon, 25 Jan 2021 09:18:04 -0800 Message-ID: Subject: Re: [PATCH v16 08/11] secretmem: add memcg accounting To: Matthew Wilcox X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210125_121820_205429_290F377C X-CRM114-Status: GOOD ( 16.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Hildenbrand , Peter Zijlstra , Catalin Marinas , Dave Hansen , Linux MM , linux-kselftest@vger.kernel.org, "H. Peter Anvin" , Christopher Lameter , Shuah Khan , Thomas Gleixner , Elena Reshetova , linux-arch@vger.kernel.org, Tycho Andersen , linux-nvdimm@lists.01.org, Will Deacon , x86@kernel.org, linux-riscv@lists.infradead.org, Mike Rapoport , Ingo Molnar , Michael Kerrisk , Palmer Dabbelt , Arnd Bergmann , James Bottomley , Hagen Paul Pfeifer , Borislav Petkov , Alexander Viro , Andy Lutomirski , Paul Walmsley , "Kirill A. Shutemov" , Dan Williams , linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org, LKML , Palmer Dabbelt , linux-fsdevel , Andrew Morton , Rick Edgecombe , Roman Gushchin , Mike Rapoport Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 25, 2021 at 8:20 AM Matthew Wilcox wrote: > > On Thu, Jan 21, 2021 at 02:27:20PM +0200, Mike Rapoport wrote: > > From: Mike Rapoport > > > > Account memory consumed by secretmem to memcg. The accounting is updated > > when the memory is actually allocated and freed. > > I think this is wrong. It fails to account subsequent allocators from > the same PMD. If you want to track like this, you need separate pools > per memcg. > Are these secretmem pools shared between different jobs/memcgs? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel