All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yunhan Wang <yunhanw@google.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ] build: use abspath for lib/bluetooth
Date: Mon, 18 Sep 2017 21:47:35 -0700	[thread overview]
Message-ID: <CALvjcs-b3M9A6sdy80pakUwRHxBueuxpxvrpZt2SBhz=xDTK6g@mail.gmail.com> (raw)
In-Reply-To: <D2A056DB-B533-4CAC-BCB8-19C39760E05F@holtmann.org>

Hi, Marcel

I just run make distcheck, it is working with this change upon latest maste=
r.

Could you help to apply it?

The below are detailed step.
1. ./configure --prefix=3D/usr --mandir=3D/usr/share/man --sysconfdir=3D/et=
c
--localstatedir=3D/var --enable-experimental
--with-systemdsystemunitdir=3D/lib/systemd/system
--with-systemduserunitdir=3D/usr/lib/systemd --enable-deprecated
--enable-tools --enable-testing --enable-experimental
2. make distcheck

Thanks
Best wishes
Yunhan

On Mon, Aug 28, 2017 at 10:08 PM, Marcel Holtmann <marcel@holtmann.org> wro=
te:
> Hi Yunhan,
>
>> When building from out of tree, and the top build dir was specified as
>> an absolute path, the linked headers in ${builddir}/lib/bluetooth were
>> broken.  This patch fixes it by relying on make's abspath macro as
>> opposed to the path concatenation.
>> ---
>> Makefile.am | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Makefile.am b/Makefile.am
>> index eaed632e8..ad638cbb2 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -499,7 +499,7 @@ $(lib_libbluetooth_la_OBJECTS): $(local_headers)
>>
>> lib/bluetooth/%.h: lib/%.h
>>       $(AM_V_at)$(MKDIR_P) lib/bluetooth
>> -     $(AM_V_GEN)$(LN_S) -f "$(abs_top_builddir)"/$< $@
>> +     $(AM_V_GEN)$(LN_S) -f $(abspath $<) $@
>
> does =E2=80=9Cfakeroot make distcheck=E2=80=9D still works when doing thi=
s change?
>
> Regards
>
> Marcel
>

  reply	other threads:[~2017-09-19  4:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23 22:58 [PATCH BlueZ] build: use abspath for lib/bluetooth Yunhan Wang
2017-08-29  3:24 ` Yunhan Wang
2017-08-29  5:08 ` Marcel Holtmann
2017-09-19  4:47   ` Yunhan Wang [this message]
2017-09-20  5:55     ` Yunhan Wang
2017-09-21 18:11       ` Yunhan Wang
2017-09-25  4:17         ` Yunhan Wang
2017-09-25 12:15           ` Johan Hedberg
2017-09-25 13:22             ` Luiz Augusto von Dentz
2017-09-25 22:39               ` Yunhan Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALvjcs-b3M9A6sdy80pakUwRHxBueuxpxvrpZt2SBhz=xDTK6g@mail.gmail.com' \
    --to=yunhanw@google.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.