From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6776FC46475 for ; Thu, 25 Oct 2018 18:19:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1478F20834 for ; Thu, 25 Oct 2018 18:19:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hSp33GFm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1478F20834 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727659AbeJZCxU (ORCPT ); Thu, 25 Oct 2018 22:53:20 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:41355 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727626AbeJZCxU (ORCPT ); Thu, 25 Oct 2018 22:53:20 -0400 Received: by mail-io1-f67.google.com with SMTP id q4-v6so6085521iob.8 for ; Thu, 25 Oct 2018 11:19:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=w+Sw+Q6UmqFGuz47oLWMf2lBPU7TvzB1NzPVAH/Cj+4=; b=hSp33GFm717Limub2C/vs8jWipoIoSdOwjH0QN6UHIPTUlm2864a0ohAlUASdUCT/X HkvpJYILUyS2QbvusjWBKa3xhE6WHci9Y7wgiy0HYI6UBq366bXi3QqKpMAPuTg2a5Pc BkBjlp0b+3EQX8xmON50mHqgKZZGpzlcrtAf2GlpMqYtjmjt7cANhO8lJm7x5jyMzZon 2pj3YQF6AtO1yCeiqTrOvGBMyo7/vQg46BByk97fo46tKNWirKS0cmHbBFe5Mfjwomzz ql6fkOWhiWT9fxdnJgd/VuQfLJF6J8jfhzlAQIAW1HyUs7GXfjJnqOl2u1yL6OY0c6Ve b+bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=w+Sw+Q6UmqFGuz47oLWMf2lBPU7TvzB1NzPVAH/Cj+4=; b=XZShW8qPTpJuSbWipyAjdrYfa70mPvMKUr34g7np02bI4RADRfxhhRAGK7Am4gG3kn cjgPnq8Ln8Zw3Zg9vG1t2xw7YSUiR1SS2NkTVAaYGV/VzTfn3xGCg5kSN0eLi43V57Ga rva7CpMXLLgvrXSQbUF1cr3MBNQ55S3l0B6h+/9wt0F21jti12bUlr1E6Nz7ngU9hodc H4CWB0BmkPcq7c0YZxipB95NywbSar9CldvL2NNkiBsWGZ6Kcu5e+ssegzUJqTIdw5Hk 1YdYgcbteCZZlkIPfLuZEVxIBXzuaempGirkHtKCA15UyKgRxjiDToRunZsuJA4yHc7R g8jw== X-Gm-Message-State: AGRZ1gIv3JIRqCc/9iuVBHykZj+pLb5bEWaZvDQrCw9XttwNPb/PnUOp AO3dV6Jw2/jLCWpAnrA81qeMjfG9750QNWGhYf1q/A== X-Google-Smtp-Source: AJdET5cInP90ChFuX5M2XJ1HbZHb1AbHkJ7ohhR+hsr8ITiT634lOmp74YHkYQ0+ZvRWJNBHdVxoHcyAPyKx+IBrA/M= X-Received: by 2002:a6b:8b12:: with SMTP id n18-v6mr223668iod.102.1540491567831; Thu, 25 Oct 2018 11:19:27 -0700 (PDT) MIME-Version: 1.0 References: <20181025004210.177441-1-yunhanw@google.com> In-Reply-To: From: Yunhan Wang Date: Thu, 25 Oct 2018 11:19:15 -0700 Message-ID: Subject: Re: [PATCH] gatt: Fix double att_disconnected issue on disconnection To: Luiz Augusto von Dentz Cc: linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi, Luiz Actually before I submit my patch, I tried your way to unregister the handler, it is failing. That is why I use random address check in btd_gatt_database_att_disconnected to workaround this issue. Thanks Best wishes Yunhan On Thu, Oct 25, 2018 at 10:49 AM Yunhan Wang wrote: > > Hi, Luiz > > Just have a test with your patch in master branch, both crashes are > still there, and att_disconnected has been called for two times even > though unregistering the handler.... > > Thanks > Best wishes > Yunhan > > Program received signal SIGSEGV, Segmentation fault. > btd_adapter_find_device (adapter=3D0x72657664612f6372, > dst=3Ddst@entry=3D0x555555872998, bdaddr_type=3D0 '\000') > at bluez/repo/src/adapter.c:845 > 845 list =3D g_slist_find_custom(adapter->devices, &addr, > (gdb) bt > #0 btd_adapter_find_device (adapter=3D0x72657664612f6372, > dst=3Ddst@entry=3D0x555555872998, bdaddr_type=3D0 '\000') > at bluez/repo/src/adapter.c:845 > #1 0x00005555555ab890 in att_disconnected (err=3D, > user_data=3D0x555555872990) > at bluez/repo/src/gatt-database.c:329 > #2 0x00005555555eaba8 in queue_foreach (queue=3D0x55555585de60, > function=3Dfunction@entry=3D0x5555555ee5f0 , > user_data=3D0x68) > at bluez/repo/src/shared/queue.c:220 > #3 0x00005555555ef819 in disconnect_cb (io=3D, > user_data=3D0x555555869d50) > at bluez/repo/src/shared/att.c:592 > #4 0x00005555555f89a3 in watch_callback (channel=3D, > cond=3D, user_data=3D) > at bluez/repo/src/shared/io-glib.c:170 > #5 0x00007ffff7b0fe35 in g_main_context_dispatch () from > /lib/x86_64-linux-gnu/libglib-2.0.so.0 > #6 0x00007ffff7b10200 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so= .0 > #7 0x00007ffff7b10512 in g_main_loop_run () from > /lib/x86_64-linux-gnu/libglib-2.0.so.0 > #8 0x0000555555572238 in main (argc=3D, argv=3D out>) at bluez/repo/src/main.c:808 > > > Program received signal SIGSEGV, Segmentation fault. > queue_remove (queue=3D0x30, data=3Ddata@entry=3D0x555555873740) at > bluez/repo/src/shared/queue.c:256 > 256 for (entry =3D queue->head, prev =3D NULL; entry; > (gdb) bt > #0 queue_remove (queue=3D0x30, data=3Ddata@entry=3D0x555555873740) at > bluez/repo/src/shared/queue.c:256 > #1 0x00005555555ab8c5 in att_disconnected (err=3D, > user_data=3D0x555555873740) > at bluez/repo/src/gatt-database.c:350 > #2 0x00005555555eabb8 in queue_foreach (queue=3D0x55555586e670, > function=3Dfunction@entry=3D0x5555555ee600 , > user_data=3D0x68) > at bluez/repo/src/shared/queue.c:220 > #3 0x00005555555ef829 in disconnect_cb (io=3D, > user_data=3D0x555555865f50) > at bluez/repo/src/shared/att.c:592 > #4 0x00005555555f89b3 in watch_callback (channel=3D, > cond=3D, user_data=3D) > at bluez/repo/src/shared/io-glib.c:170 > #5 0x00007ffff7b0fe35 in g_main_context_dispatch () from > /lib/x86_64-linux-gnu/libglib-2.0.so.0 > #6 0x00007ffff7b10200 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so= .0 > #7 0x00007ffff7b10512 in g_main_loop_run () from > /lib/x86_64-linux-gnu/libglib-2.0.so.0 > #8 0x0000555555572238 in main (argc=3D, argv=3D out>) at bluez/repo/src/main.c:808 > On Thu, Oct 25, 2018 at 2:20 AM Luiz Augusto von Dentz > wrote: > > > > Hi Yunhan, > > > > On Thu, Oct 25, 2018 at 4:47 AM Yunhan Wang wrote: > > > > > > Hi, Luiz > > > > > > I am observing the multiple crashes when doing BLE disconnection usin= g > > > latest bluez master..It looks like the two att_disconnect are > > > triggered from your last gatt commit.. Please help take a look at thi= s > > > workaround and comments.. the better solution might be to figure out > > > how to handle the disconnection along with random address and public > > > address together regarding the previous issue, Gatt: Subscriptions ar= e > > > not cleared after disconnection from a temporary device > > > > Ive pushed a similar fix, it should remove the handler before calling > > att_disconnected. > > > > > Thanks > > > Best wishes > > > Yunhan > > > On Wed, Oct 24, 2018 at 5:42 PM yunhanw wrote: > > > > > > > > When BLE disconnection happens, att_disconnect is triggered from tw= o locations, the new added location is gatt_server_cleanup, it would cause = several blueetoothd crashes. This bus is introduced from commit 634f0a6e112= 5af8d5959bff119d9336a8d81c028, where gatt fix, gatt subscriptions are not c= leared after disconnection from a temporary device with private/random addr= ess. In order to workaround this issue, btd_gatt_database_att_disconnected = can only be triggered when address type is random, and for others, it can c= ontinue to use original disconnect code path. > > > > > > > > crash 1 > > > > Program received signal SIGSEGV, Segmentation fault. > > > > queue_remove (queue=3D0x30, data=3Ddata@entry=3D0x555555872a40)= at /repo/src/shared/queue.c:256 > > > > 256 for (entry =3D queue->head, prev =3D NULL; entry; > > > > (gdb) backtrace > > > > at /bluez/repo/src/gatt-database.c:350 > > > > at bluez/repo/src/shared/queue.c:220 > > > > at bluez/repo/src/shared/att.c:592 > > > > at bluez/repo/src/shared/io-glib.c:170 > > > > > > > > crash 2 > > > > at bluez/repo/src/shared/queue.c:220 > > > > at bluez/repo/src/shared/att.c:592 > > > > at bluez/repo/src/shared/io-glib.c:170 > > > > > > > > (gdb) print state->db->adapter > > > > Cannot access memory at address 0x61672f6269727474 > > > > --- > > > > src/gatt-database.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/src/gatt-database.c b/src/gatt-database.c > > > > index 783b692d5..2f0eb83b5 100644 > > > > --- a/src/gatt-database.c > > > > +++ b/src/gatt-database.c > > > > @@ -3365,6 +3365,8 @@ void btd_gatt_database_att_disconnected(struc= t btd_gatt_database *database, > > > > > > > > addr =3D device_get_address(device); > > > > type =3D btd_device_get_bdaddr_type(device); > > > > + if (type !=3D BDADDR_LE_RANDOM) > > > > + return; > > > > > > > > state =3D find_device_state(database, addr, type); > > > > if (!state) > > > > -- > > > > 2.19.1.568.g152ad8e336-goog > > > > > > > > > > > > -- > > Luiz Augusto von Dentz