From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3CA9C433F5 for ; Tue, 24 May 2022 20:22:06 +0000 (UTC) Received: from localhost ([::1]:39254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ntb2b-0003uQ-Sb for qemu-devel@archiver.kernel.org; Tue, 24 May 2022 16:22:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58582) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntaqP-0006MC-IO for qemu-devel@nongnu.org; Tue, 24 May 2022 16:09:29 -0400 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]:36778) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ntaqJ-0002AN-BK for qemu-devel@nongnu.org; Tue, 24 May 2022 16:09:25 -0400 Received: by mail-ej1-x633.google.com with SMTP id gi33so29053107ejc.3 for ; Tue, 24 May 2022 13:09:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RoRm32DAUBvzTDWuU91wm+vveag3rgZu0Hmn9RQ3js0=; b=KrYNoNkU3z+iO06k3oe/NycUf/AjgM+TOGSly6R9+IKnLbojyBtyXbBCcatLnZtjGI YxB7wwTDfbNTCaAbqJ4gGPrKSNnKxGwrj8blnLmDUTIHbnbQsMg7VaP9xpbfaEzmmgvq sytFPBNYY73MfSMFCYMZU6rPrFpZWBPMpx4HvB1dMyKpxvJCB+Wd7ydjYpN+oWUasQFm 3V/MUU8u4BEZsvoJf7JNiJMFWPLI82r9OUayUB53lUf8rV8zn0xyQsCv9Os9mnfvsjWn tmzuvY9dEXC8c8TZwk7rjha1u83kjlZtx5W/TV5M/HoN5JULK+4vRzzGWAdG1DdybZeU K3wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RoRm32DAUBvzTDWuU91wm+vveag3rgZu0Hmn9RQ3js0=; b=gJh8EOHXKqFYYJqW2rAdB0MGaKclDej7zjBWbl77JlMuwlpWBMi8LIuvy8L1tWjiYc WtW4QL/LxwNfzuPVko0DQ1aLsV6EA+la1x7diSsH1mwgeTw2CEOSNuzCijNOar5v3BWw aOulfrxCuh7JrtpXcYCnAlsN3i8IeHuvRZJLKgqv4IXfn9m0cTKzGSyi3T9lcbr12brj Wj+6ysqvH6uUXeT+JO4ZGieKqYddFpd83daWOdWaXOsjUhoRxWHFE6qJ6UGw6RenrrKI m/ErOpR0qC4d+ZfeQVsT6Zc00R0BM1/82jjiCrocFlUROd6yo5hNNTpkp3HhEXq2Jr0b EcOw== X-Gm-Message-State: AOAM533AjYWmXDkZlEChdJkDTl374a+VkebMnAvtS8BklSr9hD/kGgpj y4ye8G8cmHEFD0NOZgjEgSHqXhgakZrlSdAhnnC+lA== X-Google-Smtp-Source: ABdhPJwyGGF52SWGoU12KF0arYo5hSp4XOFTNbesj7B/thPOtQIsTPtvkDWodnR1Ch1zTEZpsBBL0+5X65XtDV/t7oU= X-Received: by 2002:a17:907:9602:b0:6df:e82c:f84 with SMTP id gb2-20020a170907960200b006dfe82c0f84mr25714164ejc.590.1653422962035; Tue, 24 May 2022 13:09:22 -0700 (PDT) MIME-Version: 1.0 References: <20220223090706.4888-1-damien.hedde@greensocs.com> <20220223090706.4888-10-damien.hedde@greensocs.com> In-Reply-To: From: Jim Shu Date: Wed, 25 May 2022 04:09:09 +0800 Message-ID: Subject: Re: [PATCH v4 09/14] none-machine: allow cold plugging sysbus devices To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: Damien Hedde , "qemu-devel@nongnu.org Developers" , mark.burton@greensocs.com, edgari@xilinx.com, Eduardo Habkost , Yanan Wang , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: multipart/alternative; boundary="00000000000050e89f05dfc7888e" Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=jim.shu@sifive.com; helo=mail-ej1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000050e89f05dfc7888e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Tested-by: Jim Shu On Thu, Mar 3, 2022 at 10:46 PM Philippe Mathieu-Daud=C3=A9 < philippe.mathieu.daude@gmail.com> wrote: > On 23/2/22 10:07, Damien Hedde wrote: > > Allow plugging any sysbus device on this machine (the sysbus > > devices still need to be 'user-creatable'). > > > > This commit is needed to use the 'none' machine as a base, and > > subsequently to dynamically populate it with sysbus devices using > > qapi commands. > > > > Note that this only concern cold-plug: sysbus devices cann't be hot > > "can not" is easier to understand for non-native / not good level of > English speakers IMHO. > > > plugged because the sysbus bus does not support it. > > > > Signed-off-by: Damien Hedde > > --- > > hw/core/null-machine.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > > --00000000000050e89f05dfc7888e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Tested-by: Jim Shu <jim.shu@sifive.com>

On Thu, Mar 3, 2022 at 1= 0:46 PM Philippe Mathieu-Daud=C3=A9 <philippe.mathieu.daude@gmail.com>= wrote:
On 23/2/= 22 10:07, Damien Hedde wrote:
> Allow plugging any sysbus device on this machine (the sysbus
> devices still need to be 'user-creatable').
>
> This commit is needed to use the 'none' machine as a base, and=
> subsequently to dynamically populate it with sysbus devices using
> qapi commands.
>
> Note that this only concern cold-plug: sysbus devices cann't be ho= t

"can not" is easier to understand for non-native / not good level= of
English speakers IMHO.

> plugged because the sysbus bus does not support it.
>
> Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>
> ---
>=C2=A0 =C2=A0hw/core/null-machine.c | 4 ++++
>=C2=A0 =C2=A01 file changed, 4 insertions(+)

Reviewed-by: Philippe Mathieu-Daud=C3=A9 <f4bug@amsat.org>

--00000000000050e89f05dfc7888e--