From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [PATCH v4 3/4] eal: call pci_ioport_map when kernel driver isn't managing the device Date: Mon, 29 Feb 2016 10:02:37 +0100 Message-ID: References: <20151222035041.GA7532@pxdev.xzpeter.org> <1456451636-118476-1-git-send-email-huawei.xie@intel.com> <1456451636-118476-4-git-send-email-huawei.xie@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" , "Troitsky, Nikita" To: Huawei Xie Return-path: Received: from mail-oi0-f46.google.com (mail-oi0-f46.google.com [209.85.218.46]) by dpdk.org (Postfix) with ESMTP id 944166C96 for ; Mon, 29 Feb 2016 10:02:57 +0100 (CET) Received: by mail-oi0-f46.google.com with SMTP id k67so43494345oia.3 for ; Mon, 29 Feb 2016 01:02:57 -0800 (PST) In-Reply-To: <1456451636-118476-4-git-send-email-huawei.xie@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Feb 26, 2016 at 2:53 AM, Huawei Xie wrote: > Call rte_eal_pci_ioport_map only if driver type is RTE_KDRV_NONE, which > means kernel driver(including UIO/VFIO) isn't managing the device. I suppose you meant 'Call pci_ioport_map when the pci device is not bound to a kernel driver'. If you keep on with your choice of words, at least put a space before the (. > other minor changes: > * use RTE_ARCH_X86 for pci ioport map This is a trivial change, but this should not be here. > * rework rte_eal_pci_ioport_map a bit Well, not sure this comment helps the review, and anyway, why did you need to change this ? Your modification should be the smallest possible. > Signed-off-by: Huawei Xie Let aside these nits. Acked-by: David Marchand -- David Marchand