From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [PATCH 03/11] i40e: move pci device ids to driver Date: Tue, 12 Jan 2016 09:45:28 +0100 Message-ID: References: <1452430254-30390-1-git-send-email-david.marchand@6wind.com> <1452430254-30390-4-git-send-email-david.marchand@6wind.com> <20160110120208.702d22c5@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" , thomas.monjalon@dpdk.org To: Stephen Hemminger Return-path: Received: from mail-oi0-f50.google.com (mail-oi0-f50.google.com [209.85.218.50]) by dpdk.org (Postfix) with ESMTP id ADFDB3195 for ; Tue, 12 Jan 2016 09:45:29 +0100 (CET) Received: by mail-oi0-f50.google.com with SMTP id p187so50664538oia.2 for ; Tue, 12 Jan 2016 00:45:29 -0800 (PST) In-Reply-To: <20160110120208.702d22c5@xeon-e3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Jan 10, 2016 at 9:02 PM, Stephen Hemminger < stephen@networkplumber.org> wrote: > On Sun, 10 Jan 2016 13:50:46 +0100 > David Marchand wrote: > > > +{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_SFP_XL710) }, > > +{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_QEMU) }, > > +{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_KX_A) }, > > +{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_KX_B) } > > You should indent the initializers. > Ok will do, but I don't like having to break lines because of the 80-columns limit (which happens in some drivers). -- David Marchand