From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [PATCH v6 1/8] eal: pci: add api to rd/wr pci bar region Date: Fri, 5 Feb 2016 18:56:54 +0100 Message-ID: References: <1454091717-32251-1-git-send-email-sshukla@mvista.com> <20160201134854.GE4257@yliu-dev.sh.intel.com> <20160202054345.GI4257@yliu-dev.sh.intel.com> <20160202084933.GJ4257@yliu-dev.sh.intel.com> <20160203115022.GB16802@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" To: Yuanhan Liu , Santosh Shukla Return-path: Received: from mail-oi0-f50.google.com (mail-oi0-f50.google.com [209.85.218.50]) by dpdk.org (Postfix) with ESMTP id 32612C34E for ; Fri, 5 Feb 2016 18:57:15 +0100 (CET) Received: by mail-oi0-f50.google.com with SMTP id w5so45685935oie.1 for ; Fri, 05 Feb 2016 09:57:15 -0800 (PST) In-Reply-To: <20160203115022.GB16802@yliu-dev.sh.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Feb 3, 2016 at 12:50 PM, Yuanhan Liu wrote: > On Wed, Feb 03, 2016 at 03:20:09PM +0530, Santosh Shukla wrote: >> Also can someone please review rest of series. This patchset going >> through multiple revision, Each revision get one / two comment, It >> would help if I get review comment for each patch. > > The others looks good to me; if you have the EAL pci API resolved > properly, I guess I could give my ACK. As discussed offlist, I just sent a patchset [1] that proposes a new api. This is not perfect, but I think this should be fine for x86 / arm. Santosh should be able to rebase his code on top of it. [1] http://dpdk.org/ml/archives/dev/2016-February/032778.html Regards, -- David Marchand