From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [PATCH v4 2/4] eal: set kdrv to RTE_KDRV_NONE if kernel driver isn't managing the device Date: Mon, 29 Feb 2016 10:05:49 +0100 Message-ID: References: <20151222035041.GA7532@pxdev.xzpeter.org> <1456451636-118476-1-git-send-email-huawei.xie@intel.com> <1456451636-118476-3-git-send-email-huawei.xie@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" , "Troitsky, Nikita" To: "Xie, Huawei" Return-path: Received: from mail-ob0-f178.google.com (mail-ob0-f178.google.com [209.85.214.178]) by dpdk.org (Postfix) with ESMTP id E924A6C97 for ; Mon, 29 Feb 2016 10:06:08 +0100 (CET) Received: by mail-ob0-f178.google.com with SMTP id s6so78340755obg.3 for ; Mon, 29 Feb 2016 01:06:08 -0800 (PST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Feb 29, 2016 at 10:00 AM, Xie, Huawei wrote: > On 2/29/2016 4:47 PM, David Marchand wrote: >> On Fri, Feb 26, 2016 at 2:53 AM, Huawei Xie wrote: >>> v4 changes: >>> reword the commit message. When we mention kernel driver, emphasizes >>> that it includes UIO/VFIO. >> Annotations should not be part of the commitlog itself. > > Do you mean that "rewording the commit message" should not appear in the > commit message itself? Those version changes will not appear in the > commit log when applied, right? So i added this so that reviewers know Try to apply it. http://dpdk.org/dev : "Annotations take place after the 3 dashes and should explicit what has changed since the previous version.". -- David Marchand