From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Marchand <david.marchand@6wind.com>
Subject: Re: [dpdk-dev,
	2/2] ethdev: move code to common place in hotplug
Date: Fri, 22 Jan 2016 08:15:05 +0100
Message-ID: <CALwxeUunmqn9hiP_fiMSjekb6rh0wrAozYcEcBQiivmp+h8_XA@mail.gmail.com>
References: <1453377431-25850-3-git-send-email-david.marchand@6wind.com>
 <20160121163836.0bcd405e@pcviktorin.fit.vutbr.cz>
 <CALwxeUsR0ZZFg7UopYyshV-xnwRJiV82h2qC6xmC=ONfz6S9xA@mail.gmail.com>
 <1701908.3Qo6PKQGCI@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: "dev@dpdk.org" <dev@dpdk.org>, Jan Viktorin <viktorin@rehivetech.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-oi0-f46.google.com (mail-oi0-f46.google.com
 [209.85.218.46]) by dpdk.org (Postfix) with ESMTP id 2A83E8E79
 for <dev@dpdk.org>; Fri, 22 Jan 2016 08:15:26 +0100 (CET)
Received: by mail-oi0-f46.google.com with SMTP id w75so42027508oie.0
 for <dev@dpdk.org>; Thu, 21 Jan 2016 23:15:26 -0800 (PST)
In-Reply-To: <1701908.3Qo6PKQGCI@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello,

On Thu, Jan 21, 2016 at 7:42 PM, Thomas Monjalon
<thomas.monjalon@6wind.com> wrote:
> 2016-01-21 19:06, David Marchand:
>> On Thu, Jan 21, 2016 at 4:38 PM, Jan Viktorin <viktorin@rehivetech.com> wrote:
>> > This change modifies the return value from -EINVAL to -1. I don't know
>> > whether is this an issue but it looks suspicious.
>>
>> Should not be an issue, as the api does not give details on expected
>> negative return values.
>> Just noticed, this also introduces a new log message that was not
>> displayed before.
>>
>> To be safe, I suppose I should restore this.
>>
>> Thomas, opinion ?
>
> I'm OK with the log message added for this error case.
> I would just keep the -EINVAL return value.

Ok will do.


-- 
David Marchand