From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [PATCH 1/2] scripts: add checkpatch wrapper Date: Thu, 29 Oct 2015 13:33:59 +0100 Message-ID: References: <1445615606-3885-1-git-send-email-thomas.monjalon@6wind.com> <1445615606-3885-2-git-send-email-thomas.monjalon@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" To: Thomas Monjalon Return-path: Received: from mail-oi0-f51.google.com (mail-oi0-f51.google.com [209.85.218.51]) by dpdk.org (Postfix) with ESMTP id B88D32A5F for ; Thu, 29 Oct 2015 13:34:00 +0100 (CET) Received: by oiao187 with SMTP id o187so30230864oia.3 for ; Thu, 29 Oct 2015 05:34:00 -0700 (PDT) In-Reply-To: <1445615606-3885-2-git-send-email-thomas.monjalon@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 23, 2015 at 5:53 PM, Thomas Monjalon wrote: > +for p in "$@" ; do > + printf -- "\n### $p\n\n" > + report=$($DPDK_CHECKPATCH_PATH $options "$p" 2>/dev/null) > + [ $? -ne 0 ] || continue > + printf '%s\n' "$report" | head -n -6 > + status=$(($status + 1)) > +done > +exit $status > I prefer when checking scripts only complain when something is wrong :-) So I would only display the file name if checkpatch complains. -- David Marchand