From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Herbert Subject: Re: [PATCH 0/4] Prevent UDP tunnels from operating on garbage socket Date: Mon, 6 Apr 2015 06:59:21 -0700 Message-ID: References: <20150405.221847.2119086885797169021.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, pablo@netfilter.org, hannes@stressinduktion.org, jiri@resnulli.us To: David Miller Return-path: Received: from mail-ie0-f181.google.com ([209.85.223.181]:33117 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752853AbbDFN7V (ORCPT ); Mon, 6 Apr 2015 09:59:21 -0400 Received: by iebmp1 with SMTP id mp1so21418392ieb.0 for ; Mon, 06 Apr 2015 06:59:21 -0700 (PDT) In-Reply-To: <20150405.221847.2119086885797169021.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, Apr 5, 2015 at 7:18 PM, David Miller wrote: > > So this should do the rest of the work such that when we encapsulate > into a UDP tunnel, the output path works on the UDP tunnel's socket > rather than skb->sk. > Doesn't this contradict "udp: Do not require sock in udp_tunnel_xmit_skb" patch? How is the skbuf getting set with a garbage socket? Thanks, Tom login register mail settings > Part of this work is based upon changes done by Jiri Pirko some time > ago. > > Basically the first step is to pass the socket through the nf_hook > okfn(), and then next we do the same for the UDP tunnel xmit routines. > > Signed-off-by: David S. Miller > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html