All of lore.kernel.org
 help / color / mirror / Atom feed

diff for duplicates of <CALx6S34DdGZo7e1e37UCtpZ48jgdvHJ5nR=keyGFq3O3-b2_YQ@mail.gmail.com>

diff --git a/a/1.txt b/N1/1.txt
index f136b3e..cee7402 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -80,7 +80,7 @@ dissector could support.
 > +static inline void skb_set_crc32c_ipsummed(struct sk_buff *skb,
 > +                                          const u8 ip_summed)
 > +{
-> +       skb->csum_algo = ip_summed == CHECKSUM_PARTIAL ? CRC32C_CHECKSUM :
+> +       skb->csum_algo = ip_summed = CHECKSUM_PARTIAL ? CRC32C_CHECKSUM :
 > +               INTERNET_CHECKSUM;
 > +       skb->ip_summed = ip_summed;
 
@@ -118,7 +118,7 @@ having the same value.
 
 The old code is better. CHECKSUM_UNNECESSARY already applies to non IP
 checksums. There is nothing special about crc32 in this regard and
-skb->csum_algo should only be valid when skb->ip_summed ==
+skb->csum_algo should only be valid when skb->ip_summed =
 CHECKSUM_PARTIAL so no need to set it here. This point should also be
 in documentation.
 
@@ -169,8 +169,7 @@ in documentation.
 > --- a/net/sctp/output.c
 > +++ b/net/sctp/output.c
 > @@ -524,10 +524,11 @@ static int sctp_packet_pack(struct sctp_packet *packet,
->                 struct sctphdr *sh =
->                         (struct sctphdr *)skb_transport_header(head);
+>                 struct sctphdr *sh >                         (struct sctphdr *)skb_transport_header(head);
 >
 > +               skb_set_crc32c_ipsummed(head, CHECKSUM_NONE);
 >                 sh->checksum = sctp_compute_cksum(head, 0);
diff --git a/a/content_digest b/N1/content_digest
index 05bd88b..1295935 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -14,7 +14,7 @@
   "Subject\0Re: [PATCH RFC net-next v3 4/7] net: use skb->csum_algo to identify packets needing crc32c\0"
 ]
 [
-  "Date\0Fri, 7 Apr 2017 08:43:51 -0700\0"
+  "Date\0Fri, 07 Apr 2017 15:43:51 +0000\0"
 ]
 [
   "To\0Davide Caratti <dcaratti\@redhat.com>\0"
@@ -116,7 +116,7 @@
   "> +static inline void skb_set_crc32c_ipsummed(struct sk_buff *skb,\n",
   "> +                                          const u8 ip_summed)\n",
   "> +{\n",
-  "> +       skb->csum_algo = ip_summed == CHECKSUM_PARTIAL ? CRC32C_CHECKSUM :\n",
+  "> +       skb->csum_algo = ip_summed = CHECKSUM_PARTIAL ? CRC32C_CHECKSUM :\n",
   "> +               INTERNET_CHECKSUM;\n",
   "> +       skb->ip_summed = ip_summed;\n",
   "\n",
@@ -154,7 +154,7 @@
   "\n",
   "The old code is better. CHECKSUM_UNNECESSARY already applies to non IP\n",
   "checksums. There is nothing special about crc32 in this regard and\n",
-  "skb->csum_algo should only be valid when skb->ip_summed ==\n",
+  "skb->csum_algo should only be valid when skb->ip_summed =\n",
   "CHECKSUM_PARTIAL so no need to set it here. This point should also be\n",
   "in documentation.\n",
   "\n",
@@ -205,8 +205,7 @@
   "> --- a/net/sctp/output.c\n",
   "> +++ b/net/sctp/output.c\n",
   "> \@\@ -524,10 +524,11 \@\@ static int sctp_packet_pack(struct sctp_packet *packet,\n",
-  ">                 struct sctphdr *sh =\n",
-  ">                         (struct sctphdr *)skb_transport_header(head);\n",
+  ">                 struct sctphdr *sh >                         (struct sctphdr *)skb_transport_header(head);\n",
   ">\n",
   "> +               skb_set_crc32c_ipsummed(head, CHECKSUM_NONE);\n",
   ">                 sh->checksum = sctp_compute_cksum(head, 0);\n",
@@ -222,4 +221,4 @@
   ">"
 ]
 
-6ecad2cbf6bef9c29073c64ecabaa85c9f5e855268e7b8b68a37fd9ab93a9c43
+76481eee4df390ccad8a522dbb54fe0eafd9810ee6a8842f0fb4456c689400f7
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.