All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Herbert <tom@herbertland.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>,
	Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH net-next] flow_dissector: remove __flow_hash_consistentify
Date: Wed, 29 Jul 2015 15:26:31 -0700	[thread overview]
Message-ID: <CALx6S35dQ5AUWi4jf88+m3FgDiy7nHO6UvRfPOGrsmmfkMeFLQ@mail.gmail.com> (raw)
In-Reply-To: <1438208128.20182.113.camel@edumazet-glaptop2.roam.corp.google.com>

On Wed, Jul 29, 2015 at 3:15 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Wed, 2015-07-29 at 14:47 -0700, Tom Herbert wrote:
>
>> Hi Eric,
>>
>> So the scenario you're thinking is conntrack in the forwarding path,
>> RPS enabled (RSS not relevant), no hash from device, no IPv6 flow
>> labels or any other asymmetric inputs into the flow hash? I can look
>> at that, but it does make me wonder if maybe conntrack should set RFS
>> for both sides to avoid any issue with asymmetric hashes. With more
>> IPv6 and flow labels (which we will enable by default), asymmetric
>> hashes will likely become the norm.
>
> Yes, but as long as the hash was done in software in our stack we could
> use flow dissection and this swap() thing, regardless of the hashes
> computed by the NIC or derived from IPv6 flow label.
>
The IPv6 flow label is now taken as input to the software hash (along
with VLAN id, GRE keyid, MPLS label, etc.). Packets encapsulated in
UDP also cause asymmetric hashes since the source port is used for
entropy. We have no way to predict what a remote host will put into
these fields, so our only recourse would be not include them in the
hash if symmetric hashes are really a requirement.

> RFS wont fly here, as DDOS traffic will need more cache misses.
>
>

  reply	other threads:[~2015-07-29 22:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-29 20:49 [PATCH net-next] flow_dissector: remove __flow_hash_consistentify Tom Herbert
2015-07-29 21:19 ` Eric Dumazet
2015-07-29 21:47   ` Tom Herbert
2015-07-29 22:15     ` Eric Dumazet
2015-07-29 22:26       ` Tom Herbert [this message]
2015-07-30 22:57 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALx6S35dQ5AUWi4jf88+m3FgDiy7nHO6UvRfPOGrsmmfkMeFLQ@mail.gmail.com \
    --to=tom@herbertland.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.