From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Herbert Subject: Re: [PATCH RFC net-next v4 7/7] sk_buff.h: improve description of CHECKSUM_{COMPLETE,UNNECESSARY} Date: Sat, 29 Apr 2017 13:20:04 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Alexander Duyck , David Laight , "David S . Miller" , Marcelo Ricardo Leitner , Linux Kernel Network Developers , "linux-sctp @ vger . kernel . org" To: Davide Caratti Return-path: Received: from mail-qk0-f196.google.com ([209.85.220.196]:32805 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162098AbdD2UUF (ORCPT ); Sat, 29 Apr 2017 16:20:05 -0400 Received: by mail-qk0-f196.google.com with SMTP id o85so13194937qkh.0 for ; Sat, 29 Apr 2017 13:20:05 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Apr 20, 2017 at 6:38 AM, Davide Caratti wrote: > Add FCoE to the list of protocols that can set CHECKSUM_UNNECESSARY; add a > note to CHECKSUM_COMPLETE section to specify that it does not apply to SCTP > and FCoE protocols. > > Suggested-by: Tom Herbert > Signed-off-by: Davide Caratti > --- > include/linux/skbuff.h | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h > index 4002c11..c902b77 100644 > --- a/include/linux/skbuff.h > +++ b/include/linux/skbuff.h > @@ -109,6 +109,7 @@ > * may perform further validation in this case. > * GRE: only if the checksum is present in the header. > * SCTP: indicates the CRC in SCTP header has been validated. > + * FCOE: indicates the CRC in FC frame has been validated. > * > * skb->csum_level indicates the number of consecutive checksums found in > * the packet minus one that have been verified as CHECKSUM_UNNECESSARY. > @@ -126,8 +127,10 @@ > * packet as seen by netif_rx() and fills out in skb->csum. Meaning, the > * hardware doesn't need to parse L3/L4 headers to implement this. > * > - * Note: Even if device supports only some protocols, but is able to produce > - * skb->csum, it MUST use CHECKSUM_COMPLETE, not CHECKSUM_UNNECESSARY. > + * Notes: > + * - Even if device supports only some protocols, but is able to produce > + * skb->csum, it MUST use CHECKSUM_COMPLETE, not CHECKSUM_UNNECESSARY. > + * - CHECKSUM_COMPLETE is not applicable to SCTP and FCoE protocols. > * > * CHECKSUM_PARTIAL: > * > -- > 2.7.4 > Acked-by: Tom Herbert From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Herbert Date: Sat, 29 Apr 2017 20:20:04 +0000 Subject: Re: [PATCH RFC net-next v4 7/7] sk_buff.h: improve description of CHECKSUM_{COMPLETE,UNNECESSARY} Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Davide Caratti Cc: Alexander Duyck , David Laight , "David S . Miller" , Marcelo Ricardo Leitner , Linux Kernel Network Developers , "linux-sctp @ vger . kernel . org" On Thu, Apr 20, 2017 at 6:38 AM, Davide Caratti wrote: > Add FCoE to the list of protocols that can set CHECKSUM_UNNECESSARY; add a > note to CHECKSUM_COMPLETE section to specify that it does not apply to SCTP > and FCoE protocols. > > Suggested-by: Tom Herbert > Signed-off-by: Davide Caratti > --- > include/linux/skbuff.h | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h > index 4002c11..c902b77 100644 > --- a/include/linux/skbuff.h > +++ b/include/linux/skbuff.h > @@ -109,6 +109,7 @@ > * may perform further validation in this case. > * GRE: only if the checksum is present in the header. > * SCTP: indicates the CRC in SCTP header has been validated. > + * FCOE: indicates the CRC in FC frame has been validated. > * > * skb->csum_level indicates the number of consecutive checksums found in > * the packet minus one that have been verified as CHECKSUM_UNNECESSARY. > @@ -126,8 +127,10 @@ > * packet as seen by netif_rx() and fills out in skb->csum. Meaning, the > * hardware doesn't need to parse L3/L4 headers to implement this. > * > - * Note: Even if device supports only some protocols, but is able to produce > - * skb->csum, it MUST use CHECKSUM_COMPLETE, not CHECKSUM_UNNECESSARY. > + * Notes: > + * - Even if device supports only some protocols, but is able to produce > + * skb->csum, it MUST use CHECKSUM_COMPLETE, not CHECKSUM_UNNECESSARY. > + * - CHECKSUM_COMPLETE is not applicable to SCTP and FCoE protocols. > * > * CHECKSUM_PARTIAL: > * > -- > 2.7.4 > Acked-by: Tom Herbert