From mboxrd@z Thu Jan 1 00:00:00 1970 From: Saeed Mahameed Subject: Re: [Patch net v2] mlx5: fixup checksum for short ethernet frame padding Date: Thu, 29 Nov 2018 16:03:52 -0800 Message-ID: References: <20181128061013.3885-1-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Eric Dumazet , Linux Netdev List , Saeed Mahameed To: Cong Wang Return-path: Received: from mail-lf1-f67.google.com ([209.85.167.67]:33378 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726446AbeK3LLX (ORCPT ); Fri, 30 Nov 2018 06:11:23 -0500 Received: by mail-lf1-f67.google.com with SMTP id i26so2834576lfc.0 for ; Thu, 29 Nov 2018 16:04:04 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Nov 28, 2018 at 4:05 PM Cong Wang wrote: > > On Wed, Nov 28, 2018 at 3:57 PM Cong Wang wrote: > > But again, I kinda feel the hardware already does the sanity check, > > otherwise we have much more serious trouble in mlx5e_lro_update_hdr() > > which parses into TCP header. > > > > While we are on this page, mlx5e_lro_update_hdr() incorrectly assumes > TCP header is located right after struct iphdr, which is wrong if we could > have IP options on this path. > > It could the hardware which already verified this corner case though. yes HW will not do LRO in case of ip options, so no problem in mlx5e_lro_update_hdr