From mboxrd@z Thu Jan  1 00:00:00 1970
From: Saeed Mahameed <saeedm@dev.mellanox.co.il>
Subject: Re: [Patch net] mlx5: check for malformed packets
Date: Tue, 4 Dec 2018 11:28:30 -0800
Message-ID: <CALzJLG9U_pcEyXxjCqD5eVqf+sh4A1OUZfasqK3sDHFPr2seyg@mail.gmail.com>
References: <20181201203837.3306-1-xiyou.wangcong@gmail.com> <CAM_iQpX_6eFzLz7-82bZsf9A-mm47MENmiRcoXHGnqs4FKRXNw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Linux Netdev List <netdev@vger.kernel.org>,
        Tariq Toukan <tariqt@mellanox.com>,
        Saeed Mahameed <saeedm@mellanox.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-lf1-f68.google.com ([209.85.167.68]:44497 "EHLO
        mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725831AbeLDT2p (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 4 Dec 2018 14:28:45 -0500
Received: by mail-lf1-f68.google.com with SMTP id z13so12836714lfe.11
        for <netdev@vger.kernel.org>; Tue, 04 Dec 2018 11:28:44 -0800 (PST)
In-Reply-To: <CAM_iQpX_6eFzLz7-82bZsf9A-mm47MENmiRcoXHGnqs4FKRXNw@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, Dec 3, 2018 at 10:39 AM Cong Wang <xiyou.wangcong@gmail.com> wrote:
>
> On Sat, Dec 1, 2018 at 12:38 PM Cong Wang <xiyou.wangcong@gmail.com> wrote:
> >
> > is_last_ethertype_ip() is used to check IP/IPv6 protocol before
> > parsing IP/IPv6 headers.
>
> One thing I noticed while reviewing the assembly code is that
> is_last_ethertype_ip() is no longer inlined after this patch.
>
> I think I should keep it inlined by using __always_inline, as it is on
> a hot path.
>
> What do you think, Tariq?

We are against having inline keywords in c file,  so better if you
move this function to a header file an force the inline keyword there.