From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D6B4C4708E for ; Tue, 3 Jan 2023 22:25:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238689AbjACWZh (ORCPT ); Tue, 3 Jan 2023 17:25:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238875AbjACWZP (ORCPT ); Tue, 3 Jan 2023 17:25:15 -0500 Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C93818E28 for ; Tue, 3 Jan 2023 14:22:49 -0800 (PST) Received: by mail-yb1-xb36.google.com with SMTP id c124so34647228ybb.13 for ; Tue, 03 Jan 2023 14:22:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lXp0j4GCOk5XOroIoxP2nQDe8lAMlFEZC0dCDiq7XBk=; b=dYnGkaP4RbPOM+0TTYgWWpcUxHSKxE07mLrY0dk6EmuddIKOE3YKA7G71vdHMZs3DD BsWTASBle2BGb6sD9gQDL9sxMBKf7EE2rSv57Encs1SYpPZLDwmZxhLy947jbNb1CRzD FSRsgD9883B5WZ4+926ycmCKY4G0bQHFoLNUQJRF+6VIqC/1/1FOOVTr28nlgoOVSGVZ JEEK3iESOoaIbXQdLgjvu3fuNgeADiRfuxD0iiyJwbqs+0VIqcdvXpqgKeOEOBU60t9k /4LhR2xxD7QifB1nDNBVlaEex+YuvnoU7CeijQv31w4zDh4vH+K4mCjiOZuO3G3lFu53 A4PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lXp0j4GCOk5XOroIoxP2nQDe8lAMlFEZC0dCDiq7XBk=; b=B/8mT2L2YK8JlFvWHzUSIhY52Txp9RDHdZy3LWL+6nVIxLFpvSrKebe8O2LX43YJRv /xXt4bEsW6jLqVL7r5p2jVg+s54RDLUy9yRHbp20faIviIOgtENc+4Eg/Hsh+DtHj402 gcWjEsHsBpa1jhgGdL3ANH0hzo8+1tyjHt6VuV6eUH4cD0bLZV7IHuf1FtrlERymdP0a mtL3v7XbGznp2nMQJyUUse5u8v3ve0ApdzhUkXK+tEzUyPJhFhsO/3XpDWV1bxzlMwLj adR6JWsh3MmTZ9e+YSMPcAwTJ578vW5Kmn/MBKkoYvzHc35FX617kcXB072TqPJk+nsU U9Zw== X-Gm-Message-State: AFqh2ko6LjYjopUsokI0De6qkXHcVDTw+5nuKlucGDV0kQ/jZekev3a/ 5pUMK1ep6B0L/ckQeG/JyqNLs2OUWnIsL1nUXSwpxw== X-Google-Smtp-Source: AMrXdXtyd8r370S7Xirp2AdLezJXgdGS+yT2IAUz+An4MrtW2Yi4j+KsuothTxG89fEw8k73pT/CjUWbSjD7R4tm1nQ= X-Received: by 2002:a25:4288:0:b0:762:7ce4:2288 with SMTP id p130-20020a254288000000b007627ce42288mr2960580yba.303.1672784542974; Tue, 03 Jan 2023 14:22:22 -0800 (PST) MIME-Version: 1.0 References: <20221213033030.83345-1-seanjc@google.com> <20221213033030.83345-6-seanjc@google.com> <49636b4c-10e1-8cec-efdf-e2bd4b832a9e@redhat.com> In-Reply-To: <49636b4c-10e1-8cec-efdf-e2bd4b832a9e@redhat.com> From: David Matlack Date: Tue, 3 Jan 2023 14:21:56 -0800 Message-ID: Subject: Re: [PATCH 5/5] KVM: x86/mmu: Move kvm_tdp_mmu_map()'s prolog and epilog to its caller To: Paolo Bonzini Cc: Sean Christopherson , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Robert Hoo , Greg Thelen , Ben Gardon , Mingwei Zhang Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 29, 2022 at 1:06 PM Paolo Bonzini wrote: > > On 12/29/22 20:51, David Matlack wrote: > > Your proposal (below) to split out the "lower half" of the page fault > > handling routine works now because that's where all the divergence is. > > But with the common MMU there's also going to be divergence in the fast > > page fault handler. So I prefer to just keep the routines separate to > > avoid thrashing down the road. > > Can you put the changes at the beginning of the common MMU series? Can do. By "the changes" I assume you mean the yet-to-be-written changes to split out a fast_page_fault() handler for the TDP MMU? Or do you mean Sean's changes (this series)? > Large parts of the whole common MMU refactoring can be merged piece by > piece, so they can be taken as soon as they're ready. Ack.