From: Matthew Auld <matthew.william.auld@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Matthew Auld <matthew.auld@intel.com>,
Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 2/6] drm/i915: s/mappable_end/mappable_size/
Date: Thu, 23 Nov 2017 10:23:46 +0000 [thread overview]
Message-ID: <CAM0jSHMLpDZDjWyeZDbQkf8bxsmsRTh+XRShBCiUA2gsGyVFhw@mail.gmail.com> (raw)
In-Reply-To: <151138702861.29492.10019975760915823463@mail.alporthouse.com>
On 22 November 2017 at 21:43, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Matthew Auld (2017-11-22 21:19:16)
>> The name mappable_end seems to suggest the end of the mappable region,
>
> This seems to be arguing for using _end :)
>
>> but is actually just the size, so make that obvious to the reader.
>
> We didn't choose size because it is a subregion within the larger GTT.
>
> At this point, I'm not sold on the conversion. Some examples of
> confusion would help, or comparison to other idioms in the code.
Assuming we move forward with 'struct resource mappable', we would now
have both:
mappable.end
mappable_end
Where mappable.end is the end of the resource, and mappable_end is the
size of the resource, which I found to be more than a little
confusing.
> -Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-11-23 10:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 21:19 [PATCH 0/6] make stolen resource centric Matthew Auld
2017-11-22 21:19 ` [PATCH 1/6] drm/i915: export the stolen region as a resource Matthew Auld
2017-11-23 6:17 ` Ingo Molnar
2017-11-23 7:48 ` Joonas Lahtinen
2017-11-23 7:59 ` Ingo Molnar
2017-11-24 7:52 ` Joonas Lahtinen
2017-11-22 21:19 ` [PATCH 2/6] drm/i915: s/mappable_end/mappable_size/ Matthew Auld
2017-11-22 21:43 ` Chris Wilson
2017-11-23 10:23 ` Matthew Auld [this message]
2017-11-22 21:19 ` [PATCH 3/6] drm/i915: make dsm struct resource centric Matthew Auld
2017-11-23 13:03 ` Chris Wilson
2017-11-22 21:19 ` [PATCH 4/6] drm/i915: make reserved " Matthew Auld
2017-11-23 13:05 ` Chris Wilson
2017-11-22 21:19 ` [PATCH 5/6] drm/i915: make mappable " Matthew Auld
2017-11-23 13:06 ` Chris Wilson
2017-11-22 21:19 ` [PATCH 6/6] drm/i915: prefer resource_size_t for stolen sizes Matthew Auld
2017-11-23 13:07 ` Chris Wilson
2017-11-22 21:48 ` ✓ Fi.CI.BAT: success for make stolen resource centric Patchwork
2017-11-22 22:26 ` ✗ Fi.CI.IGT: warning " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM0jSHMLpDZDjWyeZDbQkf8bxsmsRTh+XRShBCiUA2gsGyVFhw@mail.gmail.com \
--to=matthew.william.auld@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.