* [Intel-gfx] [PATCH] drm/i915/display: relax 2big checking around initial fb
@ 2021-05-07 9:12 Matthew Auld
2021-05-07 13:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Matthew Auld @ 2021-05-07 9:12 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter, Chris Wilson
From: Chris Wilson <chris@chris-wilson.co.uk>
The kernel prefers enabling fbc over the initial fb, since this leads to
actual runtime power savings, so if the initial fb is deemed too big
using some heuristic, then we simply skip allocating stolen for it.
However if the kernel is not configured with fbcon then it should be
possible to relax this, since unlike with fbcon the display server
shouldn't preserve it when later replacing it, and so we should be able
to re-use the stolen memory for fbc and friends. This patch is reported
to fix some flicker seen during boot splash on some devices.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Lee Shawn C <shawn.c.lee@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index ec2d3fa60003..0ee1f0213fd9 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -1455,7 +1455,7 @@ initial_plane_vma(struct drm_i915_private *i915,
* important and we should probably use that space with FBC or other
* features.
*/
- if (size * 2 > i915->stolen_usable_size)
+ if (IS_ENABLED(FRAMEBUFFER_CONSOLE) && size * 2 > i915->stolen_usable_size)
return NULL;
obj = i915_gem_object_create_stolen_for_preallocated(i915, base, size);
--
2.26.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: relax 2big checking around initial fb
2021-05-07 9:12 [Intel-gfx] [PATCH] drm/i915/display: relax 2big checking around initial fb Matthew Auld
@ 2021-05-07 13:08 ` Patchwork
2021-05-07 16:31 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-05-07 13:08 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 2494 bytes --]
== Series Details ==
Series: drm/i915/display: relax 2big checking around initial fb
URL : https://patchwork.freedesktop.org/series/89863/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10057 -> Patchwork_20083
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/index.html
Known issues
------------
Here are the changes found in Patchwork_20083 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_prime@amd-to-i915:
- fi-tgl-y: NOTRUN -> [SKIP][1] ([fdo#109315] / [i915#2575])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/fi-tgl-y/igt@amdgpu/amd_prime@amd-to-i915.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [FAIL][2] ([i915#1888]) -> [PASS][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2373]: https://gitlab.freedesktop.org/drm/intel/issues/2373
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#3277]: https://gitlab.freedesktop.org/drm/intel/issues/3277
[i915#3283]: https://gitlab.freedesktop.org/drm/intel/issues/3283
[i915#750]: https://gitlab.freedesktop.org/drm/intel/issues/750
Participating hosts (42 -> 40)
------------------------------
Missing (2): fi-ilk-m540 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_10057 -> Patchwork_20083
CI-20190529: 20190529
CI_DRM_10057: f5a084c018682f9a3362033e55ab45348d148d78 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6080: 1c450c3d4df19cf1087b8ccff3b62cb51addacae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_20083: 85c551eaa856e0fe15fe4b77d4a0a3c9116629d1 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
85c551eaa856 drm/i915/display: relax 2big checking around initial fb
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/index.html
[-- Attachment #1.2: Type: text/html, Size: 2847 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: relax 2big checking around initial fb
2021-05-07 9:12 [Intel-gfx] [PATCH] drm/i915/display: relax 2big checking around initial fb Matthew Auld
2021-05-07 13:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2021-05-07 16:31 ` Patchwork
2021-05-10 9:37 ` [Intel-gfx] [PATCH] " Lee, Shawn C
2021-05-25 13:25 ` Matthew Auld
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-05-07 16:31 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 29933 bytes --]
== Series Details ==
Series: drm/i915/display: relax 2big checking around initial fb
URL : https://patchwork.freedesktop.org/series/89863/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10057_full -> Patchwork_20083_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_20083_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@idempotent:
- shard-snb: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-snb2/igt@gem_ctx_persistence@idempotent.html
* igt@gem_ctx_persistence@legacy-engines-hang@blt:
- shard-skl: NOTRUN -> [SKIP][2] ([fdo#109271]) +45 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl6/igt@gem_ctx_persistence@legacy-engines-hang@blt.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][3] -> [FAIL][4] ([i915#2842]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-iclb2/igt@gem_exec_fair@basic-none-share@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-iclb8/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][5] ([i915#2842])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-iclb1/igt@gem_exec_fair@basic-none@vcs1.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][6] -> [FAIL][7] ([i915#2842]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_whisper@basic-fds-forked-all:
- shard-glk: [PASS][8] -> [DMESG-WARN][9] ([i915#118] / [i915#95])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-glk7/igt@gem_exec_whisper@basic-fds-forked-all.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-glk4/igt@gem_exec_whisper@basic-fds-forked-all.html
* igt@gem_pread@exhaustion:
- shard-snb: NOTRUN -> [WARN][10] ([i915#2658])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-snb6/igt@gem_pread@exhaustion.html
- shard-skl: NOTRUN -> [WARN][11] ([i915#2658])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl6/igt@gem_pread@exhaustion.html
* igt@gem_pwrite@basic-exhaustion:
- shard-kbl: NOTRUN -> [WARN][12] ([i915#2658])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl6/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_spin_batch@user-each:
- shard-skl: [PASS][13] -> [FAIL][14] ([i915#2898])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-skl10/igt@gem_spin_batch@user-each.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl7/igt@gem_spin_batch@user-each.html
* igt@gem_userptr_blits@input-checking:
- shard-kbl: NOTRUN -> [DMESG-WARN][15] ([i915#3002])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl7/igt@gem_userptr_blits@input-checking.html
- shard-snb: NOTRUN -> [DMESG-WARN][16] ([i915#3002])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-snb7/igt@gem_userptr_blits@input-checking.html
* igt@gem_userptr_blits@set-cache-level:
- shard-snb: NOTRUN -> [FAIL][17] ([i915#3324])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-snb2/igt@gem_userptr_blits@set-cache-level.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [PASS][18] -> [DMESG-WARN][19] ([i915#1436] / [i915#716])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-skl9/igt@gen9_exec_parse@allowed-single.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl8/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@batch-invalid-length:
- shard-snb: NOTRUN -> [SKIP][20] ([fdo#109271]) +357 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-snb6/igt@gen9_exec_parse@batch-invalid-length.html
* igt@gen9_exec_parse@bb-large:
- shard-skl: NOTRUN -> [FAIL][21] ([i915#3296])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl6/igt@gen9_exec_parse@bb-large.html
* igt@i915_pm_dc@dc6-dpms:
- shard-kbl: NOTRUN -> [FAIL][22] ([i915#454])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl7/igt@i915_pm_dc@dc6-dpms.html
* igt@kms_big_joiner@basic:
- shard-skl: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#2705])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl6/igt@kms_big_joiner@basic.html
* igt@kms_ccs@pipe-c-bad-pixel-format:
- shard-skl: NOTRUN -> [SKIP][24] ([fdo#109271] / [fdo#111304])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl6/igt@kms_ccs@pipe-c-bad-pixel-format.html
* igt@kms_chamelium@hdmi-aspect-ratio:
- shard-skl: NOTRUN -> [SKIP][25] ([fdo#109271] / [fdo#111827]) +6 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl6/igt@kms_chamelium@hdmi-aspect-ratio.html
* igt@kms_chamelium@vga-hpd-without-ddc:
- shard-snb: NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +21 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-snb5/igt@kms_chamelium@vga-hpd-without-ddc.html
* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [fdo#111827]) +10 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-apl3/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html
* igt@kms_color_chamelium@pipe-b-ctm-0-25:
- shard-kbl: NOTRUN -> [SKIP][28] ([fdo#109271] / [fdo#111827]) +12 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl1/igt@kms_color_chamelium@pipe-b-ctm-0-25.html
* igt@kms_cursor_crc@pipe-b-cursor-32x10-random:
- shard-kbl: NOTRUN -> [SKIP][29] ([fdo#109271]) +68 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl6/igt@kms_cursor_crc@pipe-b-cursor-32x10-random.html
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-kbl: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#533])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl6/igt@kms_cursor_legacy@pipe-d-torture-bo.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled:
- shard-skl: [PASS][31] -> [DMESG-WARN][32] ([i915#1982]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-skl1/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl2/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: NOTRUN -> [INCOMPLETE][33] ([i915#155] / [i915#180] / [i915#636])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
- shard-apl: [PASS][34] -> [DMESG-WARN][35] ([i915#180])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible@b-dp1.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible@b-dp1.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- shard-apl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#2672])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-apl3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite:
- shard-iclb: [PASS][37] -> [FAIL][38] ([i915#49])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [PASS][39] -> [DMESG-WARN][40] ([i915#180]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl2/igt@kms_hdr@bpc-switch-suspend.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl1/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#533])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-apl6/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][42] ([fdo#108145] / [i915#265]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-apl3/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-skl: NOTRUN -> [FAIL][43] ([fdo#108145] / [i915#265]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#2733])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-apl3/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
- shard-kbl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#2733])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl4/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
- shard-skl: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#2733])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl6/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-0:
- shard-kbl: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#658]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl1/igt@kms_psr2_sf@plane-move-sf-dmg-area-0.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3:
- shard-apl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#658]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-apl3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
- shard-skl: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#658])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl6/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][50] -> [SKIP][51] ([fdo#109642] / [fdo#111068] / [i915#658])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-iclb8/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: [PASS][52] -> [SKIP][53] ([fdo#109441]) +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-iclb2/igt@kms_psr@psr2_suspend.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-iclb8/igt@kms_psr@psr2_suspend.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][54] -> [DMESG-WARN][55] ([i915#180] / [i915#295])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_writeback@writeback-check-output:
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#2437])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-apl3/igt@kms_writeback@writeback-check-output.html
* igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame:
- shard-apl: NOTRUN -> [SKIP][57] ([fdo#109271]) +119 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-apl3/igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame.html
* igt@sysfs_clients@fair-1:
- shard-apl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#2994]) +2 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-apl3/igt@sysfs_clients@fair-1.html
- shard-skl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#2994])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl6/igt@sysfs_clients@fair-1.html
* igt@sysfs_clients@sema-25:
- shard-kbl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#2994]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl6/igt@sysfs_clients@sema-25.html
#### Possible fixes ####
* igt@drm_mm@all@insert:
- shard-skl: [INCOMPLETE][61] ([i915#2485] / [i915#2502]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-skl2/igt@drm_mm@all@insert.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl6/igt@drm_mm@all@insert.html
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][63] ([i915#658]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-iclb5/igt@feature_discovery@psr2.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_create@create-clear:
- shard-glk: [FAIL][65] ([i915#1888] / [i915#3160]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-glk1/igt@gem_create@create-clear.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-glk6/igt@gem_create@create-clear.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [SKIP][67] ([fdo#109271]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs1.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_whisper@basic-forked-all:
- shard-glk: [DMESG-WARN][69] ([i915#118] / [i915#95]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-glk9/igt@gem_exec_whisper@basic-forked-all.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-glk8/igt@gem_exec_whisper@basic-forked-all.html
* igt@gem_mmap_gtt@big-copy-odd:
- shard-skl: [FAIL][71] ([i915#307]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-skl4/igt@gem_mmap_gtt@big-copy-odd.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl2/igt@gem_mmap_gtt@big-copy-odd.html
* igt@kms_color@pipe-a-ctm-red-to-blue:
- shard-skl: [DMESG-WARN][73] ([i915#1982]) -> [PASS][74] +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-skl7/igt@kms_color@pipe-a-ctm-red-to-blue.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl10/igt@kms_color@pipe-a-ctm-red-to-blue.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][75] ([i915#180]) -> [PASS][76] +5 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][77] ([i915#1188]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl10/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- shard-skl: [FAIL][79] ([i915#53]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-skl8/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl1/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-kbl: [DMESG-WARN][81] ([i915#180] / [i915#533]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][83] ([fdo#108145] / [i915#265]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-b-scaler-with-clipping-clamping:
- shard-skl: [INCOMPLETE][85] ([i915#3254]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-skl2/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-b-scaler-with-clipping-clamping.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl6/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-b-scaler-with-clipping-clamping.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][87] ([fdo#109441]) -> [PASS][88] +3 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-iclb5/igt@kms_psr@psr2_cursor_mmap_cpu.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][89] ([i915#2684]) -> [WARN][90] ([i915#1804] / [i915#2684])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-iclb1/igt@i915_pm_rc6_residency@rc6-fence.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: [SKIP][91] ([i915#658]) -> [SKIP][92] ([i915#2920]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-iclb5/igt@kms_psr2_sf@cursor-plane-update-sf.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][93] ([i915#2920]) -> [SKIP][94] ([i915#658]) +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-iclb4/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][95], [FAIL][96], [FAIL][97], [FAIL][98], [FAIL][99], [FAIL][100], [FAIL][101], [FAIL][102], [FAIL][103], [FAIL][104], [FAIL][105], [FAIL][106], [FAIL][107], [FAIL][108], [FAIL][109], [FAIL][110]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2292] / [i915#2505] / [i915#3363] / [i915#602]) -> ([FAIL][111], [FAIL][112], [FAIL][113], [FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122], [FAIL][123]) ([i915#180] / [i915#1814] / [i915#2505] / [i915#3002] / [i915#3363] / [i915#602] / [i915#92])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl3/igt@runner@aborted.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl2/igt@runner@aborted.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl2/igt@runner@aborted.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl2/igt@runner@aborted.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl4/igt@runner@aborted.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl3/igt@runner@aborted.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl2/igt@runner@aborted.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl6/igt@runner@aborted.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl7/igt@runner@aborted.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl4/igt@runner@aborted.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl6/igt@runner@aborted.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl4/igt@runner@aborted.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl7/igt@runner@aborted.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl4/igt@runner@aborted.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl6/igt@runner@aborted.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-kbl4/igt@runner@aborted.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl4/igt@runner@aborted.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl2/igt@runner@aborted.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl6/igt@runner@aborted.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl1/igt@runner@aborted.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl1/igt@runner@aborted.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl4/igt@runner@aborted.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl7/igt@runner@aborted.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl7/igt@runner@aborted.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl2/igt@runner@aborted.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl6/igt@runner@aborted.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl3/igt@runner@aborted.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl6/igt@runner@aborted.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-kbl7/igt@runner@aborted.html
- shard-apl: ([FAIL][124], [FAIL][125]) ([i915#3002] / [i915#3363]) -> ([FAIL][126], [FAIL][127], [FAIL][128]) ([i915#180] / [i915#3002] / [i915#3363])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-apl8/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-apl7/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-apl2/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-apl2/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-apl1/igt@runner@aborted.html
- shard-skl: ([FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133]) ([i915#1814] / [i915#2029] / [i915#2485] / [i915#3002] / [i915#3363]) -> ([FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137]) ([i915#1436] / [i915#2029] / [i915#3002] / [i915#3363])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-skl8/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-skl2/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-skl4/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-skl2/igt@runner@aborted.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10057/shard-skl2/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl10/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl2/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl4/igt@runner@aborted.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/shard-skl8/igt@runner@aborted.html
### Piglit changes ###
#### Issues hit ####
* spec@ext_framebuffer_multisample_blit_scaled@blit-scaled samples=2:
- pig-glk-j5005: NOTRUN -> [WARN][138] ([i915#3105] / [mesa#1797]) +1 similar issue
[138]: None
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111304]: https://bugs.freedesktop.org/show_bug.cgi?id=111304
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2292]: https://gitlab.freedesktop.org/drm/intel/issues/2292
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2485]: https://gitlab.freedesktop.org/drm/intel/issues/2485
[i915#2502]: https://gitlab.freedesktop.org/drm/intel/issues/2502
[i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2733]: https://gitlab.freedesktop.org/drm/intel/issues/2733
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2898]: https://gitlab.freedesktop.org/drm/intel/issues/2898
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#307]: https://gitlab.freedesktop.org/drm/intel/issues/307
[i915#3105]: https://gitlab.freedesktop.org/drm/intel/issues/3105
[i915#3160]: https://gitlab.freedesktop.org/drm/intel/issues/3160
[i915#3254]: https://gitlab.freedesktop.org/drm/intel/issues/3254
[i915#3296]: https://gitlab.freedesktop.org/drm/intel/issues/3296
[i915#3324]: https://gitlab.freedesktop.org/drm/intel/issues/3324
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#602]: https://gitlab.freedesktop.org/drm/intel/issues/602
[i915#636]: https://gitlab.freedesktop.org/drm/intel/issues/636
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[mesa#1797]: https://gitlab.freedesktop.org/mesa/mesa/issues/1797
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_10057 -> Patchwork_20083
CI-20190529: 20190529
CI_DRM_10057: f5a084c018682f9a3362033e55ab45348d148d78 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6080: 1c450c3d4df19cf1087b8ccff3b62cb51addacae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_20083: 85c551eaa856e0fe15fe4b77d4a0a3c9116629d1 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20083/index.html
[-- Attachment #1.2: Type: text/html, Size: 37773 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: relax 2big checking around initial fb
2021-05-07 9:12 [Intel-gfx] [PATCH] drm/i915/display: relax 2big checking around initial fb Matthew Auld
2021-05-07 13:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-05-07 16:31 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2021-05-10 9:37 ` Lee, Shawn C
2021-05-25 13:25 ` Matthew Auld
3 siblings, 0 replies; 6+ messages in thread
From: Lee, Shawn C @ 2021-05-10 9:37 UTC (permalink / raw)
To: Auld, Matthew, intel-gfx; +Cc: Vetter, Daniel, Chris Wilson
On Fri, 7 May 2021, Auld, Matthew <matthew.auld@intel.com> wrote:
>
>From: Chris Wilson <chris@chris-wilson.co.uk>
>
>The kernel prefers enabling fbc over the initial fb, since this leads to
>actual runtime power savings, so if the initial fb is deemed too big
>using some heuristic, then we simply skip allocating stolen for it.
>However if the kernel is not configured with fbcon then it should be
>possible to relax this, since unlike with fbcon the display server
>shouldn't preserve it when later replacing it, and so we should be able
>to re-use the stolen memory for fbc and friends. This patch is reported
>to fix some flicker seen during boot splash on some devices.
>
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>Cc: Lee Shawn C <shawn.c.lee@intel.com>
>Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>Cc: Daniel Vetter <daniel.vetter@intel.com>
No more flicker issue seen during boot splash with this patch on my DUT. Thanks!
>---
> drivers/gpu/drm/i915/display/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
>index ec2d3fa60003..0ee1f0213fd9 100644
>--- a/drivers/gpu/drm/i915/display/intel_display.c
>+++ b/drivers/gpu/drm/i915/display/intel_display.c
>@@ -1455,7 +1455,7 @@ initial_plane_vma(struct drm_i915_private *i915,
> * important and we should probably use that space with FBC or other
> * features.
> */
>- if (size * 2 > i915->stolen_usable_size)
>+ if (IS_ENABLED(FRAMEBUFFER_CONSOLE) && size * 2 >
>+i915->stolen_usable_size)
> return NULL;
>
> obj = i915_gem_object_create_stolen_for_preallocated(i915, base, size);
>--
>2.26.3
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: relax 2big checking around initial fb
2021-05-07 9:12 [Intel-gfx] [PATCH] drm/i915/display: relax 2big checking around initial fb Matthew Auld
` (2 preceding siblings ...)
2021-05-10 9:37 ` [Intel-gfx] [PATCH] " Lee, Shawn C
@ 2021-05-25 13:25 ` Matthew Auld
2021-05-25 15:19 ` Imre Deak
3 siblings, 1 reply; 6+ messages in thread
From: Matthew Auld @ 2021-05-25 13:25 UTC (permalink / raw)
To: Matthew Auld; +Cc: Daniel Vetter, Intel Graphics Development, Chris Wilson
On Fri, 7 May 2021 at 10:12, Matthew Auld <matthew.auld@intel.com> wrote:
>
> From: Chris Wilson <chris@chris-wilson.co.uk>
>
> The kernel prefers enabling fbc over the initial fb, since this leads to
> actual runtime power savings, so if the initial fb is deemed too big
> using some heuristic, then we simply skip allocating stolen for it.
> However if the kernel is not configured with fbcon then it should be
> possible to relax this, since unlike with fbcon the display server
> shouldn't preserve it when later replacing it, and so we should be able
> to re-use the stolen memory for fbc and friends. This patch is reported
> to fix some flicker seen during boot splash on some devices.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Lee Shawn C <shawn.c.lee@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
Ville, Imre, or somebody else with display experience, does this at
least look somewhat reasonable?
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index ec2d3fa60003..0ee1f0213fd9 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -1455,7 +1455,7 @@ initial_plane_vma(struct drm_i915_private *i915,
> * important and we should probably use that space with FBC or other
> * features.
> */
> - if (size * 2 > i915->stolen_usable_size)
> + if (IS_ENABLED(FRAMEBUFFER_CONSOLE) && size * 2 > i915->stolen_usable_size)
> return NULL;
>
> obj = i915_gem_object_create_stolen_for_preallocated(i915, base, size);
> --
> 2.26.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: relax 2big checking around initial fb
2021-05-25 13:25 ` Matthew Auld
@ 2021-05-25 15:19 ` Imre Deak
0 siblings, 0 replies; 6+ messages in thread
From: Imre Deak @ 2021-05-25 15:19 UTC (permalink / raw)
To: Matthew Auld
Cc: Daniel Vetter, Intel Graphics Development, Matthew Auld, Chris Wilson
On Tue, May 25, 2021 at 02:25:15PM +0100, Matthew Auld wrote:
> On Fri, 7 May 2021 at 10:12, Matthew Auld <matthew.auld@intel.com> wrote:
> >
> > From: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > The kernel prefers enabling fbc over the initial fb, since this leads to
> > actual runtime power savings, so if the initial fb is deemed too big
> > using some heuristic, then we simply skip allocating stolen for it.
> > However if the kernel is not configured with fbcon then it should be
> > possible to relax this, since unlike with fbcon the display server
> > shouldn't preserve it when later replacing it, and so we should be able
> > to re-use the stolen memory for fbc and friends. This patch is reported
> > to fix some flicker seen during boot splash on some devices.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> > Cc: Lee Shawn C <shawn.c.lee@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Daniel Vetter <daniel.vetter@intel.com>
>
> Ville, Imre, or somebody else with display experience, does this at
> least look somewhat reasonable?
>
> > ---
> > drivers/gpu/drm/i915/display/intel_display.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> > index ec2d3fa60003..0ee1f0213fd9 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -1455,7 +1455,7 @@ initial_plane_vma(struct drm_i915_private *i915,
> > * important and we should probably use that space with FBC or other
> > * features.
> > */
> > - if (size * 2 > i915->stolen_usable_size)
> > + if (IS_ENABLED(FRAMEBUFFER_CONSOLE) && size * 2 > i915->stolen_usable_size)
Makes sense and aligns with how the FB object is allocated in intelfb_alloc():
Reviewed-by: Imre Deak <imre.deak@intel.com>
> > return NULL;
> >
> > obj = i915_gem_object_create_stolen_for_preallocated(i915, base, size);
> > --
> > 2.26.3
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-25 15:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-07 9:12 [Intel-gfx] [PATCH] drm/i915/display: relax 2big checking around initial fb Matthew Auld
2021-05-07 13:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-05-07 16:31 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-05-10 9:37 ` [Intel-gfx] [PATCH] " Lee, Shawn C
2021-05-25 13:25 ` Matthew Auld
2021-05-25 15:19 ` Imre Deak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.