From: Matthew Auld <matthew.william.auld@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] drm/i915: Track the purgeable objects on a separate eviction list
Date: Thu, 30 May 2019 16:51:28 +0100 [thread overview]
Message-ID: <CAM0jSHMtamaRH0QM87yMn9UG-bFvRRo7G8iLcNL76BgdsQUnLA@mail.gmail.com> (raw)
In-Reply-To: <20190528195022.11531-1-chris@chris-wilson.co.uk>
On Tue, 28 May 2019 at 20:50, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Currently the purgeable objects, I915_MADV_DONTNEED, as mixed in the
> normal bound/unbound lists. Every shrinker pass starts with an attempt
> to purge from this set of unneeded objects, which entails us doing a
> walk over both lists looking for any candidates. If there are none, and
> since we are shrinking we can reasonably assume that the lists are
> full!, this becomes a very slow futile walk.
>
> If we separate out the purgeable objects into own list, this search then
> becomes its own phase that is preferentially handled during shrinking.
> Instead the cost becomes that we then need to filter the purgeable list
> if we want to distinguish between bound and unbound objects.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Matthew Auld <matthew.william.auld@gmail.com>
Makes sense,
Reviewed-by: Matthew Auld <matthew.william.auld@gmail.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-05-30 15:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 19:50 [PATCH 1/2] drm/i915: Track the purgeable objects on a separate eviction list Chris Wilson
2019-05-28 19:50 ` [PATCH 2/2] drm/i915: Report all objects with allocated pages to the shrinker Chris Wilson
2019-05-30 16:10 ` Matthew Auld
2019-05-30 19:10 ` Chris Wilson
2019-05-28 20:24 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Track the purgeable objects on a separate eviction list Patchwork
2019-05-28 20:41 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-29 7:53 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-05-30 15:51 ` Matthew Auld [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-05-30 20:34 [PATCH 1/2] " Chris Wilson
2018-05-13 8:21 Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM0jSHMtamaRH0QM87yMn9UG-bFvRRo7G8iLcNL76BgdsQUnLA@mail.gmail.com \
--to=matthew.william.auld@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.