From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthew Auld <matthew.william.auld@gmail.com>
Subject: Re: [PATCH 08/46] drm/i915/execlists: Suppress mere
 WAIT preemption
Date: Tue, 19 Feb 2019 10:22:57 +0000
Message-ID: <CAM0jSHMvKeJDvK+mGSfUe_W4Vh2+AKy1qgNmwJhHXorTKbCMbw@mail.gmail.com>
References: <20190206130356.18771-1-chris@chris-wilson.co.uk>
 <20190206130356.18771-9-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-vk1-xa44.google.com (mail-vk1-xa44.google.com
 [IPv6:2607:f8b0:4864:20::a44])
 by gabe.freedesktop.org (Postfix) with ESMTPS id CDFD489298
 for <intel-gfx@lists.freedesktop.org>; Tue, 19 Feb 2019 10:23:24 +0000 (UTC)
Received: by mail-vk1-xa44.google.com with SMTP id v187so2745066vkf.12
 for <intel-gfx@lists.freedesktop.org>; Tue, 19 Feb 2019 02:23:24 -0800 (PST)
In-Reply-To: <20190206130356.18771-9-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCA2IEZlYiAyMDE5IGF0IDEzOjA1LCBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdp
bHNvbi5jby51az4gd3JvdGU6Cj4KPiBXQUlUIGlzIG9jY2FzaW9uYWxseSBzdXBwcmVzc2VkIGJ5
IHZpcnR1ZSBvZiBwcmVlbXB0ZWQgcmVxdWVzdHMgYmVpbmcKPiBwcm9tb3RlZCB0byBORVdDTElF
TlQgaWYgdGhleSBoYXZlIG5vdCBhbGwgcmVhZHkgcmVjZWl2ZWQgdGhhdCBib29zdC4KPiBNYWtl
IHRoaXMgY29uc2lzdGVudCBmb3IgYWxsIFdBSVQgYm9vc3RzIHRoYXQgdGhleSBhcmUgbm90IGFs
bG93ZWQgdG8KPiBwcmVlbXB0IGV4ZWN1dGluZyBjb250ZXh0cyBhbmQgYXJlIG1lcmVseSBncmFu
dGVkIHRoZSByaWdodCB0byBiZSBhdCB0aGUKPiBmcm9udCBvZiB0aGUgcXVldWUgZm9yIHRoZSBu
ZXh0IGV4ZWN1dGlvbiBzbG90LiBUaGlzIGlzIGluIGtlZXBpbmcgd2l0aAo+IHRoZSBkZXNpcmUg
dGhhdCB0aGUgV0FJVCBib29zdCBiZSBhIG1pbm9yIHR3ZWFrIHRoYXQgZG9lcyBub3QgZ2l2ZQo+
IGV4Y2Vzc2l2ZSBwcm9tb3Rpb24gdG8gaXRzIHVzZXIgYW5kIG9wZW4gb3Vyc2VsdmVzIHRvIHRy
aXZpYWwgYWJ1c2UuCj4KPiBUaGUgcHJvYmxlbSB3aXRoIHRoZSBpbmNvbnNpc3RlbnQgV0FJVCBw
cmVlbXB0aW9uIGJlY29tZXMgbW9yZSBhcHBhcmVudAo+IGFzIHRoZSBwcmVlbXB0aW9uIGlzIHBy
b3BhZ2F0ZWQgYWNyb3NzIHRoZSBlbmdpbmVzLCB3aGVyZSBvbmUgZW5naW5lIG1heQo+IHByZWVt
cHQgYW5kIHRoZSBvdGhlciBub3QsIGFuZCB3ZSBiZSByZWx5aW5nIG9uIHRoZSBleGFjdCBleGVj
dXRpb24KPiBvcmRlciBiZWluZyBjb25zaXN0ZW50IGFjcm9zcyBlbmdpbmVzIChlLmcuIHVzaW5n
IEhXIHNlbWFwaG9yZXMgdG8KPiBjb29yZGluYXRlIHBhcmFsbGVsIGV4ZWN1dGlvbikuCj4KPiB2
MjogQWxzbyBwcm90ZWN0IEd1QyBzdWJtaXNzaW9uIGZyb20gZmFsc2UgcHJlZW1wdGlvbiBsb29w
cy4KPiB2MzogQnVpbGQgYnVnIHNhZmVndWFyZHMgYW5kIGJldHRlciBkZWJ1ZyBtZXNzYWdlcyBm
b3Igc3QuCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNv
bi5jby51az4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K
PiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXF1ZXN0LmMgICAgICAgIHwgIDEy
ICsrCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfc2NoZWR1bGVyLmggICAgICB8ICAgMiAr
Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jICAgICAgICAgICB8ICAgOSArLQo+
ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvaW50ZWxfbHJjLmMgfCAxNjEgKysrKysr
KysrKysrKysrKysrKysrCj4gIDQgZmlsZXMgY2hhbmdlZCwgMTgzIGluc2VydGlvbnMoKyksIDEg
ZGVsZXRpb24oLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Jl
cXVlc3QuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVxdWVzdC5jCj4gaW5kZXggYzJh
NWM0OGM3NTQxLi4zNWFjZWY3NGI5M2EgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaTkxNV9yZXF1ZXN0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlcXVl
c3QuYwo+IEBAIC0zNzIsMTIgKzM3MiwyNCBAQCB2b2lkIF9faTkxNV9yZXF1ZXN0X3N1Ym1pdChz
dHJ1Y3QgaTkxNV9yZXF1ZXN0ICpyZXF1ZXN0KQo+Cj4gICAgICAgICAvKiBXZSBtYXkgYmUgcmVj
dXJzaW5nIGZyb20gdGhlIHNpZ25hbCBjYWxsYmFjayBvZiBhbm90aGVyIGk5MTUgZmVuY2UgKi8K
PiAgICAgICAgIHNwaW5fbG9ja19uZXN0ZWQoJnJlcXVlc3QtPmxvY2ssIFNJTkdMRV9ERVBUSF9O
RVNUSU5HKTsKPiArCj4gICAgICAgICBHRU1fQlVHX09OKHRlc3RfYml0KEk5MTVfRkVOQ0VfRkxB
R19BQ1RJVkUsICZyZXF1ZXN0LT5mZW5jZS5mbGFncykpOwo+ICAgICAgICAgc2V0X2JpdChJOTE1
X0ZFTkNFX0ZMQUdfQUNUSVZFLCAmcmVxdWVzdC0+ZmVuY2UuZmxhZ3MpOwo+ICsKPiAgICAgICAg
IHJlcXVlc3QtPmdsb2JhbF9zZXFubyA9IHNlcW5vOwo+ICAgICAgICAgaWYgKHRlc3RfYml0KERN
QV9GRU5DRV9GTEFHX0VOQUJMRV9TSUdOQUxfQklULCAmcmVxdWVzdC0+ZmVuY2UuZmxhZ3MpICYm
Cj4gICAgICAgICAgICAgIWk5MTVfcmVxdWVzdF9lbmFibGVfYnJlYWRjcnVtYihyZXF1ZXN0KSkK
PiAgICAgICAgICAgICAgICAgaW50ZWxfZW5naW5lX3F1ZXVlX2JyZWFkY3J1bWJzKGVuZ2luZSk7
Cj4gKwo+ICsgICAgICAgLyoKPiArICAgICAgICAqIEFzIHdlIGRvIG5vdCBhbGxvdyBXQUlUIHRv
IHByZWVtcHQgaW5mbGlnaHQgcmVxdWVzdHMsCj4gKyAgICAgICAgKiBvbmNlIHdlIGhhdmUgZXhl
Y3V0ZWQgYSByZXF1ZXN0LCBhbG9uZyB3aXRoIHRyaWdnZXJpbmcKPiArICAgICAgICAqIGFueSBl
eGVjdXRpb24gY2FsbGJhY2tzLCB3ZSBtdXN0IHByZXNlcnZlIGl0cyBvcmRlcmluZwo+ICsgICAg
ICAgICogd2l0aGluIHRoZSBub24tcHJlZW1wdGlibGUgRklGTy4KPiArICAgICAgICAqLwo+ICsg
ICAgICAgQlVJTERfQlVHX09OKF9fTk9fUFJFRU1QVElPTiAmIH5JOTE1X1BSSU9SSVRZX01BU0sp
OyAvKiBvbmx5IGludGVybmFsICovCj4gKyAgICAgICByZXF1ZXN0LT5zY2hlZC5hdHRyLnByaW9y
aXR5IHw9IF9fTk9fUFJFRU1QVElPTjsKPiArCj4gICAgICAgICBzcGluX3VubG9jaygmcmVxdWVz
dC0+bG9jayk7Cj4KPiAgICAgICAgIGVuZ2luZS0+ZW1pdF9maW5pX2JyZWFkY3J1bWIocmVxdWVz
dCwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zY2hlZHVsZXIuaCBi
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfc2NoZWR1bGVyLmgKPiBpbmRleCBkYmU5Y2I3ZWNk
ODIuLjU0YmQ2Yzg5ODE3ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1
X3NjaGVkdWxlci5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zY2hlZHVsZXIu
aAo+IEBAIC0zMyw2ICszMyw4IEBAIGVudW0gewo+ICAjZGVmaW5lIEk5MTVfUFJJT1JJVFlfV0FJ
VCAgICAgKCh1OClCSVQoMCkpCj4gICNkZWZpbmUgSTkxNV9QUklPUklUWV9ORVdDTElFTlQgICAg
ICAgICgodTgpQklUKDEpKQo+Cj4gKyNkZWZpbmUgX19OT19QUkVFTVBUSU9OIChJOTE1X1BSSU9S
SVRZX1dBSVQpCj4gKwo+ICBzdHJ1Y3QgaTkxNV9zY2hlZF9hdHRyIHsKPiAgICAgICAgIC8qKgo+
ICAgICAgICAgICogQHByaW9yaXR5OiBleGVjdXRpb24gYW5kIHNlcnZpY2UgcHJpb3JpdHkKPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IGluZGV4IDVkNWNlOTFhNWRmYS4uYWZkMDVlMjVmOTEx
IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gKysrIGIv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBAQCAtMTg4LDYgKzE4OCwxMiBAQCBz
dGF0aWMgaW5saW5lIGludCBycV9wcmlvKGNvbnN0IHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxKQo+
ICAgICAgICAgcmV0dXJuIHJxLT5zY2hlZC5hdHRyLnByaW9yaXR5Owo+ICB9Cj4KPiArc3RhdGlj
IGludCBlZmZlY3RpdmVfcHJpbyhjb25zdCBzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycSkKPiArewo+
ICsgICAgICAgLyogUmVzdHJpY3QgbWVyZSBXQUlUIGJvb3N0cyBmcm9tIHRyaWdnZXJpbmcgcHJl
ZW1wdGlvbiAqLwo+ICsgICAgICAgcmV0dXJuIHJxX3ByaW8ocnEpIHwgX19OT19QUkVFTVBUSU9O
Owo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IHF1ZXVlX3ByaW8oY29uc3Qgc3RydWN0IGludGVsX2Vu
Z2luZV9leGVjbGlzdHMgKmV4ZWNsaXN0cykKPiAgewo+ICAgICAgICAgc3RydWN0IGk5MTVfcHJp
b2xpc3QgKnA7Cj4gQEAgLTIwOCw3ICsyMTQsNyBAQCBzdGF0aWMgaW50IHF1ZXVlX3ByaW8oY29u
c3Qgc3RydWN0IGludGVsX2VuZ2luZV9leGVjbGlzdHMgKmV4ZWNsaXN0cykKPiAgc3RhdGljIGlu
bGluZSBib29sIG5lZWRfcHJlZW1wdChjb25zdCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdp
bmUsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgaTkxNV9y
ZXF1ZXN0ICpycSkKPiAgewo+IC0gICAgICAgY29uc3QgaW50IGxhc3RfcHJpbyA9IHJxX3ByaW8o
cnEpOwo+ICsgICAgICAgaW50IGxhc3RfcHJpbzsKPgo+ICAgICAgICAgaWYgKCFpbnRlbF9lbmdp
bmVfaGFzX3ByZWVtcHRpb24oZW5naW5lKSkKPiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNl
Owo+IEBAIC0yMjgsNiArMjM0LDcgQEAgc3RhdGljIGlubGluZSBib29sIG5lZWRfcHJlZW1wdChj
b25zdCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gICAgICAgICAgKiBwcmVlbXB0
LiBJZiB0aGF0IGhpbnQgaXMgc3RhbGUgb3Igd2UgbWF5IGJlIHRyeWluZyB0byBwcmVlbXB0Cj4g
ICAgICAgICAgKiBvdXJzZWx2ZXMsIGlnbm9yZSB0aGUgcmVxdWVzdC4KPiAgICAgICAgICAqLwo+
ICsgICAgICAgbGFzdF9wcmlvID0gZWZmZWN0aXZlX3ByaW8ocnEpOwo+ICAgICAgICAgaWYgKCFf
X2V4ZWNsaXN0c19uZWVkX3ByZWVtcHQoZW5naW5lLT5leGVjbGlzdHMucXVldWVfcHJpb3JpdHlf
aGludCwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxhc3RfcHJpbykp
Cj4gICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n
cHUvZHJtL2k5MTUvc2VsZnRlc3RzL2ludGVsX2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv
c2VsZnRlc3RzL2ludGVsX2xyYy5jCj4gaW5kZXggNTgxNDRlMDI0NzUxLi4yNjNhZmQyZjE1OTYg
MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2ludGVsX2xyYy5j
Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2ludGVsX2xyYy5jCj4gQEAg
LTQwNyw2ICs0MDcsMTY2IEBAIHN0YXRpYyBpbnQgbGl2ZV9zdXBwcmVzc19zZWxmX3ByZWVtcHQo
dm9pZCAqYXJnKQo+ICAgICAgICAgZ290byBlcnJfY2xpZW50X2I7Cj4gIH0KPgo+ICtzdGF0aWMg
aW50IF9faTkxNV9zd19mZW5jZV9jYWxsCj4gK2R1bW15X25vdGlmeShzdHJ1Y3QgaTkxNV9zd19m
ZW5jZSAqZmVuY2UsIGVudW0gaTkxNV9zd19mZW5jZV9ub3RpZnkgc3RhdGUpCj4gK3sKPiArICAg
ICAgIHJldHVybiBOT1RJRllfRE9ORTsKPiArfQo+ICsKPiArc3RhdGljIHN0cnVjdCBpOTE1X3Jl
cXVlc3QgKmR1bW15X3JlcXVlc3Qoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICt7
Cj4gKyAgICAgICBzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycTsKPiArCj4gKyAgICAgICBycSA9IGtt
YWxsb2Moc2l6ZW9mKCpycSksIEdGUF9LRVJORUwgfCBfX0dGUF9aRVJPKTsKPiArICAgICAgIGlm
ICghcnEpCj4gKyAgICAgICAgICAgICAgIHJldHVybiBOVUxMOwo+ICsKPiArICAgICAgIElOSVRf
TElTVF9IRUFEKCZycS0+YWN0aXZlX2xpc3QpOwo+ICsgICAgICAgcnEtPmVuZ2luZSA9IGVuZ2lu
ZTsKPiArCj4gKyAgICAgICBpOTE1X3NjaGVkX25vZGVfaW5pdCgmcnEtPnNjaGVkKTsKPiArCj4g
KyAgICAgICAvKiBtYXJrIHRoaXMgcmVxdWVzdCBhcyBwZXJtYW5lbnRseSBpbmNvbXBsZXRlICov
Cj4gKyAgICAgICBycS0+ZmVuY2Uuc2Vxbm8gPSAxOwo+ICsgICAgICAgQlVJTERfQlVHX09OKHNp
emVvZihycS0+ZmVuY2Uuc2Vxbm8pICE9IDgpOyAvKiB1cHBlciAzMmIgPT0gMCAqLwo+ICsgICAg
ICAgcnEtPmh3c3Bfc2Vxbm8gPSAodTMyICopJnJxLT5mZW5jZS5zZXFubyArIDE7Cj4gKyAgICAg
ICBHRU1fQlVHX09OKGk5MTVfcmVxdWVzdF9jb21wbGV0ZWQocnEpKTsKPiArCj4gKyAgICAgICBp
OTE1X3N3X2ZlbmNlX2luaXQoJnJxLT5zdWJtaXQsIGR1bW15X25vdGlmeSk7Cj4gKyAgICAgICBp
OTE1X3N3X2ZlbmNlX2NvbW1pdCgmcnEtPnN1Ym1pdCk7Cj4gKwo+ICsgICAgICAgcmV0dXJuIHJx
Owo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZCBkdW1teV9yZXF1ZXN0X2ZyZWUoc3RydWN0IGk5MTVf
cmVxdWVzdCAqZHVtbXkpCj4gK3sKPiArICAgICAgIGk5MTVfcmVxdWVzdF9tYXJrX2NvbXBsZXRl
KGR1bW15KTsKPiArICAgICAgIGk5MTVfc2NoZWRfbm9kZV9maW5pKGR1bW15LT5lbmdpbmUtPmk5
MTUsICZkdW1teS0+c2NoZWQpOwoKRG8gd2UgbmVlZCBpOTE1X3N3X2ZlbmNlX2ZpbmkoKSBpbiBo
ZXJlIHNvbWV3aGVyZT8KCldoaWxlIGxvb2tpbmcgYXQgc29tZXRoaW5nIHVucmVsYXRlZCBJIGhp
dCBzb21ldGhpbmcgbGlrZToKT0RFQlVHOiBpbml0IGRlc3Ryb3llZCAoYWN0aXZlIHN0YXRlIDAp
IG9iamVjdCB0eXBlOiBpOTE1X3N3X2ZlbmNlCmhpbnQ6ICAgICAgICAgICAobnVsbCkKX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp
bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl
ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4