From: Matthew Auld <matthew.william.auld@gmail.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH 1/6] drm/xe: Make local functions static
Date: Wed, 22 Feb 2023 09:48:27 +0000 [thread overview]
Message-ID: <CAM0jSHN1TZ4nzs+NOxAywkBq1J+aXhBTuw65Tf-p8qRzWceghA@mail.gmail.com> (raw)
In-Reply-To: <20230221233348.883897-2-lucas.demarchi@intel.com>
On Tue, 21 Feb 2023 at 23:34, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
>
> A few static functions not being declared like that break the build with
> W=1, like e.g.
>
> cc1: all warnings being treated as errors
> make[2]: *** [../scripts/Makefile.build:250: drivers/gpu/drm/xe/xe_gt.o] Error 1
> ../drivers/gpu/drm/xe/xe_guc.c:240:6: error: no previous prototype for ‘guc_write_params’ [-Werror=missing-prototypes]
> 240 | void guc_write_params(struct xe_guc *guc)
> | ^~~~~~~~~~~~~~~~
>
> Make them static.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
next prev parent reply other threads:[~2023-02-22 9:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 23:33 [Intel-xe] [PATCH 0/6] Cleanup warnings (fix build with W=1) Lucas De Marchi
2023-02-21 23:33 ` [Intel-xe] [PATCH 1/6] drm/xe: Make local functions static Lucas De Marchi
2023-02-22 9:48 ` Matthew Auld [this message]
2023-02-21 23:33 ` [Intel-xe] [PATCH 2/6] drm/xe: Fix application of LRC tunings Lucas De Marchi
2023-02-22 10:16 ` Matthew Auld
2023-02-21 23:33 ` [Intel-xe] [PATCH 3/6] drm/xe: Fix kunit integration due to missing prototypes Lucas De Marchi
2023-02-22 10:02 ` Matthew Auld
2023-02-22 14:59 ` Lucas De Marchi
2023-02-22 17:10 ` Matthew Auld
2023-02-22 17:42 ` Lucas De Marchi
2023-02-21 23:33 ` [Intel-xe] [PATCH 4/6] drm/xe: Remove unused functions Lucas De Marchi
2023-02-22 10:05 ` Matthew Auld
2023-02-21 23:33 ` [Intel-xe] [PATCH 5/6] drm/xe: Add missing doc for xe parameter Lucas De Marchi
2023-02-22 10:06 ` Matthew Auld
2023-02-21 23:33 ` [Intel-xe] [PATCH 6/6] drm/xe: Add missing include xe_wait_user_fence.h Lucas De Marchi
2023-02-22 10:07 ` Matthew Auld
2023-02-23 0:37 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM0jSHN1TZ4nzs+NOxAywkBq1J+aXhBTuw65Tf-p8qRzWceghA@mail.gmail.com \
--to=matthew.william.auld@gmail.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.