From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7D3FC11F68 for ; Wed, 30 Jun 2021 14:44:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83A8F61396 for ; Wed, 30 Jun 2021 14:44:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83A8F61396 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BCF2B6E9F0; Wed, 30 Jun 2021 14:44:27 +0000 (UTC) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by gabe.freedesktop.org (Postfix) with ESMTPS id 929B56E9ED; Wed, 30 Jun 2021 14:44:26 +0000 (UTC) Received: by mail-qk1-x729.google.com with SMTP id g4so2686096qkl.1; Wed, 30 Jun 2021 07:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=2et4KT8L7jP1mpy1oRnNKAxEFKAA245RyizNmHQJu0A=; b=ni5kdzxQso5O4x03O43MLQ5luCngKEGnziDGHOwB0BDqj2w8T0yFdCUnfEBkT4LhU5 3Co387LUv4yL5KexqbyNYo9fqQAKxKW+eSWS2hXAtc90q06oIC0oU1chVz9C4lSy/lLF /OQMjJHw+qbNSH2jgo99F3czxlceRMq3FZczu67/wzqCYI2l2eNTsoyzQ/Ka7BDShFw/ KCUkEcOmWzAkFxn73PqFcRzR1lU9HsFozhbKhiuMnHVQ2tlDtoLcyqjWPn9W5OToIJAT xxQR1aNiVvNRan1AacNShdz6qjDx1O/gdVc5+tMDkF5Og6nGNcXLk+booiS89NkiUMZO Rocw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=2et4KT8L7jP1mpy1oRnNKAxEFKAA245RyizNmHQJu0A=; b=LgNOL+oW2pgREMzrc76irPvu90QbY6bML73/unIvpkMZsrco5utS3BP152A2h2SKh+ va/mfm56FtNsJ5bz8AbC2hRK6bWBVLfAotk7fgkfzuImbgVlebPiFlWBEwzbn1bEb7N3 Y0ZHKghmqzxuP4C2U4KJLMYTeUHJE+OMoA6a9345MFb/9iI6GDyz3aiXZZjRkppWWKng MK2HEzD2upRDanrIqDdYnNug6kLYJ3unWSixOvisg5+wev6jI+wraHtHiZMNPptxOngo Aksq4BMDs5+A2DrQ/MNuGbdm0g7fAhrTjMWwi7WNj8qvxRoQcvN0mC5N0qDMgQpArkh3 Mrlg== X-Gm-Message-State: AOAM533KMsuHPb1I3ZHh+jjNVQGefIMl2dTKBn0poR/idfWUK2xQ2fz6 OWBRDjpRZIu4cZz6liLJ8VF5b+URQ1OVLLXlU5E= X-Google-Smtp-Source: ABdhPJxiK8zCjwPamhLlfl78bsXkHxIX+9Bmr6sCiaks76JUqJN6r0IHzYOIK1vmUJVT9klXzcEEbEFUWmdzUq/ush0= X-Received: by 2002:a37:b1c3:: with SMTP id a186mr37560568qkf.17.1625064265801; Wed, 30 Jun 2021 07:44:25 -0700 (PDT) MIME-Version: 1.0 References: <20210624193045.5087-1-thomas.hellstrom@linux.intel.com> <20210624193045.5087-3-thomas.hellstrom@linux.intel.com> In-Reply-To: <20210624193045.5087-3-thomas.hellstrom@linux.intel.com> From: Matthew Auld Date: Wed, 30 Jun 2021 15:43:59 +0100 Message-ID: Subject: Re: [PATCH 2/2] drm/ttm, drm/i915: Update ttm_move_memcpy for async use To: =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Development , Matthew Auld , ML dri-devel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 24 Jun 2021 at 20:31, Thomas Hellstr=C3=B6m wrote: > > The buffer object argument to ttm_move_memcpy was only used to > determine whether the destination memory should be cleared only > or whether we should copy data. Replace it with a "clear" bool, and > update the callers. > > The intention here is to be able to use ttm_move_memcpy() async under > a dma-fence as a fallback if an accelerated blit fails in a security- > critical path where data might leak if the blit is not properly > performed. For that purpose the bo is an unsuitable argument since > its relevant members might already have changed at call time. > > Finally, update the ttm_move_memcpy kerneldoc that seems to have > ended up with a stale version. > > Signed-off-by: Thomas Hellstr=C3=B6m Reviewed-by: Matthew Auld From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3180FC11F65 for ; Wed, 30 Jun 2021 14:44:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E309061396 for ; Wed, 30 Jun 2021 14:44:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E309061396 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8A7D66E9ED; Wed, 30 Jun 2021 14:44:27 +0000 (UTC) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by gabe.freedesktop.org (Postfix) with ESMTPS id 929B56E9ED; Wed, 30 Jun 2021 14:44:26 +0000 (UTC) Received: by mail-qk1-x729.google.com with SMTP id g4so2686096qkl.1; Wed, 30 Jun 2021 07:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=2et4KT8L7jP1mpy1oRnNKAxEFKAA245RyizNmHQJu0A=; b=ni5kdzxQso5O4x03O43MLQ5luCngKEGnziDGHOwB0BDqj2w8T0yFdCUnfEBkT4LhU5 3Co387LUv4yL5KexqbyNYo9fqQAKxKW+eSWS2hXAtc90q06oIC0oU1chVz9C4lSy/lLF /OQMjJHw+qbNSH2jgo99F3czxlceRMq3FZczu67/wzqCYI2l2eNTsoyzQ/Ka7BDShFw/ KCUkEcOmWzAkFxn73PqFcRzR1lU9HsFozhbKhiuMnHVQ2tlDtoLcyqjWPn9W5OToIJAT xxQR1aNiVvNRan1AacNShdz6qjDx1O/gdVc5+tMDkF5Og6nGNcXLk+booiS89NkiUMZO Rocw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=2et4KT8L7jP1mpy1oRnNKAxEFKAA245RyizNmHQJu0A=; b=LgNOL+oW2pgREMzrc76irPvu90QbY6bML73/unIvpkMZsrco5utS3BP152A2h2SKh+ va/mfm56FtNsJ5bz8AbC2hRK6bWBVLfAotk7fgkfzuImbgVlebPiFlWBEwzbn1bEb7N3 Y0ZHKghmqzxuP4C2U4KJLMYTeUHJE+OMoA6a9345MFb/9iI6GDyz3aiXZZjRkppWWKng MK2HEzD2upRDanrIqDdYnNug6kLYJ3unWSixOvisg5+wev6jI+wraHtHiZMNPptxOngo Aksq4BMDs5+A2DrQ/MNuGbdm0g7fAhrTjMWwi7WNj8qvxRoQcvN0mC5N0qDMgQpArkh3 Mrlg== X-Gm-Message-State: AOAM533KMsuHPb1I3ZHh+jjNVQGefIMl2dTKBn0poR/idfWUK2xQ2fz6 OWBRDjpRZIu4cZz6liLJ8VF5b+URQ1OVLLXlU5E= X-Google-Smtp-Source: ABdhPJxiK8zCjwPamhLlfl78bsXkHxIX+9Bmr6sCiaks76JUqJN6r0IHzYOIK1vmUJVT9klXzcEEbEFUWmdzUq/ush0= X-Received: by 2002:a37:b1c3:: with SMTP id a186mr37560568qkf.17.1625064265801; Wed, 30 Jun 2021 07:44:25 -0700 (PDT) MIME-Version: 1.0 References: <20210624193045.5087-1-thomas.hellstrom@linux.intel.com> <20210624193045.5087-3-thomas.hellstrom@linux.intel.com> In-Reply-To: <20210624193045.5087-3-thomas.hellstrom@linux.intel.com> From: Matthew Auld Date: Wed, 30 Jun 2021 15:43:59 +0100 Message-ID: To: =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= Subject: Re: [Intel-gfx] [PATCH 2/2] drm/ttm, drm/i915: Update ttm_move_memcpy for async use X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Development , Matthew Auld , ML dri-devel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gVGh1LCAyNCBKdW4gMjAyMSBhdCAyMDozMSwgVGhvbWFzIEhlbGxzdHLDtm0KPHRob21hcy5o ZWxsc3Ryb21AbGludXguaW50ZWwuY29tPiB3cm90ZToKPgo+IFRoZSBidWZmZXIgb2JqZWN0IGFy Z3VtZW50IHRvIHR0bV9tb3ZlX21lbWNweSB3YXMgb25seSB1c2VkIHRvCj4gZGV0ZXJtaW5lIHdo ZXRoZXIgdGhlIGRlc3RpbmF0aW9uIG1lbW9yeSBzaG91bGQgYmUgY2xlYXJlZCBvbmx5Cj4gb3Ig d2hldGhlciB3ZSBzaG91bGQgY29weSBkYXRhLiBSZXBsYWNlIGl0IHdpdGggYSAiY2xlYXIiIGJv b2wsIGFuZAo+IHVwZGF0ZSB0aGUgY2FsbGVycy4KPgo+IFRoZSBpbnRlbnRpb24gaGVyZSBpcyB0 byBiZSBhYmxlIHRvIHVzZSB0dG1fbW92ZV9tZW1jcHkoKSBhc3luYyB1bmRlcgo+IGEgZG1hLWZl bmNlIGFzIGEgZmFsbGJhY2sgaWYgYW4gYWNjZWxlcmF0ZWQgYmxpdCBmYWlscyBpbiBhIHNlY3Vy aXR5LQo+IGNyaXRpY2FsIHBhdGggd2hlcmUgZGF0YSBtaWdodCBsZWFrIGlmIHRoZSBibGl0IGlz IG5vdCBwcm9wZXJseQo+IHBlcmZvcm1lZC4gRm9yIHRoYXQgcHVycG9zZSB0aGUgYm8gaXMgYW4g dW5zdWl0YWJsZSBhcmd1bWVudCBzaW5jZQo+IGl0cyByZWxldmFudCBtZW1iZXJzIG1pZ2h0IGFs cmVhZHkgaGF2ZSBjaGFuZ2VkIGF0IGNhbGwgdGltZS4KPgo+IEZpbmFsbHksIHVwZGF0ZSB0aGUg dHRtX21vdmVfbWVtY3B5IGtlcm5lbGRvYyB0aGF0IHNlZW1zIHRvIGhhdmUKPiBlbmRlZCB1cCB3 aXRoIGEgc3RhbGUgdmVyc2lvbi4KPgo+IFNpZ25lZC1vZmYtYnk6IFRob21hcyBIZWxsc3Ryw7Zt IDx0aG9tYXMuaGVsbHN0cm9tQGxpbnV4LmludGVsLmNvbT4KUmV2aWV3ZWQtYnk6IE1hdHRoZXcg QXVsZCA8bWF0dGhldy5hdWxkQGludGVsLmNvbT4KX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg==