From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthew Auld <matthew.william.auld@gmail.com>
Subject: Re: [PATCH] drm/i915/gtt: Allow mixed pages to setup
 large PTE
Date: Fri, 26 Oct 2018 20:27:46 +0100
Message-ID: <CAM0jSHNi-jKqQgz9-+XMv0PkFedOMAmM3SEQ2sKOpkyTdSNF7w@mail.gmail.com>
References: <20181026120422.18647-1-chris@chris-wilson.co.uk>
 <20181026145811.24638-1-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ua1-x942.google.com (mail-ua1-x942.google.com
 [IPv6:2607:f8b0:4864:20::942])
 by gabe.freedesktop.org (Postfix) with ESMTPS id C217F6E53D
 for <intel-gfx@lists.freedesktop.org>; Fri, 26 Oct 2018 19:28:14 +0000 (UTC)
Received: by mail-ua1-x942.google.com with SMTP id o17so771415uad.8
 for <intel-gfx@lists.freedesktop.org>; Fri, 26 Oct 2018 12:28:14 -0700 (PDT)
In-Reply-To: <20181026145811.24638-1-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Matthew Auld <matthew.auld@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCAyNiBPY3QgMjAxOCBhdCAxNjoxNiwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13
aWxzb24uY28udWs+IHdyb3RlOgo+Cj4gRm9yIGV4YW1wbGUsIHdlIG1heSB3YW50IHRvIHNwbGl0
IGEgMk1pQiBsYXJnZSBwYWdlIGludG8gbXVsdGlwbGUgNjRLaUIKPiBQVEVzLiBUbyBkbyBzbywg
d2Ugd2FudCB0byBhbGxvdyBhIHZtYSB0aGF0IG9ubHkgaGFzIHRoZSAyTWlCIGZsYWcgc2V0Cj4g
dG8gdXRpbGlzZSB0aGUgNjRLaUIgYXMgcmVxdWlyZWQsIGkuZS4gd2Ugd2FudCB0byBpbmNsdWRl
IGFsbCBsYXJnZXIKPiBwYWdlcyBhcyB3ZWxsLgoKSSB0aG91Z2h0IGlmIHdlIGhhdmUgdm1hIHRo
YXQgb25seSBoYXMgdGhlIDJNIGZsYWcsIHRoYXQgY2FuIG9ubHkgbWVhbgp0aGF0IDY0SyBpcyBu
b3Qgc3VwcG9ydGVkIGJ5IHRoZSBwbGF0Zm9ybT8KCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBX
aWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogTWF0dGhldyBBdWxkIDxtYXR0
aGV3LmF1bGRAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl
bV9ndHQuYyAgICAgICAgIHwgIDQgKystLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVz
dHMvaHVnZV9wYWdlcy5jIHwgMTcgKysrKysrKysrKystLS0tLS0KPiAgMiBmaWxlcyBjaGFuZ2Vk
LCAxMyBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx
NV9nZW1fZ3R0LmMKPiBpbmRleCAxOWIyZDk5MWI1ZDguLjllMTc1NjIxNmFkYSAxMDA2NDQKPiAt
LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+ICsrKyBiL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4gQEAgLTEwNzQsNyArMTA3NCw3IEBAIHN0YXRp
YyB2b2lkIGdlbjhfcHBndHRfaW5zZXJ0X2h1Z2VfZW50cmllcyhzdHJ1Y3QgaTkxNV92bWEgKnZt
YSwKPiAgICAgICAgICAgICAgICAgZ2VuOF9wdGVfdCAqdmFkZHI7Cj4gICAgICAgICAgICAgICAg
IHUxNiBpbmRleCwgbWF4Owo+Cj4gLSAgICAgICAgICAgICAgIGlmICh2bWEtPnBhZ2Vfc2l6ZXMu
c2cgJiBJOTE1X0dUVF9QQUdFX1NJWkVfMk0gJiYKPiArICAgICAgICAgICAgICAgaWYgKHZtYS0+
cGFnZV9zaXplcy5zZyAmIC1JOTE1X0dUVF9QQUdFX1NJWkVfMk0gJiYKPiAgICAgICAgICAgICAg
ICAgICAgIElTX0FMSUdORUQoaXRlci0+ZG1hLCBJOTE1X0dUVF9QQUdFX1NJWkVfMk0pICYmCj4g
ICAgICAgICAgICAgICAgICAgICByZW0gPj0gSTkxNV9HVFRfUEFHRV9TSVpFXzJNICYmICFpZHgu
cHRlKSB7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgaW5kZXggPSBpZHgucGRlOwo+IEBAIC0x
MDkyLDcgKzEwOTIsNyBAQCBzdGF0aWMgdm9pZCBnZW44X3BwZ3R0X2luc2VydF9odWdlX2VudHJp
ZXMoc3RydWN0IGk5MTVfdm1hICp2bWEsCj4gICAgICAgICAgICAgICAgICAgICAgICAgcGFnZV9z
aXplID0gSTkxNV9HVFRfUEFHRV9TSVpFOwo+Cj4gICAgICAgICAgICAgICAgICAgICAgICAgaWYg
KCFpbmRleCAmJgo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICB2bWEtPnBhZ2Vfc2l6ZXMu
c2cgJiBJOTE1X0dUVF9QQUdFX1NJWkVfNjRLICYmCj4gKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgIHZtYS0+cGFnZV9zaXplcy5zZyAmIC1JOTE1X0dUVF9QQUdFX1NJWkVfNjRLICYmCgpZZWFo
LCBzbyBoZXJlIHdoYXQgaWYgdGhlIHBsYXRmb3JtIGRvZXNuJ3Qgc3VwcG9ydCA2NEsgcGFnZXMs
IGJ1dCBkb2VzCnN1cHBvcnQgc2F5IDJNLCBhbmQgdGhlIG9iamVjdCBpcyAyTSArIDY0SyBvciBw
ZXJoYXBzIGl0J3MgMk0gYnV0CnNvbWVob3cgb25seSBhbGlnbmVkIHRvIDY0Sz8gSSB0aGluayB3
ZSBleGVyY2lzZSBzb21ldGhpbmcgbGlrZSB0aGF0CmZvciB0aGUgbW9jayBkZXZpY2UsIG9yIGF0
IGxlYXN0IEkgaG9wZSB3ZSBkby4KCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgIElTX0FM
SUdORUQoaXRlci0+ZG1hLCBJOTE1X0dUVF9QQUdFX1NJWkVfNjRLKSAmJgo+ICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAoSVNfQUxJR05FRChyZW0sIEk5MTVfR1RUX1BBR0VfU0laRV82NEsp
IHx8Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZW0gPj0gKG1heCAtIGluZGV4KSAq
IEk5MTVfR1RUX1BBR0VfU0laRSkpCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L3NlbGZ0ZXN0cy9odWdlX3BhZ2VzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMv
aHVnZV9wYWdlcy5jCj4gaW5kZXggMjU2MDAxYjAwZTMyLi4yZDY2ZjM4MGFkOWEgMTAwNjQ0Cj4g
LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2h1Z2VfcGFnZXMuYwo+ICsrKyBi
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9odWdlX3BhZ2VzLmMKPiBAQCAtNTA4LDYg
KzUwOCw3IEBAIHN0YXRpYyBpbnQgaWd0X21vY2tfcHBndHRfbWlzYWxpZ25lZF9kbWEodm9pZCAq
YXJnKQo+ICAgICAgICAgICAgICAgICAgICAgICAgIGdvdG8gb3V0X3VucGluOwo+ICAgICAgICAg
ICAgICAgICB9Cj4KPiArICAgICAgICAgICAgICAgR0VNX0JVR19PTih2bWEtPnBhZ2Vfc2l6ZXMu
Z3R0KTsKPiAgICAgICAgICAgICAgICAgZXJyID0gaTkxNV92bWFfcGluKHZtYSwgMCwgMCwgZmxh
Z3MpOwo+ICAgICAgICAgICAgICAgICBpZiAoZXJyKSB7Cj4gICAgICAgICAgICAgICAgICAgICAg
ICAgaTkxNV92bWFfY2xvc2Uodm1hKTsKPiBAQCAtNTE3LDggKzUxOCw5IEBAIHN0YXRpYyBpbnQg
aWd0X21vY2tfcHBndHRfbWlzYWxpZ25lZF9kbWEodm9pZCAqYXJnKQo+Cj4gICAgICAgICAgICAg
ICAgIGVyciA9IGlndF9jaGVja19wYWdlX3NpemVzKHZtYSk7Cj4KPiAtICAgICAgICAgICAgICAg
aWYgKHZtYS0+cGFnZV9zaXplcy5ndHQgIT0gcGFnZV9zaXplKSB7Cj4gLSAgICAgICAgICAgICAg
ICAgICAgICAgcHJfZXJyKCJwYWdlX3NpemVzLmd0dD0ldSwgZXhwZWN0ZWQgJXVcbiIsCj4gKyAg
ICAgICAgICAgICAgIGlmICghKHZtYS0+cGFnZV9zaXplcy5ndHQgJiAtcGFnZV9zaXplKSkgewo+
ICsgICAgICAgICAgICAgICAgICAgICAgIHByX2VycigiJXM6JWQgcGFnZV9zaXplcy5ndHQ9JXUs
IGV4cGVjdGVkICV1XG4iLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfX2Z1bmNf
XywgX19MSU5FX18sCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZtYS0+cGFnZV9z
aXplcy5ndHQsIHBhZ2Vfc2l6ZSk7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgZXJyID0gLUVJ
TlZBTDsKPiAgICAgICAgICAgICAgICAgfQo+IEBAIC01NDIsNiArNTQ0LDcgQEAgc3RhdGljIGlu
dCBpZ3RfbW9ja19wcGd0dF9taXNhbGlnbmVkX2RtYSh2b2lkICphcmcpCj4gICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBnb3RvIG91dF91bnBpbjsKPiAgICAgICAgICAgICAgICAgICAg
ICAgICB9Cj4KPiArICAgICAgICAgICAgICAgICAgICAgICBHRU1fQlVHX09OKHZtYS0+cGFnZV9z
aXplcy5ndHQpOwo+ICAgICAgICAgICAgICAgICAgICAgICAgIGVyciA9IGk5MTVfdm1hX3Bpbih2
bWEsIDAsIDAsIGZsYWdzIHwgb2Zmc2V0KTsKPiAgICAgICAgICAgICAgICAgICAgICAgICBpZiAo
ZXJyKSB7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpOTE1X3ZtYV9jbG9zZSh2
bWEpOwo+IEBAIC01NTAsOCArNTUzLDkgQEAgc3RhdGljIGludCBpZ3RfbW9ja19wcGd0dF9taXNh
bGlnbmVkX2RtYSh2b2lkICphcmcpCj4KPiAgICAgICAgICAgICAgICAgICAgICAgICBlcnIgPSBp
Z3RfY2hlY2tfcGFnZV9zaXplcyh2bWEpOwo+Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgaWYg
KHZtYS0+cGFnZV9zaXplcy5ndHQgIT0gSTkxNV9HVFRfUEFHRV9TSVpFXzRLKSB7Cj4gLSAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBwcl9lcnIoInBhZ2Vfc2l6ZXMuZ3R0PSV1LCBleHBl
Y3RlZCAlbGx1XG4iLAo+ICsgICAgICAgICAgICAgICAgICAgICAgIGlmICghKHZtYS0+cGFnZV9z
aXplcy5ndHQgJiAtSTkxNV9HVFRfUEFHRV9TSVpFXzRLKSkgewo+ICsgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgcHJfZXJyKCIlczolZCBwYWdlX3NpemVzLmd0dD0ldSwgZXhwZWN0ZWQg
JWxsdVxuIiwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBfX2Z1bmNfXywgX19MSU5FX18sCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgdm1hLT5wYWdlX3NpemVzLmd0dCwgSTkxNV9HVFRfUEFHRV9TSVpFXzRLKTsKPiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVyciA9IC1FSU5WQUw7Cj4gICAgICAgICAgICAg
ICAgICAgICAgICAgfQo+IEBAIC0xNDcxLDcgKzE0NzUsNyBAQCBzdGF0aWMgaW50IGlndF9wcGd0
dF9waW5fdXBkYXRlKHZvaWQgKmFyZykKPiAgICAgICAgICAgICAgICAgaWYgKGVycikKPiAgICAg
ICAgICAgICAgICAgICAgICAgICBnb3RvIG91dF91bnBpbjsKPgo+IC0gICAgICAgICAgICAgICBp
ZiAodm1hLT5wYWdlX3NpemVzLmd0dCAhPSBwYWdlX3NpemUpIHsKPiArICAgICAgICAgICAgICAg
aWYgKCEodm1hLT5wYWdlX3NpemVzLmd0dCAmIC1wYWdlX3NpemUpKSB7Cj4gICAgICAgICAgICAg
ICAgICAgICAgICAgZG1hX2FkZHJfdCBhZGRyID0gaTkxNV9nZW1fb2JqZWN0X2dldF9kbWFfYWRk
cmVzcyhvYmosIDApOwo+Cj4gICAgICAgICAgICAgICAgICAgICAgICAgLyoKPiBAQCAtMTQ4MSw3
ICsxNDg1LDggQEAgc3RhdGljIGludCBpZ3RfcHBndHRfcGluX3VwZGF0ZSh2b2lkICphcmcpCj4g
ICAgICAgICAgICAgICAgICAgICAgICAgICogYWRkcmVzcy4KPiAgICAgICAgICAgICAgICAgICAg
ICAgICAgKi8KPiAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoSVNfQUxJR05FRChhZGRyLCBw
YWdlX3NpemUpKSB7Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwcl9lcnIoInBh
Z2Vfc2l6ZXMuZ3R0PSV1LCBleHBlY3RlZD0ldVxuIiwKPiArICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIHByX2VycigiJXM6JWQgcGFnZV9zaXplcy5ndHQ9JXUsIGV4cGVjdGVkPSV1XG4i
LAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF9fZnVu
Y19fLCBfX0xJTkVfXywKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2
bWEtPnBhZ2Vfc2l6ZXMuZ3R0LCBwYWdlX3NpemUpOwo+ICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgZXJyID0gLUVJTlZBTDsKPiAgICAgICAgICAgICAgICAgICAgICAgICB9IGVsc2Ug
ewo+IC0tCj4gMi4xOS4xCj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJl
ZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0
aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au
b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt
Z2Z4Cg==