From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06C88C12002 for ; Fri, 16 Jul 2021 19:22:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0000613FB for ; Fri, 16 Jul 2021 19:22:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0000613FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D3EC26E9CC; Fri, 16 Jul 2021 19:22:03 +0000 (UTC) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by gabe.freedesktop.org (Postfix) with ESMTPS id C5A476E9CC; Fri, 16 Jul 2021 19:22:02 +0000 (UTC) Received: by mail-qt1-x82d.google.com with SMTP id c13so5263283qtc.10; Fri, 16 Jul 2021 12:22:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LYbgDMubYjaOILeRYFVTGYoETdYeGIpoH+k6mQhBBf8=; b=bDYyf1zW6NCivkz29qgaU27ZGOXfTZ0gjTU888kkE/miCdnGUibSBlnJYov8EMrvt/ 1kpozBNdDDmZlzNYpjOEZXOfGAVeh+SvK9lBgqpFZqZ0xeb8nla6vrQXlIOl7UmR05ZU QeJQlPS/H1nHwrCZ337l02C9j3MZhEA+cy6nmSPlR4atuEtlBZxasi6a9OeGY2vZHFu1 mq38Ea/o6fxn3e3jg2pp6R8VMq2De7iyfDeOW57r+PiopbI2JWv+MhUGAXaKJbXi7hBg 6Cer1h6e7suMo+jXfC3g7kYgfcPKpa7xlblW/E76TMBAAw8jngfBpRwo0R8FDgkTlxus EMQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LYbgDMubYjaOILeRYFVTGYoETdYeGIpoH+k6mQhBBf8=; b=rJwX8ucqvLKC+oPpEZbYCzT4qnyiii8DwZx3cKNcjdkPprtSW/9947Vyuy+kg/arX6 vbMATn2ofliaUQp8E4dmxHHCqpW5ppeoVBrFLyEf/ipl/MS8CCFyJbxZeTGvwKr04r0L iQ+PBhArrWNuaXEvmv+G3jihQRh6gI5SDfEz8GVWs4lY7+u2TbghjZwE3S/DcUHnoDgE htMDZLLzwHOi9SBaj7yJA/dXUw1JxFUGMbHWY5QFMINNM42EFLutSJg/xF7mwnRRc8rc 8Mg/8lOKjy/foOFgNTMQFsTJzuATm49i8OTX/QcvVPfUvh68Na2lyWUsrqAoARVK8yeN bv5A== X-Gm-Message-State: AOAM533ZHhUflVp2/bdQ88UxRIgF55KX0719bdC3+c0PgwlRFI9gIT/s Djp4OAtvMiU8SLjn2+0mLG4mviP4jqgJ+q4JOLU= X-Google-Smtp-Source: ABdhPJwGXhHkzSpZuAdMEOCEIxPwQOltOSLhrzYft29ADAbdwldzTCLMDyN5jcTC48j9ZB/1rTu2+Otat6cDLW+yoys= X-Received: by 2002:ac8:5c8c:: with SMTP id r12mr10542253qta.265.1626463321991; Fri, 16 Jul 2021 12:22:01 -0700 (PDT) MIME-Version: 1.0 References: <20210716141426.1904528-1-jason@jlekstrand.net> <20210716141426.1904528-5-jason@jlekstrand.net> In-Reply-To: <20210716141426.1904528-5-jason@jlekstrand.net> From: Matthew Auld Date: Fri, 16 Jul 2021 20:21:36 +0100 Message-ID: Subject: Re: [Intel-gfx] [PATCH 4/7] drm/i915/gem: Unify user object creation (v2) To: Jason Ekstrand Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Development , Matthew Auld , ML dri-devel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 16 Jul 2021 at 15:14, Jason Ekstrand wrote: > > Instead of hand-rolling the same three calls in each function, pull them > into an i915_gem_object_create_user helper. Apart from re-ordering of > the placements array ENOMEM check, there should be no functional change. > > v2 (Matthew Auld): > - Add the call to i915_gem_flush_free_objects() from > i915_gem_dumb_create() in a separate patch > - Move i915_gem_object_alloc() below the simple error checks > > Signed-off-by: Jason Ekstrand > Cc: Matthew Auld If CI is happy, Reviewed-by: Matthew Auld From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB01FC636CA for ; Fri, 16 Jul 2021 19:22:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6B3F613FB for ; Fri, 16 Jul 2021 19:22:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6B3F613FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1EE976E9CF; Fri, 16 Jul 2021 19:22:04 +0000 (UTC) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by gabe.freedesktop.org (Postfix) with ESMTPS id C5A476E9CC; Fri, 16 Jul 2021 19:22:02 +0000 (UTC) Received: by mail-qt1-x82d.google.com with SMTP id c13so5263283qtc.10; Fri, 16 Jul 2021 12:22:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LYbgDMubYjaOILeRYFVTGYoETdYeGIpoH+k6mQhBBf8=; b=bDYyf1zW6NCivkz29qgaU27ZGOXfTZ0gjTU888kkE/miCdnGUibSBlnJYov8EMrvt/ 1kpozBNdDDmZlzNYpjOEZXOfGAVeh+SvK9lBgqpFZqZ0xeb8nla6vrQXlIOl7UmR05ZU QeJQlPS/H1nHwrCZ337l02C9j3MZhEA+cy6nmSPlR4atuEtlBZxasi6a9OeGY2vZHFu1 mq38Ea/o6fxn3e3jg2pp6R8VMq2De7iyfDeOW57r+PiopbI2JWv+MhUGAXaKJbXi7hBg 6Cer1h6e7suMo+jXfC3g7kYgfcPKpa7xlblW/E76TMBAAw8jngfBpRwo0R8FDgkTlxus EMQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LYbgDMubYjaOILeRYFVTGYoETdYeGIpoH+k6mQhBBf8=; b=rJwX8ucqvLKC+oPpEZbYCzT4qnyiii8DwZx3cKNcjdkPprtSW/9947Vyuy+kg/arX6 vbMATn2ofliaUQp8E4dmxHHCqpW5ppeoVBrFLyEf/ipl/MS8CCFyJbxZeTGvwKr04r0L iQ+PBhArrWNuaXEvmv+G3jihQRh6gI5SDfEz8GVWs4lY7+u2TbghjZwE3S/DcUHnoDgE htMDZLLzwHOi9SBaj7yJA/dXUw1JxFUGMbHWY5QFMINNM42EFLutSJg/xF7mwnRRc8rc 8Mg/8lOKjy/foOFgNTMQFsTJzuATm49i8OTX/QcvVPfUvh68Na2lyWUsrqAoARVK8yeN bv5A== X-Gm-Message-State: AOAM533ZHhUflVp2/bdQ88UxRIgF55KX0719bdC3+c0PgwlRFI9gIT/s Djp4OAtvMiU8SLjn2+0mLG4mviP4jqgJ+q4JOLU= X-Google-Smtp-Source: ABdhPJwGXhHkzSpZuAdMEOCEIxPwQOltOSLhrzYft29ADAbdwldzTCLMDyN5jcTC48j9ZB/1rTu2+Otat6cDLW+yoys= X-Received: by 2002:ac8:5c8c:: with SMTP id r12mr10542253qta.265.1626463321991; Fri, 16 Jul 2021 12:22:01 -0700 (PDT) MIME-Version: 1.0 References: <20210716141426.1904528-1-jason@jlekstrand.net> <20210716141426.1904528-5-jason@jlekstrand.net> In-Reply-To: <20210716141426.1904528-5-jason@jlekstrand.net> From: Matthew Auld Date: Fri, 16 Jul 2021 20:21:36 +0100 Message-ID: To: Jason Ekstrand Subject: Re: [Intel-gfx] [PATCH 4/7] drm/i915/gem: Unify user object creation (v2) X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Development , Matthew Auld , ML dri-devel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 16 Jul 2021 at 15:14, Jason Ekstrand wrote: > > Instead of hand-rolling the same three calls in each function, pull them > into an i915_gem_object_create_user helper. Apart from re-ordering of > the placements array ENOMEM check, there should be no functional change. > > v2 (Matthew Auld): > - Add the call to i915_gem_flush_free_objects() from > i915_gem_dumb_create() in a separate patch > - Move i915_gem_object_alloc() below the simple error checks > > Signed-off-by: Jason Ekstrand > Cc: Matthew Auld If CI is happy, Reviewed-by: Matthew Auld _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx