From: Matthew Auld <matthew.william.auld@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Matthew Auld <matthew.auld@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Hold rpm wakeref before taking ggtt->vm.mutex
Date: Fri, 10 Jan 2020 17:08:05 +0000 [thread overview]
Message-ID: <CAM0jSHNrzBuhZvKVLB-+C5PL5q_-+N8w1sUN+bP2_w4WJbjRNg@mail.gmail.com> (raw)
In-Reply-To: <20200110144418.1415639-1-chris@chris-wilson.co.uk>
On Fri, 10 Jan 2020 at 14:44, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> We need to hold the runtime-pm wakeref to update the global PTEs (as
> they exist behind a PCI BAR). However, some systems invoke ACPI during
> runtime resume and so require allocations, which is verboten inside the
> vm->mutex. Ergo, we must not use intel_runtime_pm_get() inside the
> mutex, but lift the call outside.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/issues/958
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-10 17:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 14:44 [Intel-gfx] [PATCH] drm/i915/gt: Hold rpm wakeref before taking ggtt->vm.mutex Chris Wilson
2020-01-10 17:08 ` Matthew Auld [this message]
2020-01-10 20:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-14 13:29 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM0jSHNrzBuhZvKVLB-+C5PL5q_-+N8w1sUN+bP2_w4WJbjRNg@mail.gmail.com \
--to=matthew.william.auld@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.