All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.william.auld@gmail.com>
To: Robert Bragg <robert@sixbynine.org>
Cc: David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Sourab Gupta <sourab.gupta@intel.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v5 10/11] drm/i915: Add more Haswell OA metric sets
Date: Fri, 7 Oct 2016 18:22:56 +0100	[thread overview]
Message-ID: <CAM0jSHO=QWy3s3Fg_EO2V6HQ+4pMpH2EuGw1tbG8+eSsB-5t_A@mail.gmail.com> (raw)
In-Reply-To: <20160914141949.27402-11-robert@sixbynine.org>

On 14 September 2016 at 15:19, Robert Bragg <robert@sixbynine.org> wrote:
> This adds 'compute', 'compute extended', 'memory reads', 'memory writes'
> and 'sampler balance' metric sets for Haswell.
>
> The code is auto generated from an XML description of metric sets,
> currently maintained in gputop, ref:
>
>  https://github.com/rib/gputop
>  > gputop-data/oa-*.xml
>  > scripts/i915-perf-kernelgen.py
>
>  $ make -C gputop-data -f Makefile.xml
>
> Signed-off-by: Robert Bragg <robert@sixbynine.org>
> ---
>  drivers/gpu/drm/i915/i915_oa_hsw.c | 559 ++++++++++++++++++++++++++++++++++++-
>  1 file changed, 558 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_oa_hsw.c b/drivers/gpu/drm/i915/i915_oa_hsw.c
> index 656334d..7906a26 100644
> --- a/drivers/gpu/drm/i915/i915_oa_hsw.c
> +++ b/drivers/gpu/drm/i915/i915_oa_hsw.c
> @@ -30,9 +30,14 @@
>
>  enum metric_set_id {
>         METRIC_SET_ID_RENDER_BASIC = 1,
> +       METRIC_SET_ID_COMPUTE_BASIC,
> +       METRIC_SET_ID_COMPUTE_EXTENDED,
> +       METRIC_SET_ID_MEMORY_READS,
> +       METRIC_SET_ID_MEMORY_WRITES,
> +       METRIC_SET_ID_SAMPLER_BALANCE,
>  };
>
> -int i915_oa_n_builtin_metric_sets_hsw = 1;
> +int i915_oa_n_builtin_metric_sets_hsw = 6;
You didn't fancy having a METRIC_SET_ID_MAX?

Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-10-07 17:22 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-14 14:19 [PATCH v5 00/11] Enable i915 perf stream for Haswell OA unit Robert Bragg
2016-09-14 14:19 ` [PATCH v5 01/11] drm/i915: Add i915 perf infrastructure Robert Bragg
2016-09-14 14:42   ` [Intel-gfx] " Emil Velikov
2016-09-14 15:02     ` Robert Bragg
2016-09-14 15:32     ` [PATCH] " Robert Bragg
2016-10-07 17:10       ` Matthew Auld
2016-10-11 19:03         ` [Intel-gfx] " Robert Bragg
2016-10-12 11:41           ` Joonas Lahtinen
2016-10-19 16:35             ` Robert Bragg
2016-10-20 15:19               ` [Intel-gfx] " Joonas Lahtinen
2016-09-14 14:19 ` [PATCH v5 02/11] drm/i915: rename OACONTROL GEN7_OACONTROL Robert Bragg
2016-10-07 17:11   ` Matthew Auld
2016-09-14 14:19 ` [PATCH v5 03/11] drm/i915: return EACCES for check_cmd() failures Robert Bragg
2016-09-14 14:19 ` [PATCH v5 04/11] drm/i915: don't whitelist oacontrol in cmd parser Robert Bragg
2016-09-14 14:19 ` [PATCH v5 05/11] drm/i915: Add 'render basic' Haswell OA unit config Robert Bragg
2016-10-07 17:15   ` Matthew Auld
2016-09-14 14:19 ` [PATCH v5 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit Robert Bragg
2016-10-07 17:19   ` Matthew Auld
2016-10-12  0:55     ` Robert Bragg
2016-09-14 14:19 ` [PATCH v5 07/11] drm/i915: advertise available metrics via sysfs Robert Bragg
2016-10-07 17:20   ` Matthew Auld
2016-09-14 14:19 ` [PATCH v5 08/11] drm/i915: Add dev.i915.perf_event_paranoid sysctl option Robert Bragg
2016-10-07 17:21   ` Matthew Auld
2016-09-14 14:19 ` [PATCH v5 09/11] drm/i915: add oa_event_min_timer_exponent sysctl Robert Bragg
2016-10-07 17:21   ` Matthew Auld
2016-09-14 14:19 ` [PATCH v5 10/11] drm/i915: Add more Haswell OA metric sets Robert Bragg
2016-10-07 17:22   ` Matthew Auld [this message]
2016-09-14 14:19 ` [PATCH v5 11/11] drm/i915: Add a kerneldoc summary for i915_perf.c Robert Bragg
2016-10-07 17:24   ` Matthew Auld
2016-09-14 14:50 ` ✗ Fi.CI.BAT: failure for Enable i915 perf stream for Haswell OA unit (rev3) Patchwork
2016-09-14 16:19 ` ✗ Fi.CI.BAT: failure for Enable i915 perf stream for Haswell OA unit (rev4) Patchwork
2016-09-15  7:20 ` ✗ Fi.CI.BAT: failure for Enable i915 perf stream for Haswell OA unit (rev3) Patchwork
2016-09-15  7:20 ` ✗ Fi.CI.BAT: failure for Enable i915 perf stream for Haswell OA unit (rev4) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM0jSHO=QWy3s3Fg_EO2V6HQ+4pMpH2EuGw1tbG8+eSsB-5t_A@mail.gmail.com' \
    --to=matthew.william.auld@gmail.com \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=robert@sixbynine.org \
    --cc=sourab.gupta@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.