From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A59DDC48BCD for ; Tue, 8 Jun 2021 17:06:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EF556128A for ; Tue, 8 Jun 2021 17:06:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EF556128A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 95B396E203; Tue, 8 Jun 2021 17:06:04 +0000 (UTC) Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E48E6E1F7; Tue, 8 Jun 2021 17:06:03 +0000 (UTC) Received: by mail-qv1-xf34.google.com with SMTP id x2so10516599qvo.8; Tue, 08 Jun 2021 10:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=EoJCPJeppcrfpor3LbZM2DRcMtWosmdzMRz51+rh2XU=; b=GvUxCEN12JOoAjOqV929Kwlx26hCldND/Ini+4Dz175Gx9RKJu3J8XZgpFFGRhxP8E rplbjRbxfGymXfXRxpxQgI7RYoRVA+OjDKYg/OZFVUse474g0wIa+Apg9xPa3UmUcVWr dW2jygpb8pHSxZSHr0c5gelAe8LpDTyH5WKpweRdOhmXQ9okYajkEXSTVaxIzEciwl1I byWbAXxpDUUf0ytSKnPyvuyKj833oX35tuTt+mdZ3XVFZV+Q3lNIxvhWob9IW2jNqUSL 3Hbs0Au78YhzspCYudHIMEjvYy+qtnovytgRxv88PjROyWnhLECi54fI4pZHNwazCeyH qGzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=EoJCPJeppcrfpor3LbZM2DRcMtWosmdzMRz51+rh2XU=; b=IfwWmYiX3yZk/HyfiGkr55nuVvuCgPLOTHP3zIAytSnT2Q4NWiEzxy5MSKfIhEqoyd 6Rn4MVissTrTLmJJyHwuFKX+JVZV9TzfUGlCBeuBhUnFUw+/jWmtaRbt6fLqNqL3twPr ztpCHqOrvIAaX8VYZgAXb/7VWJaDRgYFOEbQ9pOb32eKbYiXU9PTEXgs2b0RT6XNEWZP 9IgV5wCIcmayN9HoM3Adkh36tSmxvaiWHtBx5SfOeS+7Ov6i0UlcfAvNMu337xmkALmp EG20MWUxmAHEyICVBNY6o82h1pf5x5idgU3OCSDn7QsHFQhL5mDuXEI/ONAe1zT6u90x H+WQ== X-Gm-Message-State: AOAM531m+YS5tmun2sejA58kiV1P2w/jPwGUuIc1rZQ+Cg5hErKBNwxp GZpii0/sgFjAZike57Nj0spqtUbhxIQl1E9lV7U= X-Google-Smtp-Source: ABdhPJzcJvnJcxEeb45p7x85e3PoV0Ay/dRb9l1DCuS3u68nixW2N79wTOlSZIbbyrRvnpedbfQA/7UjC1XwWDhFX1o= X-Received: by 2002:ad4:5fc7:: with SMTP id jq7mr1072641qvb.41.1623171962296; Tue, 08 Jun 2021 10:06:02 -0700 (PDT) MIME-Version: 1.0 References: <20210608092846.64198-1-thomas.hellstrom@linux.intel.com> <20210608092846.64198-2-thomas.hellstrom@linux.intel.com> In-Reply-To: <20210608092846.64198-2-thomas.hellstrom@linux.intel.com> From: Matthew Auld Date: Tue, 8 Jun 2021 18:05:35 +0100 Message-ID: Subject: Re: [PATCH 1/9] drm/i915: Reference objects on the ww object list To: =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Development , Matthew Auld , ML dri-devel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 8 Jun 2021 at 10:29, Thomas Hellstr=C3=B6m wrote: > > Since the ww transaction endpoint easily end up far out-of-scope of > the objects on the ww object list, particularly for contending lock > objects, make sure we reference objects on the list so they don't > disappear under us. > > This comes with a performance penalty so it's been debated whether this > is really needed. But I think this is motivated by the fact that locking > is typically difficult to get right, and whatever we can do to make it > simpler for developers moving forward should be done, unless the > performance impact is far too high. > > Signed-off-by: Thomas Hellstr=C3=B6m Reviewed-by: Matthew Auld From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37331C47082 for ; Tue, 8 Jun 2021 17:06:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 047146128A for ; Tue, 8 Jun 2021 17:06:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 047146128A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 80D366E1F7; Tue, 8 Jun 2021 17:06:04 +0000 (UTC) Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E48E6E1F7; Tue, 8 Jun 2021 17:06:03 +0000 (UTC) Received: by mail-qv1-xf34.google.com with SMTP id x2so10516599qvo.8; Tue, 08 Jun 2021 10:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=EoJCPJeppcrfpor3LbZM2DRcMtWosmdzMRz51+rh2XU=; b=GvUxCEN12JOoAjOqV929Kwlx26hCldND/Ini+4Dz175Gx9RKJu3J8XZgpFFGRhxP8E rplbjRbxfGymXfXRxpxQgI7RYoRVA+OjDKYg/OZFVUse474g0wIa+Apg9xPa3UmUcVWr dW2jygpb8pHSxZSHr0c5gelAe8LpDTyH5WKpweRdOhmXQ9okYajkEXSTVaxIzEciwl1I byWbAXxpDUUf0ytSKnPyvuyKj833oX35tuTt+mdZ3XVFZV+Q3lNIxvhWob9IW2jNqUSL 3Hbs0Au78YhzspCYudHIMEjvYy+qtnovytgRxv88PjROyWnhLECi54fI4pZHNwazCeyH qGzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=EoJCPJeppcrfpor3LbZM2DRcMtWosmdzMRz51+rh2XU=; b=IfwWmYiX3yZk/HyfiGkr55nuVvuCgPLOTHP3zIAytSnT2Q4NWiEzxy5MSKfIhEqoyd 6Rn4MVissTrTLmJJyHwuFKX+JVZV9TzfUGlCBeuBhUnFUw+/jWmtaRbt6fLqNqL3twPr ztpCHqOrvIAaX8VYZgAXb/7VWJaDRgYFOEbQ9pOb32eKbYiXU9PTEXgs2b0RT6XNEWZP 9IgV5wCIcmayN9HoM3Adkh36tSmxvaiWHtBx5SfOeS+7Ov6i0UlcfAvNMu337xmkALmp EG20MWUxmAHEyICVBNY6o82h1pf5x5idgU3OCSDn7QsHFQhL5mDuXEI/ONAe1zT6u90x H+WQ== X-Gm-Message-State: AOAM531m+YS5tmun2sejA58kiV1P2w/jPwGUuIc1rZQ+Cg5hErKBNwxp GZpii0/sgFjAZike57Nj0spqtUbhxIQl1E9lV7U= X-Google-Smtp-Source: ABdhPJzcJvnJcxEeb45p7x85e3PoV0Ay/dRb9l1DCuS3u68nixW2N79wTOlSZIbbyrRvnpedbfQA/7UjC1XwWDhFX1o= X-Received: by 2002:ad4:5fc7:: with SMTP id jq7mr1072641qvb.41.1623171962296; Tue, 08 Jun 2021 10:06:02 -0700 (PDT) MIME-Version: 1.0 References: <20210608092846.64198-1-thomas.hellstrom@linux.intel.com> <20210608092846.64198-2-thomas.hellstrom@linux.intel.com> In-Reply-To: <20210608092846.64198-2-thomas.hellstrom@linux.intel.com> From: Matthew Auld Date: Tue, 8 Jun 2021 18:05:35 +0100 Message-ID: To: =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= Subject: Re: [Intel-gfx] [PATCH 1/9] drm/i915: Reference objects on the ww object list X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Development , Matthew Auld , ML dri-devel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gVHVlLCA4IEp1biAyMDIxIGF0IDEwOjI5LCBUaG9tYXMgSGVsbHN0csO2bQo8dGhvbWFzLmhl bGxzdHJvbUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+Cj4gU2luY2UgdGhlIHd3IHRyYW5zYWN0 aW9uIGVuZHBvaW50IGVhc2lseSBlbmQgdXAgZmFyIG91dC1vZi1zY29wZSBvZgo+IHRoZSBvYmpl Y3RzIG9uIHRoZSB3dyBvYmplY3QgbGlzdCwgcGFydGljdWxhcmx5IGZvciBjb250ZW5kaW5nIGxv Y2sKPiBvYmplY3RzLCBtYWtlIHN1cmUgd2UgcmVmZXJlbmNlIG9iamVjdHMgb24gdGhlIGxpc3Qg c28gdGhleSBkb24ndAo+IGRpc2FwcGVhciB1bmRlciB1cy4KPgo+IFRoaXMgY29tZXMgd2l0aCBh IHBlcmZvcm1hbmNlIHBlbmFsdHkgc28gaXQncyBiZWVuIGRlYmF0ZWQgd2hldGhlciB0aGlzCj4g aXMgcmVhbGx5IG5lZWRlZC4gQnV0IEkgdGhpbmsgdGhpcyBpcyBtb3RpdmF0ZWQgYnkgdGhlIGZh Y3QgdGhhdCBsb2NraW5nCj4gaXMgdHlwaWNhbGx5IGRpZmZpY3VsdCB0byBnZXQgcmlnaHQsIGFu ZCB3aGF0ZXZlciB3ZSBjYW4gZG8gdG8gbWFrZSBpdAo+IHNpbXBsZXIgZm9yIGRldmVsb3BlcnMg bW92aW5nIGZvcndhcmQgc2hvdWxkIGJlIGRvbmUsIHVubGVzcyB0aGUKPiBwZXJmb3JtYW5jZSBp bXBhY3QgaXMgZmFyIHRvbyBoaWdoLgo+Cj4gU2lnbmVkLW9mZi1ieTogVGhvbWFzIEhlbGxzdHLD tm0gPHRob21hcy5oZWxsc3Ryb21AbGludXguaW50ZWwuY29tPgpSZXZpZXdlZC1ieTogTWF0dGhl dyBBdWxkIDxtYXR0aGV3LmF1bGRAaW50ZWwuY29tPgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK