From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759243AbcGKOoW (ORCPT ); Mon, 11 Jul 2016 10:44:22 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:35775 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759191AbcGKOoS (ORCPT ); Mon, 11 Jul 2016 10:44:18 -0400 MIME-Version: 1.0 In-Reply-To: References: <1467750507-13853-1-git-send-email-a.kesavan@samsung.com> <1467750507-13853-2-git-send-email-a.kesavan@samsung.com> From: Abhilash Kesavan Date: Mon, 11 Jul 2016 16:44:12 +0200 Message-ID: Subject: Re: [PATCH 1/2] soc: samsung: Change type of PMU configuration register value to u32 To: Krzysztof Kozlowski Cc: linux-samsung-soc , linux-arm-kernel , Kukjin Kim , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Wed, Jul 6, 2016 at 8:47 AM, Krzysztof Kozlowski wrote: > On Tue, Jul 5, 2016 at 10:28 PM, Abhilash Kesavan wrote: >> Exynos7 has certain PMU registers that needs to be configured with >> u32 values. >> >> Signed-off-by: Abhilash Kesavan >> --- >> drivers/soc/samsung/exynos-pmu.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/soc/samsung/exynos-pmu.h b/drivers/soc/samsung/exynos-pmu.h >> index a469e36..1bdc506 100644 >> --- a/drivers/soc/samsung/exynos-pmu.h >> +++ b/drivers/soc/samsung/exynos-pmu.h >> @@ -18,7 +18,7 @@ >> >> struct exynos_pmu_conf { >> unsigned int offset; >> - u8 val[NUM_SYS_POWERDOWN]; >> + unsigned int val[NUM_SYS_POWERDOWN]; > > You mentioned u32 but I see unsigned int here. This should be u32. Will change. > > BTW, none of your emails reached my samsung inbox. I got them only > from the lists. Please investigate why this couldn't be delivered to > samsung.com address. Not quite sure why that happened even after I added you as a recipient. I'll be posting some patches soon, let's see if the same occurs again or if it was a one-off case. Regards, Abhilash > > Best regards, > Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: kesavan.abhilash@gmail.com (Abhilash Kesavan) Date: Mon, 11 Jul 2016 16:44:12 +0200 Subject: [PATCH 1/2] soc: samsung: Change type of PMU configuration register value to u32 In-Reply-To: References: <1467750507-13853-1-git-send-email-a.kesavan@samsung.com> <1467750507-13853-2-git-send-email-a.kesavan@samsung.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Krzysztof, On Wed, Jul 6, 2016 at 8:47 AM, Krzysztof Kozlowski wrote: > On Tue, Jul 5, 2016 at 10:28 PM, Abhilash Kesavan wrote: >> Exynos7 has certain PMU registers that needs to be configured with >> u32 values. >> >> Signed-off-by: Abhilash Kesavan >> --- >> drivers/soc/samsung/exynos-pmu.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/soc/samsung/exynos-pmu.h b/drivers/soc/samsung/exynos-pmu.h >> index a469e36..1bdc506 100644 >> --- a/drivers/soc/samsung/exynos-pmu.h >> +++ b/drivers/soc/samsung/exynos-pmu.h >> @@ -18,7 +18,7 @@ >> >> struct exynos_pmu_conf { >> unsigned int offset; >> - u8 val[NUM_SYS_POWERDOWN]; >> + unsigned int val[NUM_SYS_POWERDOWN]; > > You mentioned u32 but I see unsigned int here. This should be u32. Will change. > > BTW, none of your emails reached my samsung inbox. I got them only > from the lists. Please investigate why this couldn't be delivered to > samsung.com address. Not quite sure why that happened even after I added you as a recipient. I'll be posting some patches soon, let's see if the same occurs again or if it was a one-off case. Regards, Abhilash > > Best regards, > Krzysztof