* [PATCH] mm/memblock: Fix the typo on comments.
@ 2021-01-20 12:28 Levi Yun
2021-01-20 13:56 ` David Hildenbrand
0 siblings, 1 reply; 5+ messages in thread
From: Levi Yun @ 2021-01-20 12:28 UTC (permalink / raw)
To: rppt, akpm; +Cc: linux-mm, inux-kernel
memblock_phys_alloc_try_nid function's comments has typo NUMA as MUMA.
Correct this typo.
Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
---
mm/memblock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memblock.c b/mm/memblock.c
index d24bcfa88d2f..1eaaec1e7687 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -1427,7 +1427,7 @@ phys_addr_t __init memblock_phys_alloc_range(phys_addr_t size,
}
/**
- * memblock_phys_alloc_try_nid - allocate a memory block from specified MUMA node
+ * memblock_phys_alloc_try_nid - allocate a memory block from specified NUMA node
* @size: size of memory block to be allocated in bytes
* @align: alignment of the region and block's size
* @nid: nid of the free area to find, %NUMA_NO_NODE for any node
--
2.29.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/memblock: Fix the typo on comments.
2021-01-20 12:28 [PATCH] mm/memblock: Fix the typo on comments Levi Yun
@ 2021-01-20 13:56 ` David Hildenbrand
2021-01-20 23:43 ` Yun Levi
0 siblings, 1 reply; 5+ messages in thread
From: David Hildenbrand @ 2021-01-20 13:56 UTC (permalink / raw)
To: Levi Yun, rppt, akpm; +Cc: linux-mm, inux-kernel
On 20.01.21 13:28, Levi Yun wrote:
> memblock_phys_alloc_try_nid function's comments has typo NUMA as MUMA.
> Correct this typo.
subject would be clearer as something like
"mm/memblock: Fix typo in comment of memblock_phys_alloc_try_nid()"
Reviewed-by: David Hildenbrand <david@redhat.com>
>
> Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
> ---
> mm/memblock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index d24bcfa88d2f..1eaaec1e7687 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -1427,7 +1427,7 @@ phys_addr_t __init memblock_phys_alloc_range(phys_addr_t size,
> }
>
> /**
> - * memblock_phys_alloc_try_nid - allocate a memory block from specified MUMA node
> + * memblock_phys_alloc_try_nid - allocate a memory block from specified NUMA node
> * @size: size of memory block to be allocated in bytes
> * @align: alignment of the region and block's size
> * @nid: nid of the free area to find, %NUMA_NO_NODE for any node
>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/memblock: Fix the typo on comments.
2021-01-20 13:56 ` David Hildenbrand
@ 2021-01-20 23:43 ` Yun Levi
2021-01-21 8:39 ` Mike Rapoport
0 siblings, 1 reply; 5+ messages in thread
From: Yun Levi @ 2021-01-20 23:43 UTC (permalink / raw)
To: David Hildenbrand; +Cc: rppt, Andrew Morton, linux-mm, inux-kernel
> subject would be clearer as something like
>
> "mm/memblock: Fix typo in comment of memblock_phys_alloc_try_nid()"
>
> Reviewed-by: David Hildenbrand <david@redhat.com>
Thanks. Then, should I resend this patch with suggested subject with
Reviewed-by tag?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/memblock: Fix the typo on comments.
2021-01-20 23:43 ` Yun Levi
@ 2021-01-21 8:39 ` Mike Rapoport
2021-01-21 11:20 ` Yun Levi
0 siblings, 1 reply; 5+ messages in thread
From: Mike Rapoport @ 2021-01-21 8:39 UTC (permalink / raw)
To: Yun Levi; +Cc: David Hildenbrand, Andrew Morton, linux-mm, inux-kernel
On Thu, Jan 21, 2021 at 08:43:20AM +0900, Yun Levi wrote:
> > subject would be clearer as something like
> >
> > "mm/memblock: Fix typo in comment of memblock_phys_alloc_try_nid()"
> >
> > Reviewed-by: David Hildenbrand <david@redhat.com>
>
> Thanks. Then, should I resend this patch with suggested subject with
> Reviewed-by tag?
In general, yes. When there are minor review comments and Reviewed-by tag,
you should send v2 version of a patch that addresses the comments and has
the Reviewed-by tag.
Since this is a small patch and a small update, I've applied the patch with
the subject David suggested to memblock/fixes branch.
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/memblock: Fix the typo on comments.
2021-01-21 8:39 ` Mike Rapoport
@ 2021-01-21 11:20 ` Yun Levi
0 siblings, 0 replies; 5+ messages in thread
From: Yun Levi @ 2021-01-21 11:20 UTC (permalink / raw)
To: Mike Rapoport; +Cc: David Hildenbrand, Andrew Morton, linux-mm, inux-kernel
> In general, yes. When there are minor review comments and Reviewed-by tag,
> you should send v2 version of a patch that addresses the comments and has
> the Reviewed-by tag.
>
> Since this is a small patch and a small update, I've applied the patch with
> the subject David suggested to memblock/fixes branch.
I got it. Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-21 11:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-20 12:28 [PATCH] mm/memblock: Fix the typo on comments Levi Yun
2021-01-20 13:56 ` David Hildenbrand
2021-01-20 23:43 ` Yun Levi
2021-01-21 8:39 ` Mike Rapoport
2021-01-21 11:20 ` Yun Levi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.