From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B49EEC4167B for ; Thu, 10 Dec 2020 06:38:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72E1B23B98 for ; Thu, 10 Dec 2020 06:38:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387475AbgLJGiC (ORCPT ); Thu, 10 Dec 2020 01:38:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725789AbgLJGht (ORCPT ); Thu, 10 Dec 2020 01:37:49 -0500 Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B07BC0613D6; Wed, 9 Dec 2020 22:37:09 -0800 (PST) Received: by mail-io1-xd43.google.com with SMTP id i9so4325793ioo.2; Wed, 09 Dec 2020 22:37:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HShWYqj3AYkJnLdHwx5NgTdwZAauQZwAST01WHghFCw=; b=IQ31dFe57fhu9rGhuD00c/OfQpSIabk6bgI0gHu40WhQT8qCL+eAD5H88Ks7o+XBsU gailQfrvR0zNGmYIbl9rXhoCKFExvAC+vs1EOTQ7c26uu43hKHu9AVH3XZq+Tb0P1+Um 7jF3+Vdr62F9LPXIQ+5rM1RTWgAlgRLIsSAPCV1SGKYBwV0IFD137d2pMJnfq8PLQcg9 TH8n4iP4LhXDgSYdPSPoX+wSqNf2sVTdlfIWHRy7pQGtKZdT+uM4O5b2+SLIoFJdu85+ Mt7K79Qi7pZ6JiNlDYChcZhqk/zKXXt14Sqa63zw2nD1F8Ur6gz0bc2atVDwZC4e7/QQ TA5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HShWYqj3AYkJnLdHwx5NgTdwZAauQZwAST01WHghFCw=; b=oGk0Aw/+yz1VjOBYmbnKoS81tPsnMFiYFm8+nVU4xcdsH8S8Cio2FD+i9zIFfekjnZ Km+TBxDLPAxWpmeyjnJlwydGqRD6ywe2MeB2fOIZ6QvZT6p5gnTylCnVYbSErDYBLrEN NZlG811o6WeiJwMBrLJDFtkXKGUaCNh9zmSBGlr8/4SqggdV7K2Wa6aeXSyGy/vb8gGQ BweXONYxwjevgFOYsrxJlQu+jyu7TZT98oNjdbCoXlf3Yf00B2ZmVPbJ4MVf/3N9tk/P GB7RmqKpE1I5kDA9o8DI/TBKfkRaFOFVOkVmtBd7ZpfF9rnqbjA2Xi77XXWICQADtFyt 4Ruw== X-Gm-Message-State: AOAM5321KFZn1IgsVQ6dMtzYjK+NNvPNnHLAiUf71AwYScrgy9cGvxlB ZmhCzc9m0dGPvEq0qPq36Pq0ev213zyOdpme4p0= X-Google-Smtp-Source: ABdhPJykPkxnX2Y/fkHHKMJSnlcG1CwqOHr7++Gujfz0sDW66ZNXcKFl1K9MuvhBUWNpIbGruWPU7+8kG11G3O9f4E8= X-Received: by 2002:a02:4007:: with SMTP id n7mr7722100jaa.99.1607582228088; Wed, 09 Dec 2020 22:37:08 -0800 (PST) MIME-Version: 1.0 References: <20201210004335.64634-1-pasha.tatashin@soleen.com> <20201210004335.64634-2-pasha.tatashin@soleen.com> In-Reply-To: <20201210004335.64634-2-pasha.tatashin@soleen.com> From: Pankaj Gupta Date: Thu, 10 Dec 2020 07:36:56 +0100 Message-ID: Subject: Re: [PATCH v2 1/8] mm/gup: perform check_dax_vmas only when FS_DAX is enabled To: Pavel Tatashin Cc: LKML , Linux MM , Andrew Morton , Vlastimil Babka , Michal Hocko , David Hildenbrand , Oscar Salvador , Dan Williams , sashal@kernel.org, tyhicks@linux.microsoft.com, Joonsoo Kim , mike.kravetz@oracle.com, rostedt@goodmis.org, Ingo Molnar , "Dave Jiang , Jason Gunthorpe , Aneesh Kumar K.V , Johannes Thumshirn , Logan Gunthorpe" , Peter Zijlstra , Mel Gorman , Matthew Wilcox , David Rientjes , John Hubbard , linux-doc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > There is no need to check_dax_vmas() and run through the npage loop of > pinned pages if FS_DAX is not enabled. > > Add a stub check_dax_vmas() function for no-FS_DAX case. > > Signed-off-by: Pavel Tatashin > Reviewed-by: John Hubbard > --- > mm/gup.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/mm/gup.c b/mm/gup.c > index 98eb8e6d2609..cdb8b9eeb016 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -1568,6 +1568,7 @@ struct page *get_dump_page(unsigned long addr) > #endif /* CONFIG_ELF_CORE */ > > #if defined(CONFIG_FS_DAX) || defined (CONFIG_CMA) > +#ifdef CONFIG_FS_DAX > static bool check_dax_vmas(struct vm_area_struct **vmas, long nr_pages) > { > long i; > @@ -1586,6 +1587,12 @@ static bool check_dax_vmas(struct vm_area_struct **vmas, long nr_pages) > } > return false; > } > +#else > +static bool check_dax_vmas(struct vm_area_struct **vmas, long nr_pages) > +{ > + return false; > +} > +#endif > > #ifdef CONFIG_CMA > static long check_and_migrate_cma_pages(struct mm_struct *mm, Reviewed-by: Pankaj Gupta From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C8D7C4361B for ; Thu, 10 Dec 2020 06:37:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8410223B98 for ; Thu, 10 Dec 2020 06:37:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8410223B98 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 974186B0036; Thu, 10 Dec 2020 01:37:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 924DD6B005D; Thu, 10 Dec 2020 01:37:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 839326B0068; Thu, 10 Dec 2020 01:37:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0076.hostedemail.com [216.40.44.76]) by kanga.kvack.org (Postfix) with ESMTP id 677C26B0036 for ; Thu, 10 Dec 2020 01:37:09 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2E0651EE6 for ; Thu, 10 Dec 2020 06:37:09 +0000 (UTC) X-FDA: 77576415378.04.beef03_5902bf5273f6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 103EF800E2E7 for ; Thu, 10 Dec 2020 06:37:09 +0000 (UTC) X-HE-Tag: beef03_5902bf5273f6 X-Filterd-Recvd-Size: 4654 Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Dec 2020 06:37:08 +0000 (UTC) Received: by mail-io1-f68.google.com with SMTP id z5so4302509iob.11 for ; Wed, 09 Dec 2020 22:37:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HShWYqj3AYkJnLdHwx5NgTdwZAauQZwAST01WHghFCw=; b=IQ31dFe57fhu9rGhuD00c/OfQpSIabk6bgI0gHu40WhQT8qCL+eAD5H88Ks7o+XBsU gailQfrvR0zNGmYIbl9rXhoCKFExvAC+vs1EOTQ7c26uu43hKHu9AVH3XZq+Tb0P1+Um 7jF3+Vdr62F9LPXIQ+5rM1RTWgAlgRLIsSAPCV1SGKYBwV0IFD137d2pMJnfq8PLQcg9 TH8n4iP4LhXDgSYdPSPoX+wSqNf2sVTdlfIWHRy7pQGtKZdT+uM4O5b2+SLIoFJdu85+ Mt7K79Qi7pZ6JiNlDYChcZhqk/zKXXt14Sqa63zw2nD1F8Ur6gz0bc2atVDwZC4e7/QQ TA5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HShWYqj3AYkJnLdHwx5NgTdwZAauQZwAST01WHghFCw=; b=AO7GA6swfjW+VRItTSE6zvdq+ksHD2+2jxHVQBEug1gr7E4/st+98MVesmsoYPwUll Zp9nYplsXsm1Hm3xKctz9Gh1KgPoZwuTV6LsahpCVPi11hxYAfTPSz9MGpmnIvK75eQw 933WqUTE9QtAcPn+zADWBaVk6mxmUl3DQwb4ejHVTEUPdjk+qOQQOMyjvgLYKtlWlzD3 ht8t1OKocmOqTb7TxF81woVSH/N4zaLvjL6tv5B86mA+vfRlbz9e1xc+pI256Yr/Iy03 gru8F8NRE2NHpWCTR2RXu8DJDSzdvkk3QE09RTSkYu9QmAgJX8vJkfonl7UBclD5GgYg owWw== X-Gm-Message-State: AOAM530gcjEIOXm4Z87FWPQZPApWwJeynQR1XnsOftvR7s2rRHv4AKSy Y8irXqri5agrg626aoS51hNrAfAw1atLwTuvaPM= X-Google-Smtp-Source: ABdhPJykPkxnX2Y/fkHHKMJSnlcG1CwqOHr7++Gujfz0sDW66ZNXcKFl1K9MuvhBUWNpIbGruWPU7+8kG11G3O9f4E8= X-Received: by 2002:a02:4007:: with SMTP id n7mr7722100jaa.99.1607582228088; Wed, 09 Dec 2020 22:37:08 -0800 (PST) MIME-Version: 1.0 References: <20201210004335.64634-1-pasha.tatashin@soleen.com> <20201210004335.64634-2-pasha.tatashin@soleen.com> In-Reply-To: <20201210004335.64634-2-pasha.tatashin@soleen.com> From: Pankaj Gupta Date: Thu, 10 Dec 2020 07:36:56 +0100 Message-ID: Subject: Re: [PATCH v2 1/8] mm/gup: perform check_dax_vmas only when FS_DAX is enabled To: Pavel Tatashin Cc: LKML , Linux MM , Andrew Morton , Vlastimil Babka , Michal Hocko , David Hildenbrand , Oscar Salvador , Dan Williams , sashal@kernel.org, tyhicks@linux.microsoft.com, Joonsoo Kim , mike.kravetz@oracle.com, rostedt@goodmis.org, Ingo Molnar , "Dave Jiang , Jason Gunthorpe , Aneesh Kumar K.V , Johannes Thumshirn , Logan Gunthorpe" , Peter Zijlstra , Mel Gorman , Matthew Wilcox , David Rientjes , John Hubbard , linux-doc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > There is no need to check_dax_vmas() and run through the npage loop of > pinned pages if FS_DAX is not enabled. > > Add a stub check_dax_vmas() function for no-FS_DAX case. > > Signed-off-by: Pavel Tatashin > Reviewed-by: John Hubbard > --- > mm/gup.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/mm/gup.c b/mm/gup.c > index 98eb8e6d2609..cdb8b9eeb016 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -1568,6 +1568,7 @@ struct page *get_dump_page(unsigned long addr) > #endif /* CONFIG_ELF_CORE */ > > #if defined(CONFIG_FS_DAX) || defined (CONFIG_CMA) > +#ifdef CONFIG_FS_DAX > static bool check_dax_vmas(struct vm_area_struct **vmas, long nr_pages) > { > long i; > @@ -1586,6 +1587,12 @@ static bool check_dax_vmas(struct vm_area_struct **vmas, long nr_pages) > } > return false; > } > +#else > +static bool check_dax_vmas(struct vm_area_struct **vmas, long nr_pages) > +{ > + return false; > +} > +#endif > > #ifdef CONFIG_CMA > static long check_and_migrate_cma_pages(struct mm_struct *mm, Reviewed-by: Pankaj Gupta