From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 630EAC43332 for ; Thu, 19 Mar 2020 15:59:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 21DDE2072D for ; Thu, 19 Mar 2020 15:59:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FdGI2BjX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21DDE2072D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B2BD26B0003; Thu, 19 Mar 2020 11:59:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADE316B0005; Thu, 19 Mar 2020 11:59:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F3E56B0007; Thu, 19 Mar 2020 11:59:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0059.hostedemail.com [216.40.44.59]) by kanga.kvack.org (Postfix) with ESMTP id 841796B0003 for ; Thu, 19 Mar 2020 11:59:55 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 25DB34DDD for ; Thu, 19 Mar 2020 15:59:55 +0000 (UTC) X-FDA: 76612572750.26.flesh92_56903be2fce59 X-HE-Tag: flesh92_56903be2fce59 X-Filterd-Recvd-Size: 4344 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Mar 2020 15:59:54 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id a25so3757148wrd.0 for ; Thu, 19 Mar 2020 08:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WXCPMpHfny3aSs6UoOIXNlq06neZt71sELEHtKws2zY=; b=FdGI2BjXlngSfEIo/ulQ+tRuw+mjr9WCagZ2nLq0WnCdzWmF4br9TLlc8uCiofVgTi 3vbNAlY+CNBdlxCSLrTuIiMQwe0lg5H5QO3DLOzm/5/+SMUYwBucExp2eMppBbqElNMW PXrmwf1UcZHqP+FNWOeI/2PwyZtABwfwE9K4MGeH+ycNGGXzTuF9EK1Z99wbTBUxDeyP du5/Q5NikdF7J7A1XQ1HMeX8aqbcQCWDa5ndMEwYQ5/4tWiowBPsxrVPVaUamOdYT8cv iTnqhoy5rM+fP2NkCpaaZlo+lYS0fZD8dVKX3MoD07sYhcz9WGJWBRTSSK3yKNPN226b d12A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WXCPMpHfny3aSs6UoOIXNlq06neZt71sELEHtKws2zY=; b=NlHCAg02xIBNpFDHZo+epmvoQ/Ttl4pUiqXI7FVbDLe/vVuk8t5OeDxX8/urdM9GZc 1AlsAwWYNPALF5XMX1U8RK+KO+BiNN/9Vy+DE5g939WUldvdp16j45rwN2nSO/ZOuuED H5N6g0OVaqKoeaNL6bvZKH5qTFTG8+EEhduYHtV7sIX8PwuFjm2+lzzOtQY4Sx3i8YCs XNCBnR1gR8n7FGeZ7CdyqViGarigkCvBD3u1f/oEyb3/QIsNZz6QTuUQY1Ki73Gzaqny TeM1eGtToutylRcT/Mo+bQwmGoda8K/FsnhcezJ93Y0h3YsRXU18v3x7dDkQNRzVD22Q QLFQ== X-Gm-Message-State: ANhLgQ1CT0V2OZDiG10GuYULpjIzJOfn2UFQul6p6kXjbt3EdzHyMKq4 +/T16IjeINUHNzui7rBx6/zeaTdVQfPbdeh0x5g= X-Google-Smtp-Source: ADFU+vtq0a1VgUKXgPFwD5GFSPxJLalk9r/k+PtT7DMeDnVeb2H2LVRBIHXp0Val8D5ntSozeeTQ8xZbGHPCarbDOxs= X-Received: by 2002:adf:fe4c:: with SMTP id m12mr5231563wrs.96.1584633593533; Thu, 19 Mar 2020 08:59:53 -0700 (PDT) MIME-Version: 1.0 References: <20200318140253.6141-1-willy@infradead.org> <20200318140253.6141-3-willy@infradead.org> In-Reply-To: <20200318140253.6141-3-willy@infradead.org> From: Pankaj Gupta Date: Thu, 19 Mar 2020 16:59:42 +0100 Message-ID: Subject: Re: [PATCH v2 2/8] mm: Rename arguments to find_subpage To: Matthew Wilcox Cc: linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > From: "Matthew Wilcox (Oracle)" > > This isn't just a random struct page, it's known to be a head page, > and calling it head makes the function better self-documenting. > The pgoff_t is less confusing if it's named index instead of offset. > Also add a couple of comments to explain why we're doing various things. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/pagemap.h | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index b4ea3a5d00e5..68db0ed8535d 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -333,14 +333,19 @@ static inline struct page *grab_cache_page_nowait(struct address_space *mapping, > mapping_gfp_mask(mapping)); > } > > -static inline struct page *find_subpage(struct page *page, pgoff_t offset) > +/* > + * Given the page we found in the page cache, return the page corresponding > + * to this index in the file > + */ > +static inline struct page *find_subpage(struct page *head, pgoff_t index) > { > - if (PageHuge(page)) > - return page; > + /* HugeTLBfs wants the head page regardless */ > + if (PageHuge(head)) > + return head; > > - VM_BUG_ON_PAGE(PageTail(page), page); > + VM_BUG_ON_PAGE(PageTail(head), head); > > - return page + (offset & (compound_nr(page) - 1)); > + return head + (index & (compound_nr(head) - 1)); > } > > struct page *find_get_entry(struct address_space *mapping, pgoff_t offset); > -- > 2.25.1 Makes function much easier to understand. Thanks! Acked-by: Pankaj Gupta > >