From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78461C4361B for ; Thu, 10 Dec 2020 15:21:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4F122310E for ; Thu, 10 Dec 2020 15:21:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4F122310E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knNl9-00029V-Q6 for qemu-devel@archiver.kernel.org; Thu, 10 Dec 2020 10:21:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knNjy-0001f0-8S for qemu-devel@nongnu.org; Thu, 10 Dec 2020 10:20:22 -0500 Received: from mail-io1-xd44.google.com ([2607:f8b0:4864:20::d44]:38779) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1knNjw-0000HG-Rb for qemu-devel@nongnu.org; Thu, 10 Dec 2020 10:20:22 -0500 Received: by mail-io1-xd44.google.com with SMTP id y5so5868940iow.5 for ; Thu, 10 Dec 2020 07:20:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P5yw0nojv1FxIPkklRD+Vn1mPyoBzspT5SRNNaz7RGU=; b=kIdr8oPuKbMPuSqytIabpVf+M8isfoCi3bJgUzBNpduqmRs6PlO+aExAa8yBeWKMDn ahjKluUROgVS9FRrTefqt6u96vjI7N16HkHdj9Mm23ZeS6GS7A+JFAbHavsyT19j38Ia MB5xmI5PiWQP+P3Xu7ltfVYAG49HmT0Fw2kldNMhi7fZBm8FQ2xIUJb4gshxZw7zIIuy 7CJGh2rCq8mCgRMMlEhm2elKoZwoQlCzAxa3oIaEe76XRXx3gWjwFBckZO6x03ensySA h5bZpJgNfjb+J2w6P1+aS+pAypbINVMqAC5whhvPaRh2gqCvgWuAhkCacmlJQaQFEErP MxPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P5yw0nojv1FxIPkklRD+Vn1mPyoBzspT5SRNNaz7RGU=; b=WXsf23bK+ABNBf8/ZykWKMbihl/irXIoLwZyp+I20/1g7S4x51sE4sAXlBz/YcxNVP p48bkhHqpJiv5fONAv2TJKF+ZxbavSkJYNey/ajzyImJDKHp96mUN0rpQD/dAAPJTGgQ LPToFNw4h9PcPVlkUs1nKbLNmj0aWpazyJcEEgMvap4P3GG3GAzVbWAnhLfBHaGI2VUC +k4Jjc28SCC3GvNWTvJOED0CT0Hr4SRILlHRh7kZ3aZZccKw7YOSaTsWwDYMCqe2+v1D WF9thX7VLCmZoGd/2w5GB+M0b8JbzO3bDacp8rBtxH7NG35ApxQGAy+P/nJFM34K12Hs kOLg== X-Gm-Message-State: AOAM530YDqRNjEaJJjBjHExXc+ok3d7xzjQ99XWFJXALU796skwQB4Nh 91JEfR41MZWNNl3GL/l1ZjBGIEV1J/wc6ZTFugY= X-Google-Smtp-Source: ABdhPJyEZ4S2+oxMimkHdRzgR2seFLMyinaLcN3ZuFQxkKH3nYaf06LyEPgddbRBF/3kaGh+G4Jr0qMXXo5gHK8Dwvc= X-Received: by 2002:a5d:9c91:: with SMTP id p17mr8676140iop.36.1607613619761; Thu, 10 Dec 2020 07:20:19 -0800 (PST) MIME-Version: 1.0 References: <20201208163950.29617-1-david@redhat.com> <20201208163950.29617-8-david@redhat.com> <1a69a01e-9be5-0a3f-0ac6-c1f1fb4b4561@redhat.com> In-Reply-To: <1a69a01e-9be5-0a3f-0ac6-c1f1fb4b4561@redhat.com> From: Pankaj Gupta Date: Thu, 10 Dec 2020 16:20:08 +0100 Message-ID: Subject: Re: [PATCH v2 07/10] softmmu/physmem: Don't use atomic operations in ram_block_discard_(disable|require) To: David Hildenbrand Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::d44; envelope-from=pankaj.gupta.linux@gmail.com; helo=mail-io1-xd44.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Kedzierski , Wei Yang , "Michael S. Tsirkin" , Qemu Developers , Peter Xu , "Dr . David Alan Gilbert" , Auger Eric , Alex Williamson , teawater , Jonathan Cameron , Paolo Bonzini , Igor Mammedov Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > >> bool ram_block_discard_is_disabled(void) > >> { > >> - return qatomic_read(&ram_block_discard_disabled) > 0; > >> + return qatomic_read(&ram_block_discard_disablers); > >> } > > return value won't be bool? > > The compiler does type conversion. > > != 0 -> true > == 0 -> false ah... I missed it :( Thanks, Pankaj