From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC701C56201 for ; Wed, 11 Nov 2020 10:24:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68C56207D3 for ; Wed, 11 Nov 2020 10:24:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ImcC1ley" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727337AbgKKKYB (ORCPT ); Wed, 11 Nov 2020 05:24:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726229AbgKKKYA (ORCPT ); Wed, 11 Nov 2020 05:24:00 -0500 Received: from mail-il1-x142.google.com (mail-il1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4881C0613D1 for ; Wed, 11 Nov 2020 02:24:00 -0800 (PST) Received: by mail-il1-x142.google.com with SMTP id y9so1526970ilb.0 for ; Wed, 11 Nov 2020 02:24:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WwWtf2IxfiVAWZrn5dCKI7gG2bc7NyL+FT5iICr8YCk=; b=ImcC1leyIi6uZ+JOHqNrIn+Ch/xaQCtpBQZG1p82PESFzJxZejQZCGD47FpyveosuI wn2WyxSpD/dbUx4vvxtDVpYREm9rNXJ/AJrXInIOFMxZXE60znkUB5LqKhBUxmeeqbEw XpglGdt7mYLmAFb4AeS8kfnHwnkRDEMa9P5srEfCYaZI735V1JNQtZ8DF2TWTlKULx7j ePK492Oadb3ggTUPnYtNzZAXzpvme7H/73ncDBwil/qQfbkNjY9FOnQRXtnoM5XcbC8Q lov+017hI8lHdrDWOeKMgmV57Wosaad1uNMwSuWgCbjB4Qig/vyDsc5J/odeqbxLwcuk S3mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WwWtf2IxfiVAWZrn5dCKI7gG2bc7NyL+FT5iICr8YCk=; b=SBCvCLMKEoQCzxU2WJEfjpxXF+q6ZWL0gZjR7B14R4NyD/5QplNkLZhgEVEthUPoof QsRVW/0Hv7RaY1frSccL97U9iT+6T3uCBeMEBJoOvWYdVkEk82O/tZwAKlY1LtQ2JzWr XP65Tz60+F/TX+ak0ERbdlV1X9UsaBYEponAnlNZ1+L8zxDWeXBzF+CU5AnY3p2uRXfH OwceqthPnFn/qYpHhIy37m6DeQdWKZRR+RilvUrhKU7Mq84pjrbxKu/9fOxuNkw3M9IK 6VicIpozoy+5M3HjkbU2wLqCNoJfMTExV+c4dQeYvZRbTsR1Fn19Gd2GJRIsM+ErNJl+ 1nWw== X-Gm-Message-State: AOAM533CLZ2H4CSCRU8o5nrmsLARWInkgcuU40OOR5m8OBT1X2cu5jEE axUvF3y+2n0BK0OQacG2FGMoxTKhQogbvFpP9+s= X-Google-Smtp-Source: ABdhPJw5ABNfL/B/p3VZolIbLokzEsa/blnUkQ2L5UWSO/QA+RfazUr/QBcYuuyL8C8LOAS1L1SiiXFBgx+ZHQNghjI= X-Received: by 2002:a92:6508:: with SMTP id z8mr4081483ilb.253.1605090239447; Wed, 11 Nov 2020 02:23:59 -0800 (PST) MIME-Version: 1.0 References: <20201111092812.11329-1-vbabka@suse.cz> <20201111092812.11329-4-vbabka@suse.cz> In-Reply-To: <20201111092812.11329-4-vbabka@suse.cz> From: Pankaj Gupta Date: Wed, 11 Nov 2020 11:23:48 +0100 Message-ID: Subject: Re: [PATCH v3 3/7] mm, page_alloc: remove setup_pageset() To: Vlastimil Babka Cc: Andrew Morton , Linux MM , LKML , Michal Hocko , Pavel Tatashin , David Hildenbrand , Oscar Salvador , Joonsoo Kim , Michal Hocko Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > We initialize boot-time pagesets with setup_pageset(), which sets high and > batch values that effectively disable pcplists. > > We can remove this wrapper if we just set these values for all pagesets in > pageset_init(). Non-boot pagesets then subsequently update them to the proper > values. > > No functional change. > > Signed-off-by: Vlastimil Babka > Reviewed-by: David Hildenbrand > Reviewed-by: Oscar Salvador > Acked-by: Michal Hocko > --- > mm/page_alloc.c | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 2fa432762908..5a8ec7d94884 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5911,7 +5911,7 @@ static void build_zonelists(pg_data_t *pgdat) > * not check if the processor is online before following the pageset pointer. > * Other parts of the kernel may not check if the zone is available. > */ > -static void setup_pageset(struct per_cpu_pageset *p); > +static void pageset_init(struct per_cpu_pageset *p); > static DEFINE_PER_CPU(struct per_cpu_pageset, boot_pageset); > static DEFINE_PER_CPU(struct per_cpu_nodestat, boot_nodestats); > > @@ -5979,7 +5979,7 @@ build_all_zonelists_init(void) > * (a chicken-egg dilemma). > */ > for_each_possible_cpu(cpu) > - setup_pageset(&per_cpu(boot_pageset, cpu)); > + pageset_init(&per_cpu(boot_pageset, cpu)); > > mminit_verify_zonelist(); > cpuset_init_current_mems_allowed(); > @@ -6298,12 +6298,15 @@ static void pageset_init(struct per_cpu_pageset *p) > pcp = &p->pcp; > for (migratetype = 0; migratetype < MIGRATE_PCPTYPES; migratetype++) > INIT_LIST_HEAD(&pcp->lists[migratetype]); > -} > > -static void setup_pageset(struct per_cpu_pageset *p) > -{ > - pageset_init(p); > - pageset_update(&p->pcp, 0, 1); > + /* > + * Set batch and high values safe for a boot pageset. A true percpu > + * pageset's initialization will update them subsequently. Here we don't > + * need to be as careful as pageset_update() as nobody can access the > + * pageset yet. > + */ > + pcp->high = 0; > + pcp->batch = 1; > } Acked-by: Pankaj Gupta From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 869F4C4742C for ; Wed, 11 Nov 2020 10:24:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DC71020759 for ; Wed, 11 Nov 2020 10:24:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ImcC1ley" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC71020759 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2AF576B006E; Wed, 11 Nov 2020 05:24:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 25F576B0070; Wed, 11 Nov 2020 05:24:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 175D76B0071; Wed, 11 Nov 2020 05:24:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0225.hostedemail.com [216.40.44.225]) by kanga.kvack.org (Postfix) with ESMTP id E09496B006E for ; Wed, 11 Nov 2020 05:24:00 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 897333621 for ; Wed, 11 Nov 2020 10:24:00 +0000 (UTC) X-FDA: 77471751840.27.ghost06_46058c0272fd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 6E3D43D663 for ; Wed, 11 Nov 2020 10:24:00 +0000 (UTC) X-HE-Tag: ghost06_46058c0272fd X-Filterd-Recvd-Size: 5299 Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 10:23:59 +0000 (UTC) Received: by mail-il1-f195.google.com with SMTP id t13so1513506ilp.2 for ; Wed, 11 Nov 2020 02:23:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WwWtf2IxfiVAWZrn5dCKI7gG2bc7NyL+FT5iICr8YCk=; b=ImcC1leyIi6uZ+JOHqNrIn+Ch/xaQCtpBQZG1p82PESFzJxZejQZCGD47FpyveosuI wn2WyxSpD/dbUx4vvxtDVpYREm9rNXJ/AJrXInIOFMxZXE60znkUB5LqKhBUxmeeqbEw XpglGdt7mYLmAFb4AeS8kfnHwnkRDEMa9P5srEfCYaZI735V1JNQtZ8DF2TWTlKULx7j ePK492Oadb3ggTUPnYtNzZAXzpvme7H/73ncDBwil/qQfbkNjY9FOnQRXtnoM5XcbC8Q lov+017hI8lHdrDWOeKMgmV57Wosaad1uNMwSuWgCbjB4Qig/vyDsc5J/odeqbxLwcuk S3mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WwWtf2IxfiVAWZrn5dCKI7gG2bc7NyL+FT5iICr8YCk=; b=udvOMjbDkuQPApgSgLWJP7mLDVHkBY0W/BHJjwK+w+5fvUG8kdiJjAY+PPgKACslRF jfPA9k7Oz5OZNGEn17Ur6dpjBXjTvwynuBlDM4ebA/nCbXMa6cExZm4IyRJ4lOQvP81u 1njcVaZOUBUl5TQPVkbBEAIQLd9abr2L9qot8e44uMTFHEhgEFqH0lzA2WkvfyopZNGR yWU/WpsPK7ZLCZC2XOf9+AJt2RDVrqGBNS3qKsRM5a7Rd2NrYQzf6v3iDo9dx6Zul+EY h/kc5Ie5Jkayn+QZR7i8q5W5y4q9bPGa9YKXSRg66Ly0X9lCX2IW5/MKj0Y06C7lBWKI uWlQ== X-Gm-Message-State: AOAM5320+MQOSrHJwZOz6LhfsOmsHzY/VtyGrxadeqiWOBQAmCRXsvGF HrfYwefmnNoq66O35FHjeFqHWJzMEzbAU0o0QB4= X-Google-Smtp-Source: ABdhPJw5ABNfL/B/p3VZolIbLokzEsa/blnUkQ2L5UWSO/QA+RfazUr/QBcYuuyL8C8LOAS1L1SiiXFBgx+ZHQNghjI= X-Received: by 2002:a92:6508:: with SMTP id z8mr4081483ilb.253.1605090239447; Wed, 11 Nov 2020 02:23:59 -0800 (PST) MIME-Version: 1.0 References: <20201111092812.11329-1-vbabka@suse.cz> <20201111092812.11329-4-vbabka@suse.cz> In-Reply-To: <20201111092812.11329-4-vbabka@suse.cz> From: Pankaj Gupta Date: Wed, 11 Nov 2020 11:23:48 +0100 Message-ID: Subject: Re: [PATCH v3 3/7] mm, page_alloc: remove setup_pageset() To: Vlastimil Babka Cc: Andrew Morton , Linux MM , LKML , Michal Hocko , Pavel Tatashin , David Hildenbrand , Oscar Salvador , Joonsoo Kim , Michal Hocko Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > We initialize boot-time pagesets with setup_pageset(), which sets high and > batch values that effectively disable pcplists. > > We can remove this wrapper if we just set these values for all pagesets in > pageset_init(). Non-boot pagesets then subsequently update them to the proper > values. > > No functional change. > > Signed-off-by: Vlastimil Babka > Reviewed-by: David Hildenbrand > Reviewed-by: Oscar Salvador > Acked-by: Michal Hocko > --- > mm/page_alloc.c | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 2fa432762908..5a8ec7d94884 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5911,7 +5911,7 @@ static void build_zonelists(pg_data_t *pgdat) > * not check if the processor is online before following the pageset pointer. > * Other parts of the kernel may not check if the zone is available. > */ > -static void setup_pageset(struct per_cpu_pageset *p); > +static void pageset_init(struct per_cpu_pageset *p); > static DEFINE_PER_CPU(struct per_cpu_pageset, boot_pageset); > static DEFINE_PER_CPU(struct per_cpu_nodestat, boot_nodestats); > > @@ -5979,7 +5979,7 @@ build_all_zonelists_init(void) > * (a chicken-egg dilemma). > */ > for_each_possible_cpu(cpu) > - setup_pageset(&per_cpu(boot_pageset, cpu)); > + pageset_init(&per_cpu(boot_pageset, cpu)); > > mminit_verify_zonelist(); > cpuset_init_current_mems_allowed(); > @@ -6298,12 +6298,15 @@ static void pageset_init(struct per_cpu_pageset *p) > pcp = &p->pcp; > for (migratetype = 0; migratetype < MIGRATE_PCPTYPES; migratetype++) > INIT_LIST_HEAD(&pcp->lists[migratetype]); > -} > > -static void setup_pageset(struct per_cpu_pageset *p) > -{ > - pageset_init(p); > - pageset_update(&p->pcp, 0, 1); > + /* > + * Set batch and high values safe for a boot pageset. A true percpu > + * pageset's initialization will update them subsequently. Here we don't > + * need to be as careful as pageset_update() as nobody can access the > + * pageset yet. > + */ > + pcp->high = 0; > + pcp->batch = 1; > } Acked-by: Pankaj Gupta