From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 547F4C2BB85 for ; Wed, 15 Apr 2020 05:59:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A200206E9 for ; Wed, 15 Apr 2020 05:59:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JcWcWuiD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2441065AbgDOF7o (ORCPT ); Wed, 15 Apr 2020 01:59:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2441062AbgDOF7m (ORCPT ); Wed, 15 Apr 2020 01:59:42 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD0D8C061A0C; Tue, 14 Apr 2020 22:59:41 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id i10so17579603wrv.10; Tue, 14 Apr 2020 22:59:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bsdw+AlvxpaYVY8Lcjiqb5lWVO+/dV7fKji2stjWQoM=; b=JcWcWuiDWGrat7PLbbGGpy+VPCwZm+B8+b6wIR5Qlxfxy+BWIl7W3IQIkJhpT9dMQ/ KHWM043X+68VVMlKeKimAMxZXIuFAWaKNOyTQ7mygKJZirRFrXpLfga5nca6/yN7sb7m JeQn2eTsJoY0SsenEcw6+1hEASroKswAcE4X35r0YOiPZ5jGBKQApmHqFZ4sq4gHjKdG Y3n6+YfWWVguF7/onY60Kqj/u2fjv8erG23gS8RGAkzk0bQHYB1BDVnfjrHaE8CS5aSt Rjr7k+3et5/Y/3dqyE09ehmdQNqJPeeYs/kLKup/xCUwjwdd68D89T8FnDTSl+XL6fb+ smZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bsdw+AlvxpaYVY8Lcjiqb5lWVO+/dV7fKji2stjWQoM=; b=daNe2Lm+Is6pfWmordGgi+Cxl+3yMz9wigDI7lbCmY7hs6nBsKZORcwYYw63CRJ6ja oHOPSZML964TT0S9kiQlG8gohW6Bcvv4JOWTp0nZ4KXuKFuUJcFp9udKmnMr+/BkpR7o 7H1Nd1GvsFVa52dulJRhddNnCu1EcWBeUZUw7f8n4QrCdWe2MZrzMNlx6cFQFFOIq9ok +A4U8XtexsXPrt6PFhQGhgTcT4xpYCWWMqoH2bUG53vfcQ0c04xDIBWJSBbkSBCIMtd7 +xzl/W4z+P9BaQm7ri2W89HhK4HC1XqBoWoH2t8Q6OU3Umo5nym9xbCM2qy4Dg/mZadZ QaFA== X-Gm-Message-State: AGi0Pub6l2ehgXKpJyn4uGnY1dznb+JpzCeGnE4peFmHlYpEc5rD7GIF pGTfLc+wBR8N6c+jHrB/QSRHTT5C2g2zq3ZdGso= X-Google-Smtp-Source: APiQypLIUSKaAEG1Gvkn2HdyUu7XOJ1Ks6l0f/YpHQQasnkp1D78E3DW2NpedLoUJjzQcwbl8mvUogTsn+2/TeKZq4Y= X-Received: by 2002:adf:db4d:: with SMTP id f13mr6637560wrj.289.1586930380463; Tue, 14 Apr 2020 22:59:40 -0700 (PDT) MIME-Version: 1.0 References: <20200311171422.10484-1-david@redhat.com> <20200311171422.10484-2-david@redhat.com> In-Reply-To: <20200311171422.10484-2-david@redhat.com> From: Pankaj Gupta Date: Wed, 15 Apr 2020 07:59:28 +0200 Message-ID: Subject: Re: [PATCH v2 01/10] virtio-mem: Paravirtualized memory hotplug To: David Hildenbrand Cc: LKML , Linux MM , virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, Michal Hocko , Andrew Morton , "Michael S . Tsirkin" , Jason Wang , Oscar Salvador , Igor Mammedov , Dave Young , Dan Williams , Pavel Tatashin , Stefan Hajnoczi , Vlastimil Babka , "Rafael J. Wysocki" , Len Brown , linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org I spent quite some time to review and also tested this driver. This looks good to me. Feel free to add. Reviewed-by: Pankaj Gupta From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D6D1C2BA2B for ; Wed, 15 Apr 2020 05:59:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 06F6E2076A for ; Wed, 15 Apr 2020 05:59:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JcWcWuiD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06F6E2076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9CF398E0006; Wed, 15 Apr 2020 01:59:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 956738E0001; Wed, 15 Apr 2020 01:59:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 846088E0006; Wed, 15 Apr 2020 01:59:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by kanga.kvack.org (Postfix) with ESMTP id 65CEE8E0001 for ; Wed, 15 Apr 2020 01:59:42 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1B2BF824556B for ; Wed, 15 Apr 2020 05:59:42 +0000 (UTC) X-FDA: 76709037804.22.eyes46_378f5790a4559 X-HE-Tag: eyes46_378f5790a4559 X-Filterd-Recvd-Size: 3405 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Apr 2020 05:59:41 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id i10so17579609wrv.10 for ; Tue, 14 Apr 2020 22:59:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bsdw+AlvxpaYVY8Lcjiqb5lWVO+/dV7fKji2stjWQoM=; b=JcWcWuiDWGrat7PLbbGGpy+VPCwZm+B8+b6wIR5Qlxfxy+BWIl7W3IQIkJhpT9dMQ/ KHWM043X+68VVMlKeKimAMxZXIuFAWaKNOyTQ7mygKJZirRFrXpLfga5nca6/yN7sb7m JeQn2eTsJoY0SsenEcw6+1hEASroKswAcE4X35r0YOiPZ5jGBKQApmHqFZ4sq4gHjKdG Y3n6+YfWWVguF7/onY60Kqj/u2fjv8erG23gS8RGAkzk0bQHYB1BDVnfjrHaE8CS5aSt Rjr7k+3et5/Y/3dqyE09ehmdQNqJPeeYs/kLKup/xCUwjwdd68D89T8FnDTSl+XL6fb+ smZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bsdw+AlvxpaYVY8Lcjiqb5lWVO+/dV7fKji2stjWQoM=; b=TkxP8NR0D1HnYsXmS1LbQdyGqQZjoH63JTjKUBDx7DR5EIckTh7e0RMVPkLSFURFzH EP+6jJhhHY0+MIDBcBVIczXV3NpYi79FVtlA+9lHDz9enq2UYF3sMG08vhlh7M221h9F S6YQ009yhY7TfRnjpmOAQJ9Bij6xF/Eznteb0wDOCtvl/eqD+OWMKISaGTc3qQenSH+Y tCBQoIAFFfcAOaEuMTWZ+GM3sJG3hpwElbXjtZJxiA5Q5U4nitByAMJpXnsfoznMyGcZ H9qDfgi1Sq5+pQBinnC8F5DkslvFvo4Ly3WBLctpiFplhIY/sw4VHP2c7cyTEVWupdPW Sj4A== X-Gm-Message-State: AGi0PubVk/cik2r3pmxiqkZvDo+VyI/jM1BXyZuuhXXoXwQARFw8+bMx 9qVJGkx0yEK4uIA6gDdqHzeNtw4d/2PtId6denU= X-Google-Smtp-Source: APiQypLIUSKaAEG1Gvkn2HdyUu7XOJ1Ks6l0f/YpHQQasnkp1D78E3DW2NpedLoUJjzQcwbl8mvUogTsn+2/TeKZq4Y= X-Received: by 2002:adf:db4d:: with SMTP id f13mr6637560wrj.289.1586930380463; Tue, 14 Apr 2020 22:59:40 -0700 (PDT) MIME-Version: 1.0 References: <20200311171422.10484-1-david@redhat.com> <20200311171422.10484-2-david@redhat.com> In-Reply-To: <20200311171422.10484-2-david@redhat.com> From: Pankaj Gupta Date: Wed, 15 Apr 2020 07:59:28 +0200 Message-ID: Subject: Re: [PATCH v2 01/10] virtio-mem: Paravirtualized memory hotplug To: David Hildenbrand Cc: LKML , Linux MM , virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, Michal Hocko , Andrew Morton , "Michael S . Tsirkin" , Jason Wang , Oscar Salvador , Igor Mammedov , Dave Young , Dan Williams , Pavel Tatashin , Stefan Hajnoczi , Vlastimil Babka , "Rafael J. Wysocki" , Len Brown , linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I spent quite some time to review and also tested this driver. This looks good to me. Feel free to add. Reviewed-by: Pankaj Gupta