From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 749BFC4320A for ; Thu, 29 Jul 2021 04:26:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5581260F23 for ; Thu, 29 Jul 2021 04:26:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233704AbhG2E0t (ORCPT ); Thu, 29 Jul 2021 00:26:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232023AbhG2E0s (ORCPT ); Thu, 29 Jul 2021 00:26:48 -0400 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FD99C061757; Wed, 28 Jul 2021 21:26:45 -0700 (PDT) Received: by mail-il1-x129.google.com with SMTP id x7so1102525ilh.10; Wed, 28 Jul 2021 21:26:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=6qZSdBV70oLjzXY9J+kcpHCTOof0JnPkRHvC46/0enE=; b=NLXb0OLnoHRE2t16wv2trQILVqh7yOu+pBFyho/tFMH3mB8KTdKPP+H6KcBlI0kgUJ sO59ROgNvyvOSUyqhO24IwPJl5zEBMVGy8Ralbh5R7QIKgKvuflsVkG++8/RYh9DYh0V JixA3XSUtQKND+hXCXZWljh1ktgpjJTrYR1mcRdVLcx4pRlPXZHUMzubyawn+8fCz0GX qZNdcUJMM9qbE5vCxk7iTtr3xJuxdeN/qeRgAtQLeTJhZqFdYXY+1UEE+FNqnfhWp3R0 OJwlANBseQhp0rKw1p2Oef7mMEWNW1Gvt8aFtvXkYOi4OhJ7mpgU6fK7TbPaYDDZZYpE p5zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=6qZSdBV70oLjzXY9J+kcpHCTOof0JnPkRHvC46/0enE=; b=Y9r+8dkhGvWO9LcQJjQ90RTNL9zMkVF7L0KKUw3v5ldJBQGqUrhJOhadgIcvE3JpxA DZGwq/QpzQ3T97Vxt1TdnGG43tLVsqAfsQC+AvgIsec5t6oCkhi4j4lZ+gwkdBpbLpdy KrOJLXQEvu7AVlFwulV8QmFnhPyHTGlVc1SHouYKyRS531dJOtsGLC9Rig6dLEbi7+Ap Lfu7RV/xiIWYijHwic1oMmRd3gPzq67usbIMgA/82BVQ0771G3j1X0vflu8vWTuAuE1H 7f4S9l4sEK+Q1+xeo6ixmETgUnN3C1BosIVwhEbt9NGDyKxB5a5HwA8iPebwy9qq6TdY v9JQ== X-Gm-Message-State: AOAM5309C30OZVjcNZqjYZ1vq8CQAhvKy3gGfDXeaMR0Zdy3x2bsPUA+ iUhflKcxrMzc5CFIUjzF57VF3kHfBf+JQrWunYk= X-Google-Smtp-Source: ABdhPJzpXQeDsRaaXvVfSvElKNAYZqDm1v7RAdis7kDfYXUnO38CrA7TED+wbGjakqPi3hd+HBlLZAW6DwHPkz8noQQ= X-Received: by 2002:a92:a005:: with SMTP id e5mr2242648ili.22.1627532805050; Wed, 28 Jul 2021 21:26:45 -0700 (PDT) MIME-Version: 1.0 References: <20210722063946.28951-1-mika.penttila@gmail.com> In-Reply-To: From: Pankaj Gupta Date: Thu, 29 Jul 2021 06:26:34 +0200 Message-ID: Subject: Re: [PATCH] is_core_idle() is using a wrong variable To: Peter Zijlstra Cc: mika.penttila@gmail.com, LKML , Li RongQing , Paolo Bonzini , Ingo Molnar , kvm@vger.kernel.org, Mel Gorman Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Jul 2021 at 12:46, Peter Zijlstra wrote: > > On Thu, Jul 22, 2021 at 09:39:46AM +0300, mika.penttila@gmail.com wrote: > > From: Mika Penttil=C3=A4 > > > > is_core_idle() was using a wrong variable in the loop test. Fix it. > > > > Signed-off-by: Mika Penttil=C3=A4 > > Thanks! > > --- > Subject: sched/numa: Fix is_core_idle() > From: Mika Penttil=C3=A4 > Date: Thu, 22 Jul 2021 09:39:46 +0300 > > From: Mika Penttil=C3=A4 > > Use the loop variable instead of the function argument to test the > other SMT siblings for idle. > > Fixes: ff7db0bf24db ("sched/numa: Prefer using an idle CPU as a migration= target instead of comparing tasks") > Signed-off-by: Mika Penttil=C3=A4 > Signed-off-by: Peter Zijlstra (Intel) > Link: https://lkml.kernel.org/r/20210722063946.28951-1-mika.penttila@gmai= l.com > --- > kernel/sched/fair.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -1486,7 +1486,7 @@ static inline bool is_core_idle(int cpu) > if (cpu =3D=3D sibling) > continue; > > - if (!idle_cpu(cpu)) > + if (!idle_cpu(sibling)) > return false; > } > #endif Acked-by: Pankaj Gupta