From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 155D0C3F2D4 for ; Sat, 29 Feb 2020 07:47:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DDD0F2469C for ; Sat, 29 Feb 2020 07:47:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="txSyWcKj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726910AbgB2Hra (ORCPT ); Sat, 29 Feb 2020 02:47:30 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:47017 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726671AbgB2Hra (ORCPT ); Sat, 29 Feb 2020 02:47:30 -0500 Received: by mail-wr1-f65.google.com with SMTP id j7so5848955wrp.13; Fri, 28 Feb 2020 23:47:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7/LUz+UTHLwwlROXmy/x3cftQqidhD9BYUn0xrwvLmc=; b=txSyWcKjgszAoID7iV7ciBLMEePBbqWlV/a2pJmnCgmB36H9o462dkAlmtyqqeHiGr JAw5f/AjqKB5I7pyB6AYmZaFP9cFW33rqE/C7s9a4TQ4HApO8sASGkDYEqBylspTOOTF 7uqLJNfhg8uuzGIPaQmHqIk1MxbAx9hbOtYxIHG+u+oqgDBvDLF6TRYb4Hr+Ok49gx4J BrhEgEphb2w1ZG+abujhP64sCubiBqhjwyVDfbdPAJQjIaV+gr2TRHey05OcBc+GUisE MRYUoUxYq27cdXV+l5r5LaVwslM/zCpsswJKB0FKeLvfBqzSvTl7SoFgwzKR1jRTG+rc mjnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7/LUz+UTHLwwlROXmy/x3cftQqidhD9BYUn0xrwvLmc=; b=rPoOLxZXIgeUv+j8ckRe73mmK+E68Nz2oc8+f5GVchJOiUtBgWnHIthGgIVvgnDuvb a2p63oKlBKXnkCy79WRGuxeD67ZY70lh6okUgtauDmcPn8ptEL2E0Yw2VNpjrQUnjdYh fh9qU5EGowP7Pxxy7cW3O+RPnSRdNC1dF5TNnuHU3UPTp6ay1uAXiq+8kj6ZbfMFtomN B2gkvDfTOk2Ew6/6H2rsoVyA503VcrQBX/TZILPGmVb6iFJbXfoRfteOI4goi3WtI4Lp 9l8Uaxb5T7EHydWx+y+6Qx4GZk2C8WfpvPmLMHFBv3fPB6yEWx8DfJfRz87FsH1Nh0sW EYAg== X-Gm-Message-State: APjAAAWdYlCEi4rU1yuK603XDP146//RyoePqtW5bzXoLuXBzxE/w0Uz StTYl+Fp9E5Em+ux/2e+aotMfCtf87GpPw7gczg= X-Google-Smtp-Source: APXvYqxQFrUYzLR51muw6xWoYS1TtAN4x8hADnWygx76GqczT7kBq4N2F5PQMlWmipUpFCiARR144YhMae4ozdtNIBM= X-Received: by 2002:adf:cc85:: with SMTP id p5mr9242071wrj.196.1582962448152; Fri, 28 Feb 2020 23:47:28 -0800 (PST) MIME-Version: 1.0 References: <20200228235003.112718-1-colin.king@canonical.com> In-Reply-To: <20200228235003.112718-1-colin.king@canonical.com> From: Pankaj Gupta Date: Sat, 29 Feb 2020 08:47:16 +0100 Message-ID: Subject: Re: [PATCH] mm/memblock: remove redundant assignment to variable max_addr To: Colin King Cc: Mike Rapoport , Andrew Morton , linux-mm@kvack.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > From: Colin Ian King > > The variable max_addr is being initialized with a value that is never > read and it is being updated later with a new value. The initialization > is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > mm/memblock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index eba94ee3de0b..4d06bbaded0f 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1698,7 +1698,7 @@ static phys_addr_t __init_memblock __find_max_addr(phys_addr_t limit) > > void __init memblock_enforce_memory_limit(phys_addr_t limit) > { > - phys_addr_t max_addr = PHYS_ADDR_MAX; > + phys_addr_t max_addr; > > if (!limit) > return; > -- > 2.25.0 Reviewed-by: Pankaj Gupta > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pankaj Gupta Date: Sat, 29 Feb 2020 07:47:16 +0000 Subject: Re: [PATCH] mm/memblock: remove redundant assignment to variable max_addr Message-Id: List-Id: References: <20200228235003.112718-1-colin.king@canonical.com> In-Reply-To: <20200228235003.112718-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Mike Rapoport , Andrew Morton , linux-mm@kvack.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org > > From: Colin Ian King > > The variable max_addr is being initialized with a value that is never > read and it is being updated later with a new value. The initialization > is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > mm/memblock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index eba94ee3de0b..4d06bbaded0f 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1698,7 +1698,7 @@ static phys_addr_t __init_memblock __find_max_addr(phys_addr_t limit) > > void __init memblock_enforce_memory_limit(phys_addr_t limit) > { > - phys_addr_t max_addr = PHYS_ADDR_MAX; > + phys_addr_t max_addr; > > if (!limit) > return; > -- > 2.25.0 Reviewed-by: Pankaj Gupta > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5395DC3F2D6 for ; Sat, 29 Feb 2020 07:47:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DD8DE2469C for ; Sat, 29 Feb 2020 07:47:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="txSyWcKj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD8DE2469C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5583E6B0003; Sat, 29 Feb 2020 02:47:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 508746B0006; Sat, 29 Feb 2020 02:47:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41F566B0007; Sat, 29 Feb 2020 02:47:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0206.hostedemail.com [216.40.44.206]) by kanga.kvack.org (Postfix) with ESMTP id 2640A6B0003 for ; Sat, 29 Feb 2020 02:47:30 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D5C6A18014D32 for ; Sat, 29 Feb 2020 07:47:29 +0000 (UTC) X-FDA: 76542384618.12.gold29_416944548fc05 X-HE-Tag: gold29_416944548fc05 X-Filterd-Recvd-Size: 3639 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Sat, 29 Feb 2020 07:47:29 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id l5so5932718wrx.4 for ; Fri, 28 Feb 2020 23:47:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7/LUz+UTHLwwlROXmy/x3cftQqidhD9BYUn0xrwvLmc=; b=txSyWcKjgszAoID7iV7ciBLMEePBbqWlV/a2pJmnCgmB36H9o462dkAlmtyqqeHiGr JAw5f/AjqKB5I7pyB6AYmZaFP9cFW33rqE/C7s9a4TQ4HApO8sASGkDYEqBylspTOOTF 7uqLJNfhg8uuzGIPaQmHqIk1MxbAx9hbOtYxIHG+u+oqgDBvDLF6TRYb4Hr+Ok49gx4J BrhEgEphb2w1ZG+abujhP64sCubiBqhjwyVDfbdPAJQjIaV+gr2TRHey05OcBc+GUisE MRYUoUxYq27cdXV+l5r5LaVwslM/zCpsswJKB0FKeLvfBqzSvTl7SoFgwzKR1jRTG+rc mjnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7/LUz+UTHLwwlROXmy/x3cftQqidhD9BYUn0xrwvLmc=; b=r19s1X9KMQ4aCDUonwsN6jMpiRp6tNeVCcuaY50p0LXc2LYkOWFe8uNRUb39fc2MGz 5dijhM+nW83rgfLVsKlGKozV9lmDfhV566xYiPyMl5GMI0OQ8A6W/RwsFntCqtVsTZtZ FAVE/ARdydlfQxq5++AarXJVx/wO8/LPq18g2MA6jXIgsVokZM+9UFaxyHgbKERDXvNu cyfgo+k57CPrjq3xu7qhtpIDRSfjTArpg0dDgi4rkOSxABBnom5b37oHfnEPoDd2ktHg bus80jnzUVqD5s8wcZ55npAD3aQP2hC38adbcraTsjohetHtJHqaOqEqjhe0LEHNLKvS QcvA== X-Gm-Message-State: APjAAAVlGVJbSptDjRLyi1tOXtavMCRDjUokA5splU8k2pVNnEPttDZm tSJKjC8pGI0pudC6wxAqquHm5aJiZ+4Za5fxz6k= X-Google-Smtp-Source: APXvYqxQFrUYzLR51muw6xWoYS1TtAN4x8hADnWygx76GqczT7kBq4N2F5PQMlWmipUpFCiARR144YhMae4ozdtNIBM= X-Received: by 2002:adf:cc85:: with SMTP id p5mr9242071wrj.196.1582962448152; Fri, 28 Feb 2020 23:47:28 -0800 (PST) MIME-Version: 1.0 References: <20200228235003.112718-1-colin.king@canonical.com> In-Reply-To: <20200228235003.112718-1-colin.king@canonical.com> From: Pankaj Gupta Date: Sat, 29 Feb 2020 08:47:16 +0100 Message-ID: Subject: Re: [PATCH] mm/memblock: remove redundant assignment to variable max_addr To: Colin King Cc: Mike Rapoport , Andrew Morton , linux-mm@kvack.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > From: Colin Ian King > > The variable max_addr is being initialized with a value that is never > read and it is being updated later with a new value. The initialization > is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > mm/memblock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index eba94ee3de0b..4d06bbaded0f 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1698,7 +1698,7 @@ static phys_addr_t __init_memblock __find_max_addr(phys_addr_t limit) > > void __init memblock_enforce_memory_limit(phys_addr_t limit) > { > - phys_addr_t max_addr = PHYS_ADDR_MAX; > + phys_addr_t max_addr; > > if (!limit) > return; > -- > 2.25.0 Reviewed-by: Pankaj Gupta > >