From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22826C433E0 for ; Tue, 16 Feb 2021 08:26:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C711564E00 for ; Tue, 16 Feb 2021 08:26:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229862AbhBPI0r (ORCPT ); Tue, 16 Feb 2021 03:26:47 -0500 Received: from mail-lj1-f177.google.com ([209.85.208.177]:39986 "EHLO mail-lj1-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229812AbhBPIYS (ORCPT ); Tue, 16 Feb 2021 03:24:18 -0500 Received: by mail-lj1-f177.google.com with SMTP id g11so10754928ljj.7 for ; Tue, 16 Feb 2021 00:23:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K09L2ppL2qD1A0Be3qQdcGbeQRk+ta5oa+rnKfp/wak=; b=tsrNDL3mxvAslUcBXSf5mmUktJszs85IlBA2HlCTSZmySBvPLSMlvYEVvmc6GviAmT Jw3dYWU2wjvNM4j0Ijxo1UV3jsG9Z96XYVcahvRVcpdFuAxgrPbQ6+z4sAWhv6iPqnAF /nKEqm5ss0MD+FRWBGgDe6h2gI/4HicHls3LA/1Qd+qJIV3ApL+z6VlSJHTr3RZG1T4l mlXg85uIppSfVSVTG6hdXne/O0EcEl2rsyOHdNqyd74VEsGJzgPNU2y8EfJuMdrU5zI9 MCKRq1hCuoeo+wJu9Xxjt0s7snwpH/ae+JGuRm8KyflRwVRCRbbyMzd9GuPS+1SNmWGv JIYg== X-Gm-Message-State: AOAM5303ixSYb6uletYJpX5jD4zCZ/TwSr909Yj3Kn7zyh93V+GgG6dz W2OPpcIhrboZE/AvhQ1tTJR5VBz5UNMtNBtCOgY= X-Google-Smtp-Source: ABdhPJzfnOdCQ1vxGpDiGN+xCIWMazgRkFTQ/4a7ceYHSDmk/iRvci3NKC95EqzhEwF+Ex1bdOIpnAIv2k3SFWqokqk= X-Received: by 2002:a2e:b4af:: with SMTP id q15mr11494892ljm.166.1613463810341; Tue, 16 Feb 2021 00:23:30 -0800 (PST) MIME-Version: 1.0 References: <20210212090318.1522292-1-nakamura.shun@jp.fujitsu.com> <20210212090318.1522292-3-nakamura.shun@jp.fujitsu.com> In-Reply-To: From: Namhyung Kim Date: Tue, 16 Feb 2021 17:23:18 +0900 Message-ID: Subject: Re: [PATCH v6 2/3] perf tools: Add lexical definition of event name To: Jiri Olsa Cc: Shunsuke Nakamura , John Garry , Will Deacon , Mathieu Poirier , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , linux-arm-kernel@lists.infradead.org, linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 15, 2021 at 9:34 PM Jiri Olsa wrote: > > On Fri, Feb 12, 2021 at 06:03:17PM +0900, Shunsuke Nakamura wrote: > > Add the lexical definition of event name so that the numbers are recognizable. > > > > A64FX defines an event name that starts with a number. > > - 0inst_commit > > - 1inst_commit > > - 2inst_commit > > - 3inst_commit > > - 4inst_commit > > > > Signed-off-by: Shunsuke Nakamura > > --- > > tools/perf/util/parse-events.l | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l > > index 0b36285a9435..33f627187415 100644 > > --- a/tools/perf/util/parse-events.l > > +++ b/tools/perf/util/parse-events.l > > @@ -205,7 +205,7 @@ bpf_source [^,{}]+\.c[a-zA-Z0-9._]* > > num_dec [0-9]+ > > num_hex 0x[a-fA-F0-9]+ > > num_raw_hex [a-fA-F0-9]+ > > -name [a-zA-Z_*?\[\]][a-zA-Z0-9_*?.\[\]]* > > +name [a-zA-Z0-9_*?\[\]][a-zA-Z0-9_*?.\[\]]* > > I can't see anything broken because of this change, > also numbers are defined few lines before so we should > be fine But this change makes the syntax ambiguous with numbers and names. I don't think it's a good idea. Is it possible to change the event names not having numbers at the beginning like inst_commit0, inst_commit1 and so on? Thanks, Namhyung From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2F93C433E0 for ; Tue, 16 Feb 2021 08:25:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C66A64D9A for ; Tue, 16 Feb 2021 08:25:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C66A64D9A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vsM+y3q3JekfglQ9dmaQyd3caDGcB/6HnX4St49YQCY=; b=Tmy5sOBLCEkkq+E99Zg7HOdmc M09Gf0kvqD96xVV0xwcSzI86vVLAhKMDpTGl+waowFCoTP9lGbeBaMbdIrExg+F37loNo3nRRsl4C 8nRS2orQt7ixhexM2dWmOdhQ7cqrr/1rdADSM5agjD7sOdS/feJ/MwzKmKzn4AKfl1C/8X1beP1I6 YBfJsL6FMyiTq+qIeAGLLESDfIFpzCRypchjtVt88rPArmmxngVWJwxA0IrjtfzTK6u1++kj3Lg4t RiICXYzAVQ2SChp117jk2M+d2K7vokXAWnCtQDtnXhO9DlCx9c3HxxDX2fvb5PMugd9qYvh4Ls9Kq NPDhKXjnw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lBvdv-0004My-00; Tue, 16 Feb 2021 08:23:35 +0000 Received: from mail-lj1-f170.google.com ([209.85.208.170]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lBvds-0004M9-5G for linux-arm-kernel@lists.infradead.org; Tue, 16 Feb 2021 08:23:33 +0000 Received: by mail-lj1-f170.google.com with SMTP id e17so10738007ljl.8 for ; Tue, 16 Feb 2021 00:23:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K09L2ppL2qD1A0Be3qQdcGbeQRk+ta5oa+rnKfp/wak=; b=pf1jVIpnA+/AD8v3gAvxoWZiftBSaukdaTwlTTeL9FBeRmEqp9ImskasEzcntNxgHY +Gtwn3y765SbjwFcQUGrH9L/GlByIyzCqiuSeo67rECnfOnKRT9QltX+YleOwVDq082p L3ENBfoYUnHrgFQ0U4Xof+PJ/ZXsdUfZx84ZK5oHCTfxeou1ekneYwOuvZq59al74OZC rOuIinOnEC9bAcGHui3sT85Zx3Hc/bqoUYOxp+DstDM3DZfFRQCsVAcPdcM+q9tZGGnV KjvdZV36RMia3Ps4/1jnBKg7Xh99duhHUtm9e7S+TyBr790tzNltl7mRSnkbnoSwMHht S+LA== X-Gm-Message-State: AOAM5304DTh+Ke8shq0M/J1ctkAAFLxJwUwh46q3qrFlfICv44QD1Umw M2+r2OqzklzxQ9ukNSIIqd1uQXG+PZhr7eFG44U= X-Google-Smtp-Source: ABdhPJzfnOdCQ1vxGpDiGN+xCIWMazgRkFTQ/4a7ceYHSDmk/iRvci3NKC95EqzhEwF+Ex1bdOIpnAIv2k3SFWqokqk= X-Received: by 2002:a2e:b4af:: with SMTP id q15mr11494892ljm.166.1613463810341; Tue, 16 Feb 2021 00:23:30 -0800 (PST) MIME-Version: 1.0 References: <20210212090318.1522292-1-nakamura.shun@jp.fujitsu.com> <20210212090318.1522292-3-nakamura.shun@jp.fujitsu.com> In-Reply-To: From: Namhyung Kim Date: Tue, 16 Feb 2021 17:23:18 +0900 Message-ID: Subject: Re: [PATCH v6 2/3] perf tools: Add lexical definition of event name To: Jiri Olsa X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210216_032332_290841_9A9172C0 X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Shunsuke Nakamura , Mathieu Poirier , Peter Zijlstra , John Garry , linux-kernel , Arnaldo Carvalho de Melo , Alexander Shishkin , Ingo Molnar , Leo Yan , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 15, 2021 at 9:34 PM Jiri Olsa wrote: > > On Fri, Feb 12, 2021 at 06:03:17PM +0900, Shunsuke Nakamura wrote: > > Add the lexical definition of event name so that the numbers are recognizable. > > > > A64FX defines an event name that starts with a number. > > - 0inst_commit > > - 1inst_commit > > - 2inst_commit > > - 3inst_commit > > - 4inst_commit > > > > Signed-off-by: Shunsuke Nakamura > > --- > > tools/perf/util/parse-events.l | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l > > index 0b36285a9435..33f627187415 100644 > > --- a/tools/perf/util/parse-events.l > > +++ b/tools/perf/util/parse-events.l > > @@ -205,7 +205,7 @@ bpf_source [^,{}]+\.c[a-zA-Z0-9._]* > > num_dec [0-9]+ > > num_hex 0x[a-fA-F0-9]+ > > num_raw_hex [a-fA-F0-9]+ > > -name [a-zA-Z_*?\[\]][a-zA-Z0-9_*?.\[\]]* > > +name [a-zA-Z0-9_*?\[\]][a-zA-Z0-9_*?.\[\]]* > > I can't see anything broken because of this change, > also numbers are defined few lines before so we should > be fine But this change makes the syntax ambiguous with numbers and names. I don't think it's a good idea. Is it possible to change the event names not having numbers at the beginning like inst_commit0, inst_commit1 and so on? Thanks, Namhyung _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel