From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756674AbcA3Nwv (ORCPT <rfc822;w@1wt.eu>);
	Sat, 30 Jan 2016 08:52:51 -0500
Received: from mail-vk0-f42.google.com ([209.85.213.42]:35721 "EHLO
	mail-vk0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754220AbcA3Nwt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 30 Jan 2016 08:52:49 -0500
MIME-Version: 1.0
In-Reply-To: <20160129210008.GA32225@kernel.org>
References: <1453909257-26015-1-git-send-email-namhyung@kernel.org>
 <20160128081611.GC2322@krava.brq.redhat.com> <CAM9d7cjCHLrYNwFQn4zA-X8Lu9owTL691oLxyt-zWubwZu2mzg@mail.gmail.com>
 <CAM9d7cgqPMJe9RAf89aLoGaZWzNsjioymqARZnB4h48dvvJZ1g@mail.gmail.com>
 <20160128121245.GA17708@krava.brq.redhat.com> <20160128122454.GA27446@danjae.kornet>
 <20160128195225.GB12456@krava.brq.redhat.com> <20160129210008.GA32225@kernel.org>
From: Namhyung Kim <namhyung@kernel.org>
Date: Sat, 30 Jan 2016 22:52:29 +0900
X-Google-Sender-Auth: TSLK9o0K-_GdV2pDXwTo7kf_HOo
Message-ID: <CAM9d7cgFMKw3Ku-_bOeMvB2VS9ZpvfKP=OvpybdviLfAmSpsTA@mail.gmail.com>
Subject: Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2)
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Jiri Olsa <jolsa@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, Andi Kleen <andi@firstfloor.org>,
        David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Wang Nan <wangnan0@huawei.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Arnaldo,

On Sat, Jan 30, 2016 at 6:00 AM, Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
> Em Thu, Jan 28, 2016 at 08:52:25PM +0100, Jiri Olsa escreveu:
>> On Thu, Jan 28, 2016 at 09:24:54PM +0900, Namhyung Kim wrote:
>>
>> SNIP
>>
>> > > > > The default limit of hist entries is 0 so it basically shows all
>> > > > > entries.  But default callchain limit is 0.5% so hist entries under
>> > > > > 0.5% won't show callchains.
>> > > >
>> > > > Btw, I changed it to 0.005% in this patchset.  Did you apply all the
>> > > > patches and run 'perf report' with default value?
>> > >
>> > > yep, I had it and then reverted ;-) but I made typo
>> > > in the previous email.. what I meant was:
>> > >
>> > > also I see extra LINE for entries...  ;-)
>> >
>> > Ah, so you meant the blank lines..  The fix would be like following
>>
>> yep, tested.. works ;-)
>
> Namhyung, can I try to process this patchkit just by reading these
> commends and making the adjustments? Or is there something outstanding
> that warrants you to push a v2?

It'd great for me if you process this (v1).  I cannot work on the v2
for a couple of days..

Thanks,
Namhyung