From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932245AbbDVNyL (ORCPT <rfc822;w@1wt.eu>);
	Wed, 22 Apr 2015 09:54:11 -0400
Received: from mail-ob0-f169.google.com ([209.85.214.169]:36408 "EHLO
	mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756623AbbDVNyH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 22 Apr 2015 09:54:07 -0400
MIME-Version: 1.0
In-Reply-To: <20150422134120.GA29174@krava.redhat.com>
References: <1429687101-4360-1-git-send-email-namhyung@kernel.org>
 <1429687101-4360-9-git-send-email-namhyung@kernel.org> <20150422105409.GA27697@krava.redhat.com>
 <20150422130325.GA1622@danjae.kornet> <20150422132550.GA2316@kernel.org>
 <CAM9d7cjgbUNujP40e_YfU44LoiXawLt-KTONuJ1J2B22iSQpag@mail.gmail.com> <20150422134120.GA29174@krava.redhat.com>
From: Namhyung Kim <namhyung@kernel.org>
Date: Wed, 22 Apr 2015 22:53:45 +0900
X-Google-Sender-Auth: pMUS3rAvVQX9JzGWSG2Ra0gSBJg
Message-ID: <CAM9d7ch7x+Xez0kmN53k0cB8U=KtShsZhEjaJVnfgFs2jQkenA@mail.gmail.com>
Subject: Re: [PATCH 08/10] perf hists browser: Split popup menu actions - part 2
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 22, 2015 at 10:41 PM, Jiri Olsa <jolsa@redhat.com> wrote:
> On Wed, Apr 22, 2015 at 10:32:21PM +0900, Namhyung Kim wrote:
>> On Wed, Apr 22, 2015 at 10:25 PM, Arnaldo Carvalho de Melo
>> <acme@kernel.org> wrote:
>> > Em Wed, Apr 22, 2015 at 10:03:25PM +0900, Namhyung Kim escreveu:
>> >> Hi Jiri,
>> >>
>> >> On Wed, Apr 22, 2015 at 12:54:09PM +0200, Jiri Olsa wrote:
>> >> > On Wed, Apr 22, 2015 at 04:18:19PM +0900, Namhyung Kim wrote:
>> >> > > +         if (asprintf(optstr, "Run scripts for samples of thread [%s]",
>> >> > > +                      thread__comm_str(thread)) < 0)
>> >> > > +                 return 0;
>> >> > > + } else if (sym) {
>> >
>> >> >          ..............  && sym->namelen ;-)
>> >
>> >> Ouch!  sorry for missing this again.
>> >
>> >> Arnaldo, any chance you can fix this if you're gonna merge it?
>> >
>> > I can do that, but that slows down my rate of merging, so, if you could
>> > do like Adrian Hunter did, and fix this up, stick a V2 tag to it, then
>> > send it as a reply to the patch being fixed, that would help, so that
>> > when I get to it, and sort by thread, I will see the fix and will use
>> > it instead.
>>
>> OK.  Will send v2 soon!
>
> hum, I just told Arnaldo that I'm ok with not having the sym->namelen check..
>
> let's leave it as it is now and if we see blank line
> then we go and fix it on the proper place

Argh, I misunderstood your point,  I thought you wanted to leave the
sym->namelen check here and removing it in another patch with some
more investigation.  Yes, English is hard for me - I feel it more and
more these days ;-)

So it's all OK in the current form, right?

Thanks,
Namhyung