From: Namhyung Kim <namhyung@kernel.org>
To: "Liang, Kan" <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>,
Jiri Olsa <jolsa@redhat.com>, Andi Kleen <ak@linux.intel.com>,
Yao Jin <yao.jin@linux.intel.com>,
Michael Ellerman <mpe@ellerman.id.au>,
maddy@linux.vnet.ibm.com
Subject: Re: [PATCH V3 1/5] perf/core: Add PERF_SAMPLE_WEIGHT_STRUCT
Date: Thu, 4 Feb 2021 23:00:23 +0900 [thread overview]
Message-ID: <CAM9d7chzwnmSeKydv0Fb_iopcuMZxRsx2mZ66uVwcu_RMw+Vyg@mail.gmail.com> (raw)
In-Reply-To: <b970c739-6783-34d6-8676-44632c7c9428@linux.intel.com>
Hi Kan,
On Sat, Jan 30, 2021 at 2:25 AM Liang, Kan <kan.liang@linux.intel.com> wrote:
[SNIP]
> diff --git a/include/uapi/linux/perf_event.h
> b/include/uapi/linux/perf_event.h
> index b15e344..c50718a 100644
> --- a/include/uapi/linux/perf_event.h
> +++ b/include/uapi/linux/perf_event.h
> @@ -145,12 +145,14 @@ enum perf_event_sample_format {
> PERF_SAMPLE_CGROUP = 1U << 21,
> PERF_SAMPLE_DATA_PAGE_SIZE = 1U << 22,
> PERF_SAMPLE_CODE_PAGE_SIZE = 1U << 23,
> + PERF_SAMPLE_WEIGHT_STRUCT = 1U << 24,
>
> - PERF_SAMPLE_MAX = 1U << 24, /* non-ABI */
> + PERF_SAMPLE_MAX = 1U << 25, /* non-ABI */
>
> __PERF_SAMPLE_CALLCHAIN_EARLY = 1ULL << 63, /* non-ABI; internal use */
> };
>
> +#define PERF_SAMPLE_WEIGHT_TYPE (PERF_SAMPLE_WEIGHT |
> PERF_SAMPLE_WEIGHT_STRUCT)
I'm not sure you want to expose it in the uapi header as it's not
intended to be used IMHO.
Thanks,
Namhyung
> /*
> * values to program into branch_sample_type when PERF_SAMPLE_BRANCH
> is set
> *
> @@ -890,7 +892,25 @@ enum perf_event_type {
> * char data[size];
> * u64 dyn_size; } && PERF_SAMPLE_STACK_USER
> *
> - * { u64 weight; } && PERF_SAMPLE_WEIGHT
> + * { union perf_sample_weight
> + * {
> + * u64 full; && PERF_SAMPLE_WEIGHT
> + * #if defined(__LITTLE_ENDIAN_BITFIELD)
> + * struct {
> + * u32 var1_dw;
> + * u16 var2_w;
> + * u16 var3_w;
> + * } && PERF_SAMPLE_WEIGHT_STRUCT
> + * #elif defined(__BIG_ENDIAN_BITFIELD)
> + * struct {
> + * u16 var3_w;
> + * u16 var2_w;
> + * u32 var1_dw;
> + * } && PERF_SAMPLE_WEIGHT_STRUCT
> + * #endif
> + *
> + * }
> + * }
> * { u64 data_src; } && PERF_SAMPLE_DATA_SRC
> * { u64 transaction; } && PERF_SAMPLE_TRANSACTION
> * { u64 abi; # enum perf_sample_regs_abi
> @@ -1248,4 +1268,29 @@ struct perf_branch_entry {
> reserved:40;
> };
>
> +#if defined(__LITTLE_ENDIAN_BITFIELD)
> +union perf_sample_weight {
> + __u64 full;
> + struct {
> + __u32 var1_dw;
> + __u16 var2_w;
> + __u16 var3_w;
> + };
> +};
> +
> +#elif defined(__BIG_ENDIAN_BITFIELD)
> +
> +union perf_sample_weight {
> + __u64 full;
> + struct {
> + __u16 var3_w;
> + __u16 var2_w;
> + __u32 var1_dw;
> + };
> +};
> +
> +#else
> +#error "Unknown endianness"
> +#endif
> +
> #endif /* _UAPI_LINUX_PERF_EVENT_H */
next prev parent reply other threads:[~2021-02-04 14:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 22:40 [PATCH V3 0/5] perf core PMU support for Sapphire Rapids (Kernel) kan.liang
2021-01-28 22:40 ` [PATCH V3 1/5] perf/core: Add PERF_SAMPLE_WEIGHT_STRUCT kan.liang
2021-01-29 17:25 ` Liang, Kan
2021-02-04 14:00 ` Namhyung Kim [this message]
2021-02-04 15:24 ` Liang, Kan
2021-02-05 10:43 ` Namhyung Kim
2021-02-05 13:45 ` Liang, Kan
2021-02-02 11:57 ` [tip: perf/core] " tip-bot2 for Kan Liang
2021-01-28 22:40 ` [PATCH V3 2/5] perf/x86/intel: Factor out intel_update_topdown_event() kan.liang
2021-02-02 11:57 ` [tip: perf/core] " tip-bot2 for Kan Liang
2021-01-28 22:40 ` [PATCH V3 3/5] perf/x86/intel: Filter unsupported Topdown metrics event kan.liang
2021-02-02 11:57 ` [tip: perf/core] " tip-bot2 for Kan Liang
2021-01-28 22:40 ` [PATCH V3 4/5] perf/x86/intel: Add perf core PMU support for Sapphire Rapids kan.liang
2021-02-02 11:57 ` [tip: perf/core] " tip-bot2 for Kan Liang
2021-01-28 22:40 ` [PATCH V3 5/5] perf/x86/intel: Support CPUID 10.ECX to disable fixed counters kan.liang
2021-02-02 11:57 ` [tip: perf/core] " tip-bot2 for Kan Liang
2021-02-01 14:30 ` [PATCH V3 0/5] perf core PMU support for Sapphire Rapids (Kernel) Peter Zijlstra
2021-02-01 16:12 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM9d7chzwnmSeKydv0Fb_iopcuMZxRsx2mZ66uVwcu_RMw+Vyg@mail.gmail.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.