From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C994C32771 for ; Thu, 9 Jan 2020 07:51:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 518BD206ED for ; Thu, 9 Jan 2020 07:51:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578556297; bh=KVx6Xx/MG+W2QHhVP6/S43cttB9ypV02WGV657oo/s4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=CXUQUr+3qua0SCA+rQCUutx7Q6emWKvdqpT9Vd5Fib4b0j7/PLSG++L9m2dlb42E9 gjM0qmpjBwL+qa9arLpk0bPSL6nSRkl7wCAWrPrkgzZD0j2DtaEVIQeuYTmYpsGLdk jae9W0XfjpM2tEySsiQ5fFir03nUfEU/nX0KJksM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728332AbgAIHvg (ORCPT ); Thu, 9 Jan 2020 02:51:36 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:38693 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728184AbgAIHvg (ORCPT ); Thu, 9 Jan 2020 02:51:36 -0500 Received: by mail-wr1-f67.google.com with SMTP id y17so6274721wrh.5; Wed, 08 Jan 2020 23:51:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f7jKAd2k6zMLFNHzbXJbak8vuc1kQgCbhm39LF3QafA=; b=ltCQSNLCHch5K1kxyYNVnQ/lV4KRHa2zUPHC5/JY7WXWg8FlZ8Ut65ASBiJ04TRNl1 e6eBhoR8vxFPTPSqrIN1s2fUPWkuzy8Tt0gwHONNX16jjYIbNDF+Nzg6tnawYSmVWnkW 0AmhkphZjQlDwl94ARBSF1yThUZoPxGG4frPREiugAokNeL1VZsIiIiV3HSzfjX75sxv fCZwScv9vsCYcpNZQLfk3cgkMgB5DFOVdNIja5oQS5T+SqmYpabYNt6dogNN4sXSWyJi SAInn8cL+pT7FHgynkLq23VIvANDub/QOhAwbl1e95IVj7OvfRiScW5rdqrGIvQpnqHB 1iwQ== X-Gm-Message-State: APjAAAVS5WzykKKH2P5n78/kxi6pgManDu9G3EJ8J5B9toTNSlF9e1Jc L8DLpnPmvp2lFLojxNTT8kukla2IB23e5VEx5lLmaw== X-Google-Smtp-Source: APXvYqzZa/dLk/C0E+za19OrHOhco7sEr5NWaZA6GxB3Or3aoyqUEONi1OoE5UpRl/9tcMVVo/SWkRaUqx3IFzKGDQk= X-Received: by 2002:adf:ef10:: with SMTP id e16mr8801931wro.336.1578556294102; Wed, 08 Jan 2020 23:51:34 -0800 (PST) MIME-Version: 1.0 References: <20200107133501.327117-1-namhyung@kernel.org> <20200107133501.327117-7-namhyung@kernel.org> <20200108222156.GE12995@krava> In-Reply-To: <20200108222156.GE12995@krava> From: Namhyung Kim Date: Thu, 9 Jan 2020 16:51:23 +0900 Message-ID: Subject: Re: [PATCH 6/9] perf record: Support synthesizing cgroup events To: Jiri Olsa Cc: Ingo Molnar , Peter Zijlstra , Arnaldo Carvalho de Melo , Alexander Shishkin , Mark Rutland , Stephane Eranian , LKML , linux-perf-users Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 9, 2020 at 7:22 AM Jiri Olsa wrote: > > On Tue, Jan 07, 2020 at 10:34:58PM +0900, Namhyung Kim wrote: > > SNIP > > > + closedir(d); > > + return ret; > > +} > > + > > +int perf_event__synthesize_cgroups(struct perf_tool *tool, > > + perf_event__handler_t process, > > + struct machine *machine) > > +{ > > + union perf_event event; > > + char *cgrp_root; > > + size_t mount_len; /* length of mount point in the path */ > > + int ret = -1; > > + > > + cgrp_root = malloc(PATH_MAX); > > + if (cgrp_root == NULL) > > + return -1; > > + > > hum, we normally use bufs with PATH_MAX size on stack.. > is there some reason to use heap in here? No specific reason, will change. Thanks Namhyung