From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E43975C8B; Sat, 17 Feb 2024 00:25:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708129523; cv=none; b=LGwNf2IBYNlrC2JNDVAcvBD3zfCfQEu1o407kxAi9I6jkKWTVQCJbzSFXccur6cNibqlqb586zbGvX00d3FWXoED+XQD6mnbjZxThCanFYdlsMej7muaznQHe1SvBxx37WelKDRCusdRmq/QuE7vARY3TAayyriWNLSp5VplRTI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708129523; c=relaxed/simple; bh=TB3RsJQOiyTR8tEs8xp9ZVxkFZri+g+5FS8M54/Voa0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=f3YRCYAahlryNjFtsBpOqpCg9bdVXQgRsqWgEpsrPoR5gMIM+8luAYOpeC2XaUPmX9Yqm6XYCHhcR/HQpy0FbnSZVqv8MtBwPdeD1NHKXQeGS0BcYRLm15co/KhgKvOZvkKgFROxspS6jnMjpWq7NdRG91oWYni4ceh8Ew2ck9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-5cddfe0cb64so2087790a12.0; Fri, 16 Feb 2024 16:25:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708129521; x=1708734321; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gV3LRreLb1kZqKq2G0q5vBMXGxsObp5N7fG6tA3C6K8=; b=KOGv5NFOj4lVtbUwt6FmRVE099GCSoVBvp5B47tiZ8sbfP+u/GBhnuOSmjNGPhOC00 WBAzX8LC+Nii9s0Y339H0K8MURKLZS3lGLBsi2gC0mj/PaDEBYzIlo6zzwtXdml/gPIp fJO0e6BW1Vlx8AiYe5Tn7VPSmA5Gf3olK3lMYwxjQyfIhuetAZucCv1ipIdNy1X7Db16 FpsJ1czLwH0pcp0uihfMuD9y1OCjpMP/W1BMiHAWylLs7uAgoIfsAi6l/MtLG7LEAAEm OdfcczUKqUphdm4eabjE2VliQHEbexdHXQA0U729RsOP6htb/W3uRJx143kWQfXEPy2G AOrA== X-Forwarded-Encrypted: i=1; AJvYcCU6cMKPk9gOhyOg8gxRfJBiye+tRXsh7z/ZheAslzddFcrZmgccVtAkF7wa22ZNAoyK51g1fy2OZtx8ptqT9m/kXFswLnPHdEznOywrSaccehpcWXmhUfZIkI5OTlwprI5XVHaaEfy2jVFRh33YBHSD8u2YtN0ApbiC0hd+0xM+gexRuA== X-Gm-Message-State: AOJu0YzlAinW5BC3uba+kVeS2PYJ81cDBAy3FCWrPYXdtoy2lKhtMzsA S15MfAFavF2CoJfSGqtsJ1n5Ynljam8wghJHIU+1VpPHdSZZWQ8xfAySmITdgs4p9U5RB9Mv8Jq gP5ryyJNT98j6vZG0LoCaPt433Ws= X-Google-Smtp-Source: AGHT+IEgpCI0dTfACZVpuBHoCKGcTgiO+7b7Q9T9pTbKkzbsQbncP1/gmAFLhNBzmL85pp+qTwVtCNOZYq6nrUHrEq4= X-Received: by 2002:a05:6a21:1706:b0:19c:6a60:b433 with SMTP id nv6-20020a056a21170600b0019c6a60b433mr6463168pzb.3.1708129520906; Fri, 16 Feb 2024 16:25:20 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240202234057.2085863-1-irogers@google.com> <20240202234057.2085863-3-irogers@google.com> In-Reply-To: <20240202234057.2085863-3-irogers@google.com> From: Namhyung Kim Date: Fri, 16 Feb 2024 16:25:09 -0800 Message-ID: Subject: Re: [PATCH v3 2/8] libperf cpumap: Ensure empty cpumap is NULL from alloc To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , John Garry , Will Deacon , Thomas Gleixner , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Kan Liang , K Prateek Nayak , Sean Christopherson , Paolo Bonzini , Kajol Jain , Athira Rajeev , Andrew Jones , Alexandre Ghiti , Atish Patra , "Steinar H. Gunderson" , Yang Jihong , Yang Li , Changbin Du , Sandipan Das , Ravi Bangoria , Paran Lee , Nick Desaulniers , Huacai Chen , Yanteng Si , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Feb 2, 2024 at 3:41=E2=80=AFPM Ian Rogers wrot= e: > > Potential corner cases could cause a cpumap to be allocated with size > 0, but an empty cpumap should be represented as NULL. Add a path in > perf_cpu_map__alloc to ensure this. > > Suggested-by: James Clark > Closes: https://lore.kernel.org/lkml/2cd09e7c-eb88-6726-6169-647dcd0a8101= @arm.com/ > Signed-off-by: Ian Rogers > --- > tools/lib/perf/cpumap.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tools/lib/perf/cpumap.c b/tools/lib/perf/cpumap.c > index ba49552952c5..cae799ad44e1 100644 > --- a/tools/lib/perf/cpumap.c > +++ b/tools/lib/perf/cpumap.c > @@ -18,9 +18,13 @@ void perf_cpu_map__set_nr(struct perf_cpu_map *map, in= t nr_cpus) > > struct perf_cpu_map *perf_cpu_map__alloc(int nr_cpus) > { > - RC_STRUCT(perf_cpu_map) *cpus =3D malloc(sizeof(*cpus) + sizeof(s= truct perf_cpu) * nr_cpus); > + RC_STRUCT(perf_cpu_map) *cpus; > struct perf_cpu_map *result; > > + if (nr_cpus =3D=3D 0) > + return NULL; But allocation failure also returns NULL. Then callers should check what's the expected result. Thanks, Namhyung > + > + cpus =3D malloc(sizeof(*cpus) + sizeof(struct perf_cpu) * nr_cpus= ); > if (ADD_RC_CHK(result, cpus)) { > cpus->nr =3D nr_cpus; > refcount_set(&cpus->refcnt, 1); > -- > 2.43.0.594.gd9cf4e227d-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B5A8C48BF5 for ; Sat, 17 Feb 2024 00:25:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KilQ1T6pUHggU60Iy+k7MHHjtXl+E8130KEe0X0OMSQ=; b=tR+Cda4tNYBmxT 9arJ0Wv9F1gTa327M2XxCN4avW2dnkTEb+3FKVE/AU6CZyHhQ2Lo4cusLoSxH2bXxdceJCOD4R7HN Tj1Klc2M12oUM32m1VxtGvg9kKzhAIq923wDIr9FXYK3ZDxtSQ8BASHbp5IW9e+wVgJxe7ZP8RDIj RFj9F7HLRB87id6r7lhzufh1ri5jZplWnWOQvVG+/IHdDUo7Uvg2pw1Ebi555IQz3YWbaVZLvHkq7 O18wWKhPvAOGZpOAx03c1utmiDc+5zasIIjXFiMAxosRh5qasonal6EtW486q85/hszmRmahPTFOM 6yJM/263ncE/1NeMeFkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rb8WC-00000004Dpc-2jTy; Sat, 17 Feb 2024 00:25:24 +0000 Received: from mail-pg1-f175.google.com ([209.85.215.175]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rb8WA-00000004DoA-0Us2 for linux-arm-kernel@lists.infradead.org; Sat, 17 Feb 2024 00:25:23 +0000 Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-5d3912c9a83so1956330a12.3 for ; Fri, 16 Feb 2024 16:25:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708129521; x=1708734321; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gV3LRreLb1kZqKq2G0q5vBMXGxsObp5N7fG6tA3C6K8=; b=NFKL4rBEXxhQyqdY0jL0afGeDAsXPxwWeib64vZ1eNNeIwc1XnVMp1mW2eXD17ptHb I7JubquTQnZuuxERN4tk58csGtgyq8FM3Vi8uNOVi5qzOizyKB2oCkjfVw2x1zslTKqi 4RmzP/S68BJ928eMPJw1QAIWDLyvMtmjXHnzqZtXaU32IYDJL8GcicquusMgFjapU0NN oXRygX0TnW1tHs2oM4ORZvKZ0/mlGzZigY+rMErQumyvtr3VN7WPetWj75stIPvdMwll RCfmtZ9JhtNDoKTswqwUCSLap1FSjNfJ6diAfeLYD26l93FhimDxP3ta4zFXEvAhUfQv 8GKA== X-Forwarded-Encrypted: i=1; AJvYcCULKgF43LVeWC+BOZH9RQdWrmfdrq3+Mf+U35xojpYtShVogKoJMuAiw50MmHCIleKQpYvKJRd84yttlYPCW6xBPlL4sced0hwwquVqCDzdq0CFzdQ= X-Gm-Message-State: AOJu0Yynd9aMYNEr0R0+Q7kexCL6q7RS2CxYnLtrAoVoF/Y0hYZQ5CRi nt1pgFEuBuqYQ63wOG/+O+IsJAPbBwkGOnjTwkf0gBym/rTCyloxuwY8K2dAmi0RkYCazEkn6Gj jU4MlvmJSY1LTzQRZDy6XBeRChnI= X-Google-Smtp-Source: AGHT+IEgpCI0dTfACZVpuBHoCKGcTgiO+7b7Q9T9pTbKkzbsQbncP1/gmAFLhNBzmL85pp+qTwVtCNOZYq6nrUHrEq4= X-Received: by 2002:a05:6a21:1706:b0:19c:6a60:b433 with SMTP id nv6-20020a056a21170600b0019c6a60b433mr6463168pzb.3.1708129520906; Fri, 16 Feb 2024 16:25:20 -0800 (PST) MIME-Version: 1.0 References: <20240202234057.2085863-1-irogers@google.com> <20240202234057.2085863-3-irogers@google.com> In-Reply-To: <20240202234057.2085863-3-irogers@google.com> From: Namhyung Kim Date: Fri, 16 Feb 2024 16:25:09 -0800 Message-ID: Subject: Re: [PATCH v3 2/8] libperf cpumap: Ensure empty cpumap is NULL from alloc To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , John Garry , Will Deacon , Thomas Gleixner , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Kan Liang , K Prateek Nayak , Sean Christopherson , Paolo Bonzini , Kajol Jain , Athira Rajeev , Andrew Jones , Alexandre Ghiti , Atish Patra , "Steinar H. Gunderson" , Yang Jihong , Yang Li , Changbin Du , Sandipan Das , Ravi Bangoria , Paran Lee , Nick Desaulniers , Huacai Chen , Yanteng Si , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240216_162522_180083_B1EE4296 X-CRM114-Status: GOOD ( 17.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBGZWIgMiwgMjAyNCBhdCAzOjQx4oCvUE0gSWFuIFJvZ2VycyA8aXJvZ2Vyc0Bnb29n bGUuY29tPiB3cm90ZToKPgo+IFBvdGVudGlhbCBjb3JuZXIgY2FzZXMgY291bGQgY2F1c2UgYSBj cHVtYXAgdG8gYmUgYWxsb2NhdGVkIHdpdGggc2l6ZQo+IDAsIGJ1dCBhbiBlbXB0eSBjcHVtYXAg c2hvdWxkIGJlIHJlcHJlc2VudGVkIGFzIE5VTEwuIEFkZCBhIHBhdGggaW4KPiBwZXJmX2NwdV9t YXBfX2FsbG9jIHRvIGVuc3VyZSB0aGlzLgo+Cj4gU3VnZ2VzdGVkLWJ5OiBKYW1lcyBDbGFyayA8 amFtZXMuY2xhcmtAYXJtLmNvbT4KPiBDbG9zZXM6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xr bWwvMmNkMDllN2MtZWI4OC02NzI2LTYxNjktNjQ3ZGNkMGE4MTAxQGFybS5jb20vCj4gU2lnbmVk LW9mZi1ieTogSWFuIFJvZ2VycyA8aXJvZ2Vyc0Bnb29nbGUuY29tPgo+IC0tLQo+ICB0b29scy9s aWIvcGVyZi9jcHVtYXAuYyB8IDYgKysrKystCj4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlv bnMoKyksIDEgZGVsZXRpb24oLSkKPgo+IGRpZmYgLS1naXQgYS90b29scy9saWIvcGVyZi9jcHVt YXAuYyBiL3Rvb2xzL2xpYi9wZXJmL2NwdW1hcC5jCj4gaW5kZXggYmE0OTU1Mjk1MmM1Li5jYWU3 OTlhZDQ0ZTEgMTAwNjQ0Cj4gLS0tIGEvdG9vbHMvbGliL3BlcmYvY3B1bWFwLmMKPiArKysgYi90 b29scy9saWIvcGVyZi9jcHVtYXAuYwo+IEBAIC0xOCw5ICsxOCwxMyBAQCB2b2lkIHBlcmZfY3B1 X21hcF9fc2V0X25yKHN0cnVjdCBwZXJmX2NwdV9tYXAgKm1hcCwgaW50IG5yX2NwdXMpCj4KPiAg c3RydWN0IHBlcmZfY3B1X21hcCAqcGVyZl9jcHVfbWFwX19hbGxvYyhpbnQgbnJfY3B1cykKPiAg ewo+IC0gICAgICAgUkNfU1RSVUNUKHBlcmZfY3B1X21hcCkgKmNwdXMgPSBtYWxsb2Moc2l6ZW9m KCpjcHVzKSArIHNpemVvZihzdHJ1Y3QgcGVyZl9jcHUpICogbnJfY3B1cyk7Cj4gKyAgICAgICBS Q19TVFJVQ1QocGVyZl9jcHVfbWFwKSAqY3B1czsKPiAgICAgICAgIHN0cnVjdCBwZXJmX2NwdV9t YXAgKnJlc3VsdDsKPgo+ICsgICAgICAgaWYgKG5yX2NwdXMgPT0gMCkKPiArICAgICAgICAgICAg ICAgcmV0dXJuIE5VTEw7CgpCdXQgYWxsb2NhdGlvbiBmYWlsdXJlIGFsc28gcmV0dXJucyBOVUxM LiAgVGhlbiBjYWxsZXJzIHNob3VsZCBjaGVjawp3aGF0J3MgdGhlIGV4cGVjdGVkIHJlc3VsdC4K ClRoYW5rcywKTmFtaHl1bmcKCj4gKwo+ICsgICAgICAgY3B1cyA9IG1hbGxvYyhzaXplb2YoKmNw dXMpICsgc2l6ZW9mKHN0cnVjdCBwZXJmX2NwdSkgKiBucl9jcHVzKTsKPiAgICAgICAgIGlmIChB RERfUkNfQ0hLKHJlc3VsdCwgY3B1cykpIHsKPiAgICAgICAgICAgICAgICAgY3B1cy0+bnIgPSBu cl9jcHVzOwo+ICAgICAgICAgICAgICAgICByZWZjb3VudF9zZXQoJmNwdXMtPnJlZmNudCwgMSk7 Cj4gLS0KPiAyLjQzLjAuNTk0LmdkOWNmNGUyMjdkLWdvb2cKPgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=