From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3D2FC433E0 for ; Tue, 16 Feb 2021 07:35:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 718F064E00 for ; Tue, 16 Feb 2021 07:35:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229764AbhBPHfV (ORCPT ); Tue, 16 Feb 2021 02:35:21 -0500 Received: from mail-lj1-f178.google.com ([209.85.208.178]:36706 "EHLO mail-lj1-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229635AbhBPHfT (ORCPT ); Tue, 16 Feb 2021 02:35:19 -0500 Received: by mail-lj1-f178.google.com with SMTP id k22so9973273ljg.3 for ; Mon, 15 Feb 2021 23:35:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fpG6UAzqPxkA/Vi7szyWL/ZxJDo3MaeVBNCIuBYso9U=; b=Szjhlrno5cHjGbwJp67/MLUaq2zk+4SKCht19NhS57qUoYFZC1v/+xjdNSz7jjGxl4 0OawqCzjbf0dQm/J1e+mUwqBNebaGUgyGwG20iJdT3ZYcvZgidAMKncSWMVRpt/BCuKn WuORrBZKdIF780/WEUywCmy6uREYssyjV53/ZczAXQmFIx41Vv3UjxprJMr3R9X6gFUZ OD73SFRPJLe0U+9PWpSfwiFjxnj9niLHcj8IkbI3wD4Mdk2lb+/gprGW2gy8u2qNsXmG 20JIy1y8k4GMcMVNx2YihwzNNOTU7TkufaHkKyijDHvEc1ZahWvcvSumft9l/4OJYuhA 0VVg== X-Gm-Message-State: AOAM532ngnseeL6eXTnVkAwHlnlCCf/Y4onm3NaT/ijExtUBuNzxGzoe Qw//qw+a2XwDM7jrtVWRQhPX0128tqdau3hHNMM= X-Google-Smtp-Source: ABdhPJwcVhwbCeeblJPEbDrPghdMmtUrUxJAJ48BMu1dU5E63w8VtvWNIoDPyouqtm6XVQFe3WI3VmnfLHX86F+6sf0= X-Received: by 2002:a2e:505d:: with SMTP id v29mr10829818ljd.393.1613460876671; Mon, 15 Feb 2021 23:34:36 -0800 (PST) MIME-Version: 1.0 References: <1612165277-95878-1-git-send-email-yang.lee@linux.alibaba.com> In-Reply-To: <1612165277-95878-1-git-send-email-yang.lee@linux.alibaba.com> From: Namhyung Kim Date: Tue, 16 Feb 2021 16:34:25 +0900 Message-ID: Subject: Re: [PATCH] perf metricgroup: remove unneeded semicolon To: Yang Li Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Mon, Feb 1, 2021 at 4:41 PM Yang Li wrote: > > Eliminate the following coccicheck warning: > ./tools/perf/util/metricgroup.c:382:3-4: Unneeded semicolon > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Acked-by: Namhyung Kim Thanks, Namhyung > --- > tools/perf/util/metricgroup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c > index e6d3452..26c990e 100644 > --- a/tools/perf/util/metricgroup.c > +++ b/tools/perf/util/metricgroup.c > @@ -379,7 +379,7 @@ static int metricgroup__setup_events(struct list_head *groups, > metric_refs[i].metric_expr = ref->metric_expr; > i++; > } > - }; > + } > > expr->metric_refs = metric_refs; > expr->metric_expr = m->metric_expr; > -- > 1.8.3.1 >