From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A5B0C433DB for ; Wed, 6 Jan 2021 08:57:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2BAB82310B for ; Wed, 6 Jan 2021 08:57:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726674AbhAFI52 (ORCPT ); Wed, 6 Jan 2021 03:57:28 -0500 Received: from mail-lf1-f52.google.com ([209.85.167.52]:43892 "EHLO mail-lf1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726157AbhAFI52 (ORCPT ); Wed, 6 Jan 2021 03:57:28 -0500 Received: by mail-lf1-f52.google.com with SMTP id 23so4866219lfg.10 for ; Wed, 06 Jan 2021 00:57:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=clFikg6U9OcPV03UX6eTMGnsev34Le6yHfofxqKXJfo=; b=aEqHbB/v2fs9sy31WpEx1q1OiZk4IwprVS+ZtYZtWSakv7vcX0X9L7cF951BHRdu+j 3eTUMa/JD9ZSgNSsKN3Zmt545SUWVl9PX5hmBZMejf6CuA5o1u2fji9PIA1jLP94x7Pc byDlS4juMaT/J+BK91QwornXlErRx98Fnw1xcZ4oXnYa8w8dxxcA6i57D8M/kq9DAlxf YgUs4ZkGJtxRf0JRZy4FUi0CjN3b2vjGPiUVJMFk+CyPMOguXiD+kHitPUmV+Rm9JovZ RBKx9kcnmJDRpYPDIyYfi41L3KMldl59QvP/AQyEMCO78IIQ5I01+PlS8f5dJ6sOUX+T xeXA== X-Gm-Message-State: AOAM532mEFP4jlL7L8NWSxDfcEaLj8FdBCWlA64+QOmlGq3pnl3eJL0E u3zGsoHIZJzzk8iDQ7zpJTLLoL4KGXiq6gqENHo= X-Google-Smtp-Source: ABdhPJwTWccHE1U6TOEdVITjvkq7ZDH+pTbdazWUIozngyY3FGVCvzv4Ax/ZAThed1XC7q67pMlT1TUKGzzyd+0JpFM= X-Received: by 2002:ac2:5981:: with SMTP id w1mr1624120lfn.374.1609923404545; Wed, 06 Jan 2021 00:56:44 -0800 (PST) MIME-Version: 1.0 References: <20201223130320.3930-1-alexander.antonov@linux.intel.com> <20201223130320.3930-4-alexander.antonov@linux.intel.com> In-Reply-To: <20201223130320.3930-4-alexander.antonov@linux.intel.com> From: Namhyung Kim Date: Wed, 6 Jan 2021 17:56:33 +0900 Message-ID: Subject: Re: [PATCH v2 3/6] perf stat: Basic support for iiostat in perf To: Alexander Antonov Cc: Arnaldo Carvalho de Melo , linux-kernel , Jiri Olsa , Andi Kleen , Alexander Shishkin , Mark Rutland , Ian Rogers , Ingo Molnar , Peter Zijlstra Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 23, 2020 at 10:03 PM Alexander Antonov wrote: > > Add basic flow for a new iiostat mode in perf. Mode is intended to > provide four I/O performance metrics per each IIO stack: Inbound Read, > Inbound Write, Outbound Read, Outbound Write. It seems like a generic analysis and other archs can extend it later.. Then we can make it a bit more general.. at least, names? :) > > The actual code to compute the metrics and attribute it to > evsel::perf_device is in follow-on patches. > > Signed-off-by: Alexander Antonov > --- > tools/perf/builtin-stat.c | 33 ++++++++++++++++++++++++++++- > tools/perf/util/iiostat.h | 33 +++++++++++++++++++++++++++++ > tools/perf/util/stat-display.c | 38 +++++++++++++++++++++++++++++++++- > tools/perf/util/stat-shadow.c | 11 +++++++++- > tools/perf/util/stat.h | 1 + > 5 files changed, 113 insertions(+), 3 deletions(-) > create mode 100644 tools/perf/util/iiostat.h > > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c > index 72f9d0aa3f96..14c3da136927 100644 > --- a/tools/perf/builtin-stat.c > +++ b/tools/perf/builtin-stat.c > @@ -67,6 +67,7 @@ > #include "util/top.h" > #include "util/affinity.h" > #include "util/pfm.h" > +#include "util/iiostat.h" > #include "asm/bug.h" > > #include > @@ -198,7 +199,8 @@ static struct perf_stat_config stat_config = { > .walltime_nsecs_stats = &walltime_nsecs_stats, > .big_num = true, > .ctl_fd = -1, > - .ctl_fd_ack = -1 > + .ctl_fd_ack = -1, > + .iiostat_run = false, > }; > > static bool cpus_map_matched(struct evsel *a, struct evsel *b) > @@ -1073,6 +1075,14 @@ static int parse_stat_cgroups(const struct option *opt, > return parse_cgroups(opt, str, unset); > } > > +__weak int iiostat_parse(const struct option *opt __maybe_unused, > + const char *str __maybe_unused, > + int unset __maybe_unused) > +{ > + pr_err("iiostat mode is not supported\n"); > + return -1; > +} > + > static struct option stat_options[] = { > OPT_BOOLEAN('T', "transaction", &transaction_run, > "hardware transaction statistics"), > @@ -1185,6 +1195,8 @@ static struct option stat_options[] = { > "\t\t\t Optionally send control command completion ('ack\\n') to ack-fd descriptor.\n" > "\t\t\t Alternatively, ctl-fifo / ack-fifo will be opened and used as ctl-fd / ack-fd.", > parse_control_option), > + OPT_CALLBACK_OPTARG(0, "iiostat", &evsel_list, &stat_config, "root port", > + "measure PCIe metrics per IIO stack", iiostat_parse), > OPT_END() > }; > > @@ -1509,6 +1521,12 @@ static int perf_stat_init_aggr_mode_file(struct perf_stat *st) > return 0; > } > > +__weak int iiostat_show_root_ports(struct evlist *evlist __maybe_unused, > + struct perf_stat_config *config __maybe_unused) > +{ > + return 0; > +} I think it's too specific, maybe iiostat_prepare() ? > + > /* > * Add default attributes, if there were no attributes specified or > * if -d/--detailed, -d -d or -d -d -d is used: > @@ -2054,6 +2072,10 @@ static void setup_system_wide(int forks) > } > } > > +__weak void iiostat_delete_root_ports(struct evlist *evlist __maybe_unused) > +{ > +} Same here.. > + > int cmd_stat(int argc, const char **argv) > { > const char * const stat_usage[] = { > @@ -2230,6 +2252,12 @@ int cmd_stat(int argc, const char **argv) > goto out; > } > > + if (stat_config.iiostat_run) { > + status = iiostat_show_root_ports(evsel_list, &stat_config); > + if (status || !stat_config.iiostat_run) > + goto out; > + } > + > if (add_default_attributes()) > goto out; > > @@ -2406,6 +2434,9 @@ int cmd_stat(int argc, const char **argv) > perf_stat__exit_aggr_mode(); > perf_evlist__free_stats(evsel_list); > out: > + if (stat_config.iiostat_run) > + iiostat_delete_root_ports(evsel_list); > + > zfree(&stat_config.walltime_run); > > if (smi_cost && smi_reset) > diff --git a/tools/perf/util/iiostat.h b/tools/perf/util/iiostat.h > new file mode 100644 > index 000000000000..8d4226df9975 > --- /dev/null > +++ b/tools/perf/util/iiostat.h > @@ -0,0 +1,33 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * perf iiostat > + * > + * Copyright (C) 2020, Intel Corporation > + * > + * Authors: Alexander Antonov > + */ > + > +#ifndef _IIOSTAT_H > +#define _IIOSTAT_H > + > +#include > +#include "util/stat.h" > +#include "util/parse-events.h" > +#include "util/evlist.h" > + > +struct option; > +struct perf_stat_config; > +struct evlist; > +struct timespec; > + > +int iiostat_parse(const struct option *opt, const char *str, > + int unset __maybe_unused); > +void iiostat_prefix(struct perf_stat_config *config, struct evlist *evlist, > + char *prefix, struct timespec *ts); > +void iiostat_print_metric(struct perf_stat_config *config, struct evsel *evsel, > + struct perf_stat_output_ctx *out); > +int iiostat_show_root_ports(struct evlist *evlist, > + struct perf_stat_config *config); > +void iiostat_delete_root_ports(struct evlist *evlist); > + > +#endif /* _IIOSTAT_H */ > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c > index 3bfcdb80443a..9eb8484e8b90 100644 > --- a/tools/perf/util/stat-display.c > +++ b/tools/perf/util/stat-display.c > @@ -17,6 +17,7 @@ > #include "cgroup.h" > #include > #include "util.h" > +#include "iiostat.h" > > #define CNTR_NOT_SUPPORTED "" > #define CNTR_NOT_COUNTED "" > @@ -310,6 +311,12 @@ static void print_metric_header(struct perf_stat_config *config, > struct outstate *os = ctx; > char tbuf[1024]; > > + /* In case of iiostat, print metric header for first perf_device only */ > + if (os->evsel->perf_device && os->evsel->evlist->selected->perf_device && > + config->iiostat_run && When is the perf_device set? Is it possible to be NULL in the iiostat mode? Thanks, Namhyung > + os->evsel->perf_device != os->evsel->evlist->selected->perf_device) > + return; > + > if (!valid_only_metric(unit)) > return; > unit = fixunit(tbuf, os->evsel, unit);